From 0e828218f49b5047dbf925ac8b3f01e2d4b06cb0 Mon Sep 17 00:00:00 2001 From: Archish Thakkar Date: Tue, 30 Jan 2024 16:14:44 +0530 Subject: [PATCH 1/3] Update ci.yml --- .../templates/common/$.github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml b/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml index 7a8a3fbae..b692193df 100644 --- a/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml +++ b/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml @@ -143,7 +143,7 @@ jobs: - name: Install cocoapods if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true' run: | - yarn pod-install example/ios + cd example/ios && pod install env: NO_FLIPPER: 1 From b7008c47c7a646cec9eb6db4b9d13c142e53e995 Mon Sep 17 00:00:00 2001 From: Satyajit Sahoo Date: Fri, 2 Feb 2024 13:09:41 +0100 Subject: [PATCH 2/3] chore: remove pod-install from the template --- .github/workflows/build-templates.yml | 3 ++- .../src/utils/generateExampleApp.ts | 6 ------ .../templates/common/$package.json | 3 --- .../templates/common/CONTRIBUTING.md | 4 +++- 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build-templates.yml b/.github/workflows/build-templates.yml index 416c3a9e0..6711bc1d2 100644 --- a/.github/workflows/build-templates.yml +++ b/.github/workflows/build-templates.yml @@ -248,7 +248,8 @@ jobs: if: env.ios_build == 1 && env.turbo_cache_hit_ios != 1 && steps.library-cocoapods-cache.outputs.cache-hit != 'true' working-directory: ${{ env.work_dir }} run: | - yarn pod-install example/ios + cd example/ios + pod install env: NO_FLIPPER: 1 diff --git a/packages/create-react-native-library/src/utils/generateExampleApp.ts b/packages/create-react-native-library/src/utils/generateExampleApp.ts index de52dcb3e..91588b2fd 100644 --- a/packages/create-react-native-library/src/utils/generateExampleApp.ts +++ b/packages/create-react-native-library/src/utils/generateExampleApp.ts @@ -47,10 +47,6 @@ const PACKAGES_TO_ADD_WEB_DEV = { 'babel-loader': '^8.1.0', }; -const PACKAGES_TO_ADD_NATIVE_DEV = { - 'pod-install': '^0.1.0', -}; - export default async function generateExampleApp({ type, dest, @@ -164,8 +160,6 @@ export default async function generateExampleApp({ }); scripts.web = 'expo start --web'; - } else { - Object.assign(devDependencies, PACKAGES_TO_ADD_NATIVE_DEV); } await fs.writeJSON(path.join(directory, 'package.json'), pkg, { diff --git a/packages/create-react-native-library/templates/common/$package.json b/packages/create-react-native-library/templates/common/$package.json index b99548cf9..2f328db11 100644 --- a/packages/create-react-native-library/templates/common/$package.json +++ b/packages/create-react-native-library/templates/common/$package.json @@ -72,9 +72,6 @@ "eslint-config-prettier": "^8.5.0", "eslint-plugin-prettier": "^4.0.0", "jest": "^28.1.1", -<% if (example === 'native') { -%> - "pod-install": "^0.1.0", -<% } -%> "prettier": "^2.0.5", "react": "17.0.2", "react-native": "0.70.0", diff --git a/packages/create-react-native-library/templates/common/CONTRIBUTING.md b/packages/create-react-native-library/templates/common/CONTRIBUTING.md index 75082eb97..6d2908914 100644 --- a/packages/create-react-native-library/templates/common/CONTRIBUTING.md +++ b/packages/create-react-native-library/templates/common/CONTRIBUTING.md @@ -61,7 +61,9 @@ By default, the example is configured to build with the old architecture. To run 2. For iOS, run: ```sh - RCT_NEW_ARCH_ENABLED=1 yarn pod-install example/ios + cd example/ios + RCT_NEW_ARCH_ENABLED=1 pod install + cd - yarn example ios ``` From 5776b9917637da74e2b724c5ad3ffaf8ce27367f Mon Sep 17 00:00:00 2001 From: Satyajit Sahoo Date: Fri, 2 Feb 2024 13:10:31 +0100 Subject: [PATCH 3/3] chore: tweak --- .../templates/common/$.github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml b/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml index b692193df..c0982ee07 100644 --- a/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml +++ b/packages/create-react-native-library/templates/common/$.github/workflows/ci.yml @@ -143,7 +143,8 @@ jobs: - name: Install cocoapods if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true' run: | - cd example/ios && pod install + cd example/ios + pod install env: NO_FLIPPER: 1