From b757faf3c477dcf744caee4ecc1ab31818ddbc43 Mon Sep 17 00:00:00 2001 From: James Falcon Date: Thu, 24 Mar 2022 17:11:20 -0500 Subject: [PATCH 1/2] testing: Add missing mock to networking test --- tests/unittests/test_net_freebsd.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/unittests/test_net_freebsd.py b/tests/unittests/test_net_freebsd.py index 3facb2bb4ec..ecb504d2e8f 100644 --- a/tests/unittests/test_net_freebsd.py +++ b/tests/unittests/test_net_freebsd.py @@ -60,8 +60,9 @@ def _render_and_read( renderer.render_network_state(ns, target=target) return dir2dict(target) + @mock.patch("cloudinit.net.get_interfaces_by_mac") @mock.patch("cloudinit.subp.subp") - def test_render_output_has_yaml(self, mock_subp): + def test_render_output_has_yaml(self, m_get_interfaces, m_subp): entry = { "yaml": V1, From e514d82d1a0cbf28631a6ae9645515fd560ae845 Mon Sep 17 00:00:00 2001 From: James Falcon Date: Mon, 28 Mar 2022 14:00:50 -0500 Subject: [PATCH 2/2] comments --- tests/unittests/test_net_freebsd.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/unittests/test_net_freebsd.py b/tests/unittests/test_net_freebsd.py index ecb504d2e8f..1288c259881 100644 --- a/tests/unittests/test_net_freebsd.py +++ b/tests/unittests/test_net_freebsd.py @@ -60,10 +60,11 @@ def _render_and_read( renderer.render_network_state(ns, target=target) return dir2dict(target) - @mock.patch("cloudinit.net.get_interfaces_by_mac") - @mock.patch("cloudinit.subp.subp") - def test_render_output_has_yaml(self, m_get_interfaces, m_subp): - + @mock.patch( + "cloudinit.subp.subp", return_value=(SAMPLE_FREEBSD_IFCONFIG_OUT, 0) + ) + @mock.patch("cloudinit.util.is_FreeBSD", return_value=True) + def test_render_output_has_yaml(self, m_is_freebsd, m_subp): entry = { "yaml": V1, }