From 7413759dcad514403beda11232aa86d1ae97e8bd Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 11 Oct 2025 07:50:09 +0200 Subject: [PATCH 1/2] Activate test-app lint --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 155d93d5..6e3d3e16 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: - run: pnpm i -f # re-sync injected deps - name: Lint - run: pnpm --filter ember-basic-dropdown lint + run: pnpm --filter ember-basic-dropdown --filter test-app lint test: name: "Tests" From 7ec2ee973984caf489e4440c1d9f4a7f9455e309 Mon Sep 17 00:00:00 2001 From: Markus Sanin Date: Sat, 11 Oct 2025 07:55:54 +0200 Subject: [PATCH 2/2] Add missing component registration --- test-app/app/components/shadow-root.ts | 8 +++++++- test-app/app/components/shadow.ts | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/test-app/app/components/shadow-root.ts b/test-app/app/components/shadow-root.ts index 6a754fd5..b510009d 100644 --- a/test-app/app/components/shadow-root.ts +++ b/test-app/app/components/shadow-root.ts @@ -4,7 +4,7 @@ import { getOwner } from '@ember/owner'; // @ts-expect-error Public property 'isFastBoot' of exported class const isFastBoot = typeof FastBoot !== 'undefined'; -export default class ShadowRootComponent extends Component<{ +export default class ShadowRoot extends Component<{ Element: HTMLDivElement; Blocks: { default: [] }; }> { @@ -39,3 +39,9 @@ export default class ShadowRootComponent extends Component<{ return [...document.head.querySelectorAll('link')].map((link) => link.href); } } + +declare module '@glint/environment-ember-loose/registry' { + export default interface Registry { + ShadowRoot: typeof ShadowRoot; + } +} diff --git a/test-app/app/components/shadow.ts b/test-app/app/components/shadow.ts index 83858742..5271cbac 100644 --- a/test-app/app/components/shadow.ts +++ b/test-app/app/components/shadow.ts @@ -2,7 +2,7 @@ import Component from '@glimmer/component'; import { tracked } from '@glimmer/tracking'; import { modifier } from 'ember-modifier'; -export default class ShadowComponent extends Component<{ +export default class Shadow extends Component<{ Element: HTMLDivElement; Blocks: { default: [] }; }> { @@ -28,6 +28,6 @@ export default class ShadowComponent extends Component<{ declare module '@glint/environment-ember-loose/registry' { export default interface Registry { - Shadow: typeof ShadowComponent; + Shadow: typeof Shadow; } }