diff --git a/.oxlintrc.jsonc b/.oxlintrc.jsonc index e02cd2e29f..05bf9321f6 100644 --- a/.oxlintrc.jsonc +++ b/.oxlintrc.jsonc @@ -52,7 +52,7 @@ "no-unused-vars": [ "error", { - "argsIgnorePattern": ".*", + "argsIgnorePattern": "^_", "varsIgnorePattern": "^_", "ignoreRestSiblings": true, "fix": { "imports": "fix" }, diff --git a/packages/miniflare/src/plugins/core/index.ts b/packages/miniflare/src/plugins/core/index.ts index 27d673d315..67f7b5cee2 100644 --- a/packages/miniflare/src/plugins/core/index.ts +++ b/packages/miniflare/src/plugins/core/index.ts @@ -674,7 +674,7 @@ export const CORE_PLUGIN: Plugin< return Object.fromEntries(await Promise.all(bindingEntries)); }, async getServices({ - log, + log: _log, options, sharedOptions, workerBindings, diff --git a/packages/miniflare/src/workers/browser-rendering/binding.worker.ts b/packages/miniflare/src/workers/browser-rendering/binding.worker.ts index b3e4ff91c4..ad63146478 100644 --- a/packages/miniflare/src/workers/browser-rendering/binding.worker.ts +++ b/packages/miniflare/src/workers/browser-rendering/binding.worker.ts @@ -223,7 +223,7 @@ export class BrowserSession extends MiniflareDurableObject { }; @GET("/v1/devtools/browser/:sessionId") - connect: RouteHandler = async (req) => { + connect: RouteHandler = async (_req) => { assert( this.sessionInfo !== undefined, "sessionInfo must be set before connecting" diff --git a/packages/miniflare/test/plugins/kv/index.spec.ts b/packages/miniflare/test/plugins/kv/index.spec.ts index 81d63fa3f7..fb27887c7d 100644 --- a/packages/miniflare/test/plugins/kv/index.spec.ts +++ b/packages/miniflare/test/plugins/kv/index.spec.ts @@ -442,7 +442,7 @@ test("delete: deletes existing keys", async ({ expect }) => { await kv.delete("key"); expect(await kv.get("key")).toBe(null); }); -test("delete: does nothing for non-existent keys", async ({ expect }) => { +test("delete: does nothing for non-existent keys", async () => { const { kv } = ctx; await kv.delete("key"); }); diff --git a/packages/quick-edit-extension/scripts/bundle.ts b/packages/quick-edit-extension/scripts/bundle.ts index 102c2f539d..7c4e81a2d9 100644 --- a/packages/quick-edit-extension/scripts/bundle.ts +++ b/packages/quick-edit-extension/scripts/bundle.ts @@ -19,7 +19,7 @@ async function buildMain(flags: BuildFlags = {}) { { name: "workers-types", setup(build) { - build.onResolve({ filter: /^raw:.*/ }, async (args) => { + build.onResolve({ filter: /^raw:.*/ }, async () => { const result = path.resolve( "node_modules/@cloudflare/workers-types/experimental/index.d.ts" ); diff --git a/packages/workers-shared/router-worker/tests/index.test.ts b/packages/workers-shared/router-worker/tests/index.test.ts index ebdaba92e0..bd35ad57e3 100644 --- a/packages/workers-shared/router-worker/tests/index.test.ts +++ b/packages/workers-shared/router-worker/tests/index.test.ts @@ -36,15 +36,15 @@ describe("unit tests", () => { has_user_worker: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -66,10 +66,10 @@ describe("unit tests", () => { has_user_worker: false, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -90,10 +90,10 @@ describe("unit tests", () => { has_user_worker: false, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -117,15 +117,15 @@ describe("unit tests", () => { }, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -150,15 +150,15 @@ describe("unit tests", () => { }, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -183,15 +183,15 @@ describe("unit tests", () => { }, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -215,15 +215,15 @@ describe("unit tests", () => { }, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -247,15 +247,15 @@ describe("unit tests", () => { }, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return false; }, }, @@ -284,7 +284,7 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("", { headers: { "content-type": contentType }, }); @@ -408,7 +408,7 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response(userWorkerResponse.body, { status: userWorkerResponse.status, headers: userWorkerResponse.headers, @@ -440,7 +440,7 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("", { headers: { "content-type": "text/html" }, }); @@ -492,7 +492,7 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response(userWorkerResponse.body, { status: userWorkerResponse.status, headers: userWorkerResponse.headers, @@ -553,7 +553,7 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: true, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach user worker as it should be redirected by the router worker" ); @@ -583,19 +583,19 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: false, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach user worker as it should be redirected by the router worker" ); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach asset worker as it should be redirected by the router worker" ); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return false; }, }, @@ -623,19 +623,19 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: false, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach user worker as it should be redirected by the router worker" ); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach asset worker as it should be redirected by the router worker" ); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -770,12 +770,12 @@ describe("unit tests", () => { }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach asset worker as asset does not exist" ); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return false; }, }, @@ -799,17 +799,17 @@ describe("unit tests", () => { invoke_user_worker_ahead_of_assets: false, }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response( "should not reach user worker as it should be handled by asset worker" ); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -834,15 +834,15 @@ describe("unit tests", () => { }, EYEBALL_CONFIG: { limitedAssetsOnly: true }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -864,15 +864,15 @@ describe("unit tests", () => { }, EYEBALL_CONFIG: { limitedAssetsOnly: true }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return false; }, }, @@ -898,15 +898,15 @@ describe("unit tests", () => { }, EYEBALL_CONFIG: { limitedAssetsOnly: true }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -934,15 +934,15 @@ describe("unit tests", () => { }, EYEBALL_CONFIG: { limitedAssetsOnly: true }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, @@ -971,15 +971,15 @@ describe("unit tests", () => { }, EYEBALL_CONFIG: { limitedAssetsOnly: true }, USER_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from user worker"); }, }, ASSET_WORKER: { - async fetch(_: Request): Promise { + async fetch(_request: Request): Promise { return new Response("hello from asset worker"); }, - async unstable_canFetch(_: Request): Promise { + async unstable_canFetch(_request: Request): Promise { return true; }, }, diff --git a/packages/wrangler/e2e/containers.dev.test.ts b/packages/wrangler/e2e/containers.dev.test.ts index c5fd0853ed..64b0c30e79 100644 --- a/packages/wrangler/e2e/containers.dev.test.ts +++ b/packages/wrangler/e2e/containers.dev.test.ts @@ -227,9 +227,7 @@ for (const source of imageSource) { ); } }); - it(`will build or pull containers when miniflare starts`, async ({ - expect, - }) => { + it(`will build or pull containers when miniflare starts`, async () => { const worker = helper.runLongLived("wrangler dev"); await worker.readUntil(/Preparing container/); if (source === "pull") { diff --git a/packages/wrangler/e2e/deployments.test.ts b/packages/wrangler/e2e/deployments.test.ts index 77aef29dac..686b5b24b8 100644 --- a/packages/wrangler/e2e/deployments.test.ts +++ b/packages/wrangler/e2e/deployments.test.ts @@ -949,7 +949,7 @@ describe.skipIf(skipContainersTest)("containers", () => { this.ctx = ctx; } - async fetch(_: Request) { + async fetch(_request: Request) { if (!this.ctx.container) { return new Response('this.ctx.container not defined', { status: 500 }); } diff --git a/packages/wrangler/e2e/dev.test.ts b/packages/wrangler/e2e/dev.test.ts index de93375493..c96df9880d 100644 --- a/packages/wrangler/e2e/dev.test.ts +++ b/packages/wrangler/e2e/dev.test.ts @@ -661,9 +661,7 @@ describe.each([{ cmd: "wrangler dev" }])( await worker.readUntil(/end/); }); - it(`prints additional modules when vendored modules are present during ${cmd}`, async ({ - expect, - }) => { + it(`prints additional modules when vendored modules are present during ${cmd}`, async () => { const helper = new WranglerE2ETestHelper(); await helper.seed({ "wrangler.toml": dedent` @@ -959,7 +957,7 @@ describe.each(HYPERDRIVE_DATABASES)( it.skipIf(!CLOUDFLARE_ACCOUNT_ID || !process.env[envVar])( "does not require local connection string when running `wrangler dev --remote`", - async ({ expect }) => { + async () => { const helper = new WranglerE2ETestHelper(); const { id } = await helper.hyperdrive(false, scheme); @@ -1165,9 +1163,7 @@ describe("analytics engine", () => { }); describe("service worker", async () => { - it("using analytics engine datasets logs a warning in dev", async ({ - expect, - }) => { + it("using analytics engine datasets logs a warning in dev", async () => { const helper = new WranglerE2ETestHelper(); await helper.seed({ "wrangler.toml": dedent` @@ -1318,9 +1314,7 @@ describe.skipIf(CLOUDFLARE_ACCOUNT_ID !== "8d783f274e1f82dc46744c297b015a2f")( ); }); - it("fails with useful error message if host is not routable", async ({ - expect, - }) => { + it("fails with useful error message if host is not routable", async () => { const helper = new WranglerE2ETestHelper(); await helper.seed({ "wrangler.toml": dedent` diff --git a/packages/wrangler/e2e/multiworker-dev.test.ts b/packages/wrangler/e2e/multiworker-dev.test.ts index 015e1c936f..583d0004b8 100644 --- a/packages/wrangler/e2e/multiworker-dev.test.ts +++ b/packages/wrangler/e2e/multiworker-dev.test.ts @@ -566,9 +566,7 @@ describe("multiworker", () => { ); }); - it("should error if multiple pages configs are provided", async ({ - expect, - }) => { + it("should error if multiple pages configs are provided", async () => { const pages = helper.runLongLived( `wrangler pages dev -c wrangler.toml -c wrangler.toml`, { cwd: a } diff --git a/packages/wrangler/e2e/pages-dev.test.ts b/packages/wrangler/e2e/pages-dev.test.ts index dede691a31..56ea26e2c2 100644 --- a/packages/wrangler/e2e/pages-dev.test.ts +++ b/packages/wrangler/e2e/pages-dev.test.ts @@ -75,9 +75,7 @@ describe.sequential("wrangler pages dev", () => { ); }); - it("should show [--service] related warnings if specified as arg in the command line", async ({ - expect, - }) => { + it("should show [--service] related warnings if specified as arg in the command line", async () => { const helper = new WranglerE2ETestHelper(); const worker = helper.runLongLived( `${cmd} --port ${port} --inspector-port ${inspectorPort} . --service STAGING_SERVICE=test-worker@staging` diff --git a/tools/e2e/__tests__/common.test.ts b/tools/e2e/__tests__/common.test.ts index 8c1128861c..f2a55d087c 100644 --- a/tools/e2e/__tests__/common.test.ts +++ b/tools/e2e/__tests__/common.test.ts @@ -114,7 +114,7 @@ describe("listTmpE2EProjects()", () => { describe("deleteProject()", () => { // eslint-disable-next-line jest/expect-expect - it("makes a REST request to delete the given project", async ({ expect }) => { + it("makes a REST request to delete the given project", async () => { const MOCK_PROJECT = "mock-pages-project"; agent .get("https://api.cloudflare.com") @@ -196,7 +196,7 @@ describe("listTmpKVNamespaces()", () => { describe("deleteKVNamespace()", () => { // eslint-disable-next-line jest/expect-expect - it("makes a REST request to delete the given project", async ({ expect }) => { + it("makes a REST request to delete the given project", async () => { const MOCK_KV = "tmp_e2e_kv"; agent .get("https://api.cloudflare.com") @@ -290,7 +290,7 @@ describe("listTmpDatabases()", () => { describe("deleteDatabase()", () => { // eslint-disable-next-line jest/expect-expect - it("makes a REST request to delete the given project", async ({ expect }) => { + it("makes a REST request to delete the given project", async () => { const MOCK_DB = "tmp-e2e-db"; agent .get("https://api.cloudflare.com") @@ -348,7 +348,7 @@ describe("listTmpE2EWorkers()", () => { describe("deleteWorker()", () => { // eslint-disable-next-line jest/expect-expect - it("makes a REST request to delete the given project", async ({ expect }) => { + it("makes a REST request to delete the given project", async () => { const MOCK_WORKER = "mock-worker"; agent .get("https://api.cloudflare.com") @@ -407,9 +407,7 @@ describe("listTmpR2Buckets()", () => { describe("deleteR2Bucket()", () => { // eslint-disable-next-line jest/expect-expect - it("makes a REST request to delete the given R2 bucket", async ({ - expect, - }) => { + it("makes a REST request to delete the given R2 bucket", async () => { const MOCK_BUCKET = "tmp-e2e-abc123-next--workers-opennext-cache"; agent .get("https://api.cloudflare.com")