From 0a22935d26741e542a720b5d1da4cb3d1264d0fa Mon Sep 17 00:00:00 2001 From: Ruskin Constant <6400000+jonnyparris@users.noreply.github.com> Date: Thu, 16 Apr 2026 14:15:47 +0100 Subject: [PATCH 1/3] Rename browser-rendering fixture directory and test file to browser-run MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Follow-up cleanup from #13516 per review feedback from @petebacondarwin: - fixtures/browser-rendering/ → fixtures/browser-run/ - browser-rendering.test.ts → browser-run.test.ts - Updated fixture package.json name and pnpm-lock.yaml beep-boop-🤖 --- .changeset/rename-browser-run-cleanup.md | 5 +++++ fixtures/{browser-rendering => browser-run}/package.json | 2 +- fixtures/{browser-rendering => browser-run}/src/index.ts | 0 .../{browser-rendering => browser-run}/src/playwright.ts | 0 fixtures/{browser-rendering => browser-run}/src/puppeteer.ts | 0 .../{browser-rendering => browser-run}/test/index.spec.ts | 0 .../{browser-rendering => browser-run}/test/tsconfig.json | 0 fixtures/{browser-rendering => browser-run}/tsconfig.json | 0 .../{browser-rendering => browser-run}/vitest.config.mts | 0 .../worker-configuration.d.ts | 0 fixtures/{browser-rendering => browser-run}/wrangler.jsonc | 0 .../{browser-rendering.test.ts => browser-run.test.ts} | 0 pnpm-lock.yaml | 2 +- 13 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/rename-browser-run-cleanup.md rename fixtures/{browser-rendering => browser-run}/package.json (93%) rename fixtures/{browser-rendering => browser-run}/src/index.ts (100%) rename fixtures/{browser-rendering => browser-run}/src/playwright.ts (100%) rename fixtures/{browser-rendering => browser-run}/src/puppeteer.ts (100%) rename fixtures/{browser-rendering => browser-run}/test/index.spec.ts (100%) rename fixtures/{browser-rendering => browser-run}/test/tsconfig.json (100%) rename fixtures/{browser-rendering => browser-run}/tsconfig.json (100%) rename fixtures/{browser-rendering => browser-run}/vitest.config.mts (100%) rename fixtures/{browser-rendering => browser-run}/worker-configuration.d.ts (100%) rename fixtures/{browser-rendering => browser-run}/wrangler.jsonc (100%) rename packages/wrangler/src/__tests__/{browser-rendering.test.ts => browser-run.test.ts} (100%) diff --git a/.changeset/rename-browser-run-cleanup.md b/.changeset/rename-browser-run-cleanup.md new file mode 100644 index 0000000000..20b12ff174 --- /dev/null +++ b/.changeset/rename-browser-run-cleanup.md @@ -0,0 +1,5 @@ +--- +"wrangler": patch +--- + +Rename `fixtures/browser-rendering` directory and `browser-rendering.test.ts` test file to use `browser-run` naming, following the Browser Run product rename. diff --git a/fixtures/browser-rendering/package.json b/fixtures/browser-run/package.json similarity index 93% rename from fixtures/browser-rendering/package.json rename to fixtures/browser-run/package.json index c8eb69db55..3287477212 100644 --- a/fixtures/browser-rendering/package.json +++ b/fixtures/browser-run/package.json @@ -1,5 +1,5 @@ { - "name": "@fixture/browser-rendering", + "name": "@fixture/browser-run", "private": true, "scripts": { "cf-typegen": "wrangler types", diff --git a/fixtures/browser-rendering/src/index.ts b/fixtures/browser-run/src/index.ts similarity index 100% rename from fixtures/browser-rendering/src/index.ts rename to fixtures/browser-run/src/index.ts diff --git a/fixtures/browser-rendering/src/playwright.ts b/fixtures/browser-run/src/playwright.ts similarity index 100% rename from fixtures/browser-rendering/src/playwright.ts rename to fixtures/browser-run/src/playwright.ts diff --git a/fixtures/browser-rendering/src/puppeteer.ts b/fixtures/browser-run/src/puppeteer.ts similarity index 100% rename from fixtures/browser-rendering/src/puppeteer.ts rename to fixtures/browser-run/src/puppeteer.ts diff --git a/fixtures/browser-rendering/test/index.spec.ts b/fixtures/browser-run/test/index.spec.ts similarity index 100% rename from fixtures/browser-rendering/test/index.spec.ts rename to fixtures/browser-run/test/index.spec.ts diff --git a/fixtures/browser-rendering/test/tsconfig.json b/fixtures/browser-run/test/tsconfig.json similarity index 100% rename from fixtures/browser-rendering/test/tsconfig.json rename to fixtures/browser-run/test/tsconfig.json diff --git a/fixtures/browser-rendering/tsconfig.json b/fixtures/browser-run/tsconfig.json similarity index 100% rename from fixtures/browser-rendering/tsconfig.json rename to fixtures/browser-run/tsconfig.json diff --git a/fixtures/browser-rendering/vitest.config.mts b/fixtures/browser-run/vitest.config.mts similarity index 100% rename from fixtures/browser-rendering/vitest.config.mts rename to fixtures/browser-run/vitest.config.mts diff --git a/fixtures/browser-rendering/worker-configuration.d.ts b/fixtures/browser-run/worker-configuration.d.ts similarity index 100% rename from fixtures/browser-rendering/worker-configuration.d.ts rename to fixtures/browser-run/worker-configuration.d.ts diff --git a/fixtures/browser-rendering/wrangler.jsonc b/fixtures/browser-run/wrangler.jsonc similarity index 100% rename from fixtures/browser-rendering/wrangler.jsonc rename to fixtures/browser-run/wrangler.jsonc diff --git a/packages/wrangler/src/__tests__/browser-rendering.test.ts b/packages/wrangler/src/__tests__/browser-run.test.ts similarity index 100% rename from packages/wrangler/src/__tests__/browser-rendering.test.ts rename to packages/wrangler/src/__tests__/browser-run.test.ts diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 419e57a795..fd97724d6a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -184,7 +184,7 @@ importers: specifier: workspace:* version: link:../../packages/wrangler - fixtures/browser-rendering: + fixtures/browser-run: devDependencies: '@cloudflare/playwright': specifier: ^1.0.0 From 55d4a95c51aa4fc63a2eb3c7b5cfff6b340fffb2 Mon Sep 17 00:00:00 2001 From: Ruskin Constant <6400000+jonnyparris@users.noreply.github.com> Date: Thu, 16 Apr 2026 14:29:55 +0100 Subject: [PATCH 2/3] =?UTF-8?q?Remove=20unnecessary=20changeset=20?= =?UTF-8?q?=E2=80=94=20test-only=20rename,=20no=20user-facing=20impact?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit beep-boop-🤖 --- .changeset/rename-browser-run-cleanup.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .changeset/rename-browser-run-cleanup.md diff --git a/.changeset/rename-browser-run-cleanup.md b/.changeset/rename-browser-run-cleanup.md deleted file mode 100644 index 20b12ff174..0000000000 --- a/.changeset/rename-browser-run-cleanup.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"wrangler": patch ---- - -Rename `fixtures/browser-rendering` directory and `browser-rendering.test.ts` test file to use `browser-run` naming, following the Browser Run product rename. From b0f47ba492733c75a6faefad674ac3000a39ca53 Mon Sep 17 00:00:00 2001 From: Ruskin Constant <6400000+jonnyparris@users.noreply.github.com> Date: Thu, 16 Apr 2026 15:09:26 +0100 Subject: [PATCH 3/3] Fix CI filter for renamed browser-run fixture directory MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Ubuntu exclusion filter still referenced the old fixtures/browser-rendering path, which would silently stop matching after the rename and cause browser tests to run on Ubuntu where they fail due to AppArmor/Puppeteer issues. beep-boop-🤖 --- .github/workflows/test-and-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-and-check.yml b/.github/workflows/test-and-check.yml index eeae7b3e97..585d23f3b1 100644 --- a/.github/workflows/test-and-check.yml +++ b/.github/workflows/test-and-check.yml @@ -149,8 +149,8 @@ jobs: - name: Run tests (fixtures) if: steps.changes.outputs.everything_but_markdown == 'true' && matrix.suite == 'fixtures' - # Browser rendering is disabled on Ubuntu because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu - run: pnpm run test:ci --concurrency 1 --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-rendering"' || '' }} + # Browser Run fixture is disabled on Ubuntu because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu + run: pnpm run test:ci --concurrency 1 --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-run"' || '' }} env: NODE_OPTIONS: "--max_old_space_size=8192" WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/