From baa88b630e56f4b1aaeb2f932f0006243397be21 Mon Sep 17 00:00:00 2001 From: Marco Nenciarini Date: Fri, 30 May 2025 14:17:52 +0200 Subject: [PATCH 1/2] fix: inject the sidecar only during Pod/Job creation Closes #377 Signed-off-by: Marco Nenciarini --- internal/cnpgi/operator/lifecycle.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/internal/cnpgi/operator/lifecycle.go b/internal/cnpgi/operator/lifecycle.go index f2a73071..eb2513ce 100644 --- a/internal/cnpgi/operator/lifecycle.go +++ b/internal/cnpgi/operator/lifecycle.go @@ -95,6 +95,15 @@ func (impl LifecycleImplementation) LifecycleHook( return nil, nil } + // Only allow modifications during EVALUATE or CREATE operations. + // For PATCH, UPDATE, or other operations, skip processing as the operator will handle changes during EVALUATE. + if *operation != lifecycle.OperatorOperationType_TYPE_EVALUATE && + *operation != lifecycle.OperatorOperationType_TYPE_CREATE { + contextLogger.Trace("Skipping lifecycle hook: operation is not EVALUATE or CREATE", + "operation", operation.String()) + return nil, nil + } + switch kind { case "Pod": contextLogger.Info("Reconciling pod") From ccf9848238f6cd8aab2d1a75950d66f956174ab2 Mon Sep 17 00:00:00 2001 From: Armando Ruocco Date: Fri, 30 May 2025 18:05:47 +0200 Subject: [PATCH 2/2] chore: simplify Signed-off-by: Armando Ruocco --- internal/cnpgi/operator/lifecycle.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/internal/cnpgi/operator/lifecycle.go b/internal/cnpgi/operator/lifecycle.go index eb2513ce..d5c99185 100644 --- a/internal/cnpgi/operator/lifecycle.go +++ b/internal/cnpgi/operator/lifecycle.go @@ -41,9 +41,6 @@ func (impl LifecycleImplementation) GetCapabilities( { Type: lifecycle.OperatorOperationType_TYPE_CREATE, }, - { - Type: lifecycle.OperatorOperationType_TYPE_PATCH, - }, { Type: lifecycle.OperatorOperationType_TYPE_EVALUATE, }, @@ -95,15 +92,6 @@ func (impl LifecycleImplementation) LifecycleHook( return nil, nil } - // Only allow modifications during EVALUATE or CREATE operations. - // For PATCH, UPDATE, or other operations, skip processing as the operator will handle changes during EVALUATE. - if *operation != lifecycle.OperatorOperationType_TYPE_EVALUATE && - *operation != lifecycle.OperatorOperationType_TYPE_CREATE { - contextLogger.Trace("Skipping lifecycle hook: operation is not EVALUATE or CREATE", - "operation", operation.String()) - return nil, nil - } - switch kind { case "Pod": contextLogger.Info("Reconciling pod")