From 933a3d3d1a56652ec050473016d81881c873c394 Mon Sep 17 00:00:00 2001 From: Pierre Glaser Date: Wed, 29 Jan 2020 18:48:31 +0100 Subject: [PATCH 1/2] test properties on a new-style class. Properties only work on new-style classes --- tests/cloudpickle_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cloudpickle_test.py b/tests/cloudpickle_test.py index f681aa274..698ca3390 100644 --- a/tests/cloudpickle_test.py +++ b/tests/cloudpickle_test.py @@ -1179,7 +1179,7 @@ def func(x): self.assertEqual(cloned.__qualname__, func.__qualname__) def test_property(self): - class MyObject: + class MyObject(object): _read_only_value = 1 _read_write_value = 1 From ad28cf2d6cfbc18600c5ac4691b70865cbb9f693 Mon Sep 17 00:00:00 2001 From: Pierre Glaser Date: Wed, 29 Jan 2020 19:43:21 +0100 Subject: [PATCH 2/2] Mention @property is for new-style classes only --- tests/cloudpickle_test.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cloudpickle_test.py b/tests/cloudpickle_test.py index 698ca3390..0251f34ea 100644 --- a/tests/cloudpickle_test.py +++ b/tests/cloudpickle_test.py @@ -1179,6 +1179,8 @@ def func(x): self.assertEqual(cloned.__qualname__, func.__qualname__) def test_property(self): + # Note that the @property decorator only has an effect on new-style + # classes. class MyObject(object): _read_only_value = 1 _read_write_value = 1