From c75e058f41df5e771f617ee663164b4a6e17e712 Mon Sep 17 00:00:00 2001
From: Ihsan Ullah <ihsanullah@Pixel-io.local>
Date: Sun, 28 May 2023 15:06:39 +0500
Subject: [PATCH 1/5] separate tab for submissions

---
 .../migrations/0006_auto_20230528_0829.py     |  19 +
 src/static/riot/datasets/management.tag       |  42 +--
 src/static/riot/management.tag                |   8 +-
 .../riot/submissions/resource_submissions.tag | 344 ++++++++++++++++++
 4 files changed, 387 insertions(+), 26 deletions(-)
 create mode 100644 src/apps/datasets/migrations/0006_auto_20230528_0829.py
 create mode 100644 src/static/riot/submissions/resource_submissions.tag

diff --git a/src/apps/datasets/migrations/0006_auto_20230528_0829.py b/src/apps/datasets/migrations/0006_auto_20230528_0829.py
new file mode 100644
index 000000000..8e51ba6c3
--- /dev/null
+++ b/src/apps/datasets/migrations/0006_auto_20230528_0829.py
@@ -0,0 +1,19 @@
+# Generated by Django 2.2.17 on 2023-05-28 08:29
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('datasets', '0005_auto_20230527_0837'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='data',
+            name='competition',
+            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.PROTECT, related_name='submission', to='competitions.Competition'),
+        ),
+    ]
diff --git a/src/static/riot/datasets/management.tag b/src/static/riot/datasets/management.tag
index 3940c6c69..b25bf6032 100644
--- a/src/static/riot/datasets/management.tag
+++ b/src/static/riot/datasets/management.tag
@@ -1,7 +1,5 @@
 <data-management>
-    <!-------------------------------------
-             Search and filter bits
-      -------------------------------------->
+    <!-- Search and filter bits -->
       
     <div class="ui icon input">
         <input type="text" placeholder="Search..." ref="search" onkeyup="{ filter.bind(this, undefined) }">
@@ -25,14 +23,11 @@
         Delete Selected Datasets
     </button>
 
-    <!-------------------------------------
-                  Data Table
-      -------------------------------------->
+    <!-- Data Table -->
     <table class="ui {selectable: datasets.length > 0} celled compact table">
         <thead>
         <tr>
             <th>File Name</th>
-            <th>Competition in</th>
             <th width="175px">Type</th>
             <th width="175px">Size</th>
             <th width="125px">Uploaded</th>
@@ -46,12 +41,7 @@
         <tr each="{ dataset, index in datasets }"
             class="dataset-row"
             onclick="{show_info_modal.bind(this, dataset)}">
-            <!--  show file name if exists otherwise show name(for old submissions)  -->
-            <td>{ dataset.file_name || dataset.name }</td>
-            <!--  show compeition name as link if competition is available -->
-            <td if="{dataset.competition}"><a class="link-no-deco" target="_blank" href="../competitions/{ dataset.competition.id }">{ dataset.competition.title }</a></td>
-            <!--  show empty td if competition is not available  -->
-            <td if="{!dataset.competition}"></td>
+            <td>{ dataset.name }</td>
             <td>{ dataset.type }</td>
             <td>{ format_file_size(dataset.file_size) }</td>
             <td>{ timeSince(Date.parse(dataset.created_when)) } ago</td>
@@ -82,11 +72,9 @@
         </tbody>
         <tfoot>
 
-        <!-------------------------------------
-                      Pagination
-        -------------------------------------->
+        <!-- Pagination -->
         <tr>
-            <th colspan="9" if="{datasets.length > 0}">
+            <th colspan="8" if="{datasets.length > 0}">
                 <div class="ui right floated pagination menu" if="{datasets.length > 0}">
                     <a show="{!!_.get(pagination, 'previous')}" class="icon item" onclick="{previous_page}">
                         <i class="left chevron icon"></i>
@@ -105,7 +93,7 @@
 
     <div ref="info_modal" class="ui modal">
         <div class="header">
-            {selected_row.file_name || selected_row.name}
+            {selected_row.name}
         </div>
         <div class="content">
             <h3>Details</h3>
@@ -114,7 +102,6 @@
                 <thead>
                 <tr>
                     <th>Key</th>
-                    <th>Competition in</th>
                     <th>Created By</th>
                     <th>Created</th>
                     <th>Type</th>
@@ -124,10 +111,6 @@
                 <tbody>
                 <tr>
                     <td>{selected_row.key}</td>
-                    <!--  show compeition name as link if competition is available -->
-                    <td if="{selected_row.competition}"><a class="link-no-deco" target="_blank" href="../competitions/{ selected_row.competition.id }">{ selected_row.competition.title }</a></td>
-                    <!--  show empty td if competition is not available  -->
-                    <td if="{!selected_row.competition}"></td>
                     <td>{selected_row.created_by}</td>
                     <td>{pretty_date(selected_row.created_when)}</td>
                     <td>{_.startCase(selected_row.type)}</td>
@@ -223,7 +206,6 @@
             "reference_data",
             "scoring_program",
             "starting_kit",
-            "submission",
         ]
         self.errors = []
         self.datasets = []
@@ -299,6 +281,7 @@
             CODALAB.api.get_datasets(filters)
                 .done(function (data) {
                     self.datasets = data.results
+                    self.datasets = self.filter_out_submissions(self.datasets)
                     self.pagination = {
                         "count": data.count,
                         "next": data.next,
@@ -457,6 +440,17 @@
             }
         }
 
+        // Function to remove submissions from datasets
+        self.filter_out_submissions = function(datasets) {
+            datasets_to_return = []
+            datasets.forEach(dataset => {
+                if (dataset.type != "submission"){
+                    datasets_to_return.push(dataset)
+                }
+            })
+            return datasets_to_return
+        }
+
         // Function to format file size 
         self.format_file_size = function(file_size) {
             // parse file size from string to float
diff --git a/src/static/riot/management.tag b/src/static/riot/management.tag
index ab481e475..904093abf 100644
--- a/src/static/riot/management.tag
+++ b/src/static/riot/management.tag
@@ -2,7 +2,8 @@
     <!--Todo: ultimately decide whether this belongs on tasks:management or dataset:management
             Is currently at both locations-->
     <div class="ui top attached tabular menu">
-        <div class="active item" data-tab="datasets">Datasets and programs</div>
+        <div class="active item" data-tab="submissions">Submissions</div>
+        <div class="item" data-tab="datasets">Datasets and programs</div>
         <div class="item" data-tab="tasks">Tasks</div>
         <div class="right menu">
             <div class="item">
@@ -12,7 +13,10 @@
             </div>
         </div>
     </div>
-    <div class="ui active bottom attached tab segment" data-tab="datasets">
+    <div class="ui active bottom attached tab segment" data-tab="submissions">
+        <submission-management></submission-management>
+    </div>
+    <div class="ui bottom attached tab segment" data-tab="datasets">
         <data-management></data-management>
     </div>
     <div class="ui bottom attached tab segment" data-tab="tasks">
diff --git a/src/static/riot/submissions/resource_submissions.tag b/src/static/riot/submissions/resource_submissions.tag
new file mode 100644
index 000000000..f1b082add
--- /dev/null
+++ b/src/static/riot/submissions/resource_submissions.tag
@@ -0,0 +1,344 @@
+<submission-management>
+
+    <!--  Search -->
+    <div class="ui icon input">
+        <input type="text" placeholder="Search..." ref="search" onkeyup="{ filter.bind(this, undefined) }">
+        <i class="search icon"></i>
+    </div>
+    <button class="ui red right floated labeled icon button {disabled: marked_submissions.length === 0}" onclick="{delete_submissions}">
+        <i class="icon delete"></i>
+        Delete Selected Submissions
+    </button>
+
+    <!-- Data Table -->
+    <table class="ui {selectable: submissions.length > 0} celled compact table">
+        <thead>
+        <tr>
+            <th>File Name</th>
+            <th>Competition in</th>
+            <th width="175px">Size</th>
+            <th width="125px">Uploaded</th>
+            <th width="60px">Public</th>
+            <th width="50px">Delete?</th>
+            <th width="25px"></th>
+        </tr>
+        </thead>
+        <tbody>
+        <tr each="{ submission, index in submissions }"
+            class="submission-row"
+            onclick="{show_info_modal.bind(this, submission)}">
+            <!--  show file name if exists otherwise show name(for old submissions)  -->
+            <td>{ submission.file_name || submission.name }</td>
+            <!--  show compeition name as link if competition is available -->
+            <td if="{submission.competition}"><a class="link-no-deco" target="_blank" href="../competitions/{ submission.competition.id }">{ submission.competition.title }</a></td>
+            <!--  show empty td if competition is not available  -->
+            <td if="{!submission.competition}"></td>
+            <td>{ format_file_size(submission.file_size) }</td>
+            <td>{ timeSince(Date.parse(submission.created_when)) } ago</td>
+            <td class="center aligned">
+                <i class="checkmark box icon green" show="{ submission.is_public }"></i>
+            </td>
+            <td class="center aligned">
+                <button class="ui mini button red icon" onclick="{ delete_submission.bind(this, submission) }">
+                    <i class="icon delete"></i>
+                </button>
+            </td>
+            <td class="center aligned">
+                <div class="ui fitted checkbox">
+                    <input type="checkbox" name="delete_checkbox" onclick="{ mark_submission_for_deletion.bind(this, submission) }">
+                    <label></label>
+                </div>
+            </td>
+        </tr>
+
+        <tr if="{submissions.length === 0}">
+            <td class="center aligned" colspan="6">
+                <em>No Submissions Yet!</em>
+            </td>
+        </tr>
+        </tbody>
+        <tfoot>
+
+        <!-- Pagination -->
+        <tr>
+            <th colspan="8" if="{submissions.length > 0}">
+                <div class="ui right floated pagination menu" if="{submissions.length > 0}">
+                    <a show="{!!_.get(pagination, 'previous')}" class="icon item" onclick="{previous_page}">
+                        <i class="left chevron icon"></i>
+                    </a>
+                    <div class="item">
+                        <label>{page}</label>
+                    </div>
+                    <a show="{!!_.get(pagination, 'next')}" class="icon item" onclick="{next_page}">
+                        <i class="right chevron icon"></i>
+                    </a>
+                </div>
+            </th>
+        </tr>
+        </tfoot>
+    </table>
+
+    <div ref="info_modal" class="ui modal">
+        <div class="header">
+            {selected_row.file_name || selected_row.name}
+        </div>
+        <div class="content">
+            <h3>Details</h3>
+
+            <table class="ui basic table">
+                <thead>
+                <tr>
+                    <th>Key</th>
+                    <th>Competition in</th>
+                    <th>Created By</th>
+                    <th>Created</th>
+                    <th>Type</th>
+                    <th>Public</th>
+                </tr>
+                </thead>
+                <tbody>
+                <tr>
+                    <td>{selected_row.key}</td>
+                    <!--  show compeition name as link if competition is available -->
+                    <td if="{selected_row.competition}"><a class="link-no-deco" target="_blank" href="../competitions/{ selected_row.competition.id }">{ selected_row.competition.title }</a></td>
+                    <!--  show empty td if competition is not available  -->
+                    <td if="{!selected_row.competition}"></td>
+                    <td>{selected_row.created_by}</td>
+                    <td>{pretty_date(selected_row.created_when)}</td>
+                    <td>{_.startCase(selected_row.type)}</td>
+                    <td>{_.startCase(selected_row.is_public)}</td>
+                </tr>
+                </tbody>
+            </table>
+            <virtual if="{!!selected_row.description}">
+                <div>Description:</div>
+                <div class="ui segment">
+                    {selected_row.description}
+                </div>
+            </virtual>
+        </div>
+        <div class="actions">
+            <button show="{selected_row.created_by === CODALAB.state.user.username}"
+                class="ui primary icon button" onclick="{toggle_is_public}">
+                <i class="share icon"></i> {selected_row.is_public ? "Make Private" : "Make Public"}
+            </button>
+            <a href="{URLS.DATASET_DOWNLOAD(selected_row.key)}" class="ui green icon button">
+                <i class="download icon"></i>Download File
+            </a>
+            <button class="ui cancel button">Close</button>
+        </div>
+    </div>
+
+    <script>
+        var self = this
+        self.mixin(ProgressBarMixin)
+
+        /*---------------------------------------------------------------------
+         Init
+        ---------------------------------------------------------------------*/
+        self.errors = []
+        self.submissions = []
+        self.selected_row = {}
+        self.marked_submissions = []
+
+
+        self.page = 1
+
+        self.one("mount", function () {
+            $(".ui.dropdown", self.root).dropdown()
+            $(".ui.checkbox", self.root).checkbox()
+            self.update_submissions()
+        })
+
+        self.show_info_modal = function (row, e) {
+            // Return here so the info modal doesn't pop up when a checkbox is clicked
+            if (e.target.type === 'checkbox') {
+                return
+            }
+            self.selected_row = row
+            self.update()
+            $(self.refs.info_modal).modal('show')
+        }
+
+
+        /*---------------------------------------------------------------------
+         Methods
+        ---------------------------------------------------------------------*/
+        self.pretty_date = date => luxon.DateTime.fromISO(date).toLocaleString(luxon.DateTime.DATE_FULL)
+
+        self.filter = function (filters) {
+            let type = $(self.refs.type_filter).val()
+            filters = filters || {}
+            _.defaults(filters, {
+                type: type === '-' ? '' : type,
+                search: $(self.refs.search).val(),
+                page: 1,
+            })
+            self.page = filters.page
+            self.update_submissions(filters)
+        }
+
+        self.next_page = function () {
+            if (!!self.pagination.next) {
+                self.page += 1
+                self.filter({page: self.page})
+            } else {
+                alert("No valid page to go to!")
+            }
+        }
+        self.previous_page = function () {
+            if (!!self.pagination.previous) {
+                self.page -= 1
+                self.filter({page: self.page})
+            } else {
+                alert("No valid page to go to!")
+            }
+        }
+
+        self.update_submissions = function (filters) {
+            filters = filters || {}
+            filters.type = "submission"
+            CODALAB.api.get_datasets(filters)
+                .done(function (data) {
+                    self.submissions = data.results
+                    self.pagination = {
+                        "count": data.count,
+                        "next": data.next,
+                        "previous": data.previous
+                    }
+                    self.update()
+                })
+                .fail(function (response) {
+                    toastr.error("Could not load submissions...")
+                })
+        }
+
+        self.delete_submission = function (submission, e) {
+            name = submission.file_name || submission.name
+            if (confirm(`Are you sure you want to delete '${name}'?`)) {
+                CODALAB.api.delete_dataset(submission.id)
+                    .done(function () {
+                        self.update_submissions()
+                        toastr.success("Submission deleted successfully!")
+                    })
+                    .fail(function (response) {
+                        toastr.error(response.responseJSON['error'])
+                    })
+            }
+            event.stopPropagation()
+        }
+
+        self.delete_submissions = function () {
+            if (confirm(`Are you sure you want to delete multiple submissions?`)) {
+                CODALAB.api.delete_datasets(self.marked_submissions)
+                    .done(function () {
+                        self.update_submissions()
+                        toastr.success("Submission deleted successfully!")
+                        self.marked_submissions = []
+                    })
+                    .fail(function (response) {
+                        for (e in response.responseJSON) {
+                            toastr.error(`${e}: '${response.responseJSON[e]}'`)
+                        }
+                    })
+            }
+            event.stopPropagation()
+        }
+
+        self.clear_form = function () {
+            // Clear form
+            $(':input', self.refs.form)
+                .not(':button, :submit, :reset, :hidden')
+                .val('')
+                .removeAttr('checked')
+                .removeAttr('selected');
+
+            $('.dropdown', self.refs.form).dropdown('restore defaults')
+
+            self.errors = {}
+            self.update()
+        }
+
+        self.check_form = function (event) {
+            if (event) {
+                event.preventDefault()
+            }
+
+       
+
+            // Let's do some quick validation
+            self.errors = {}
+            var validate_data = get_form_data(self.refs.form)
+
+            var required_fields = ['name', 'type', 'data_file']
+            required_fields.forEach(field => {
+                if (validate_data[field] === '') {
+                    self.errors[field] = "This field is required"
+                }
+            })
+
+            if (Object.keys(self.errors).length > 0) {
+                // display errors and drop out
+                self.update()
+                return
+            }
+
+            
+        }
+
+        self.toggle_is_public = () => {
+            let message = self.selected_row.is_public
+                ? 'Are you sure you want to make this submission private? It will no longer be available to other users.'
+                : 'Are you sure you want to make this submission public? It will become visible to everyone'
+            if (confirm(message)) {
+                CODALAB.api.update_dataset(self.selected_row.id, {id: self.selected_row.id, is_public: !self.selected_row.is_public})
+                    .done(data => {
+                        toastr.success('Submission updated')
+                        $(self.refs.info_modal).modal('hide')
+                        self.filter()
+                    })
+                    .fail(resp => {
+                        toastr.error(resp.responseJSON['is_public'])
+                    })
+            }
+        }
+
+        self.mark_submission_for_deletion = function(submission, e) {
+            if (e.target.checked) {
+                self.marked_submissions.push(submission.id)
+            }
+            else {
+                self.marked_submissions.splice(self.marked_submissions.indexOf(submission.id), 1)
+            }
+        }
+
+        // Function to format file size 
+        self.format_file_size = function(file_size) {
+            // parse file size from string to float
+            try {
+                n = parseFloat(file_size)
+            }
+            catch(err) {
+                // return empty string if parsing fails
+                return ""
+            }
+            // constant units to show with files size
+            // file size is in KB, converting it to MB and GB 
+            const units = ['KB', 'MB', 'GB']
+            // loop incrementer for selecting desired unit
+            let i = 0
+            // loop over n until it is greater than 1000
+            while(n >= 1000 && ++i){
+                n = n/1000;
+            }
+            // restrict file size to 1 decimal number concatinated with unit
+            return(n.toFixed(1) + ' ' + units[i]);
+        }
+
+    </script>
+
+    <style type="text/stylus">
+        .submission-row:hover
+            cursor pointer
+    </style>
+</submission-management>

From 57fd67560ea6dbaadb931150e46bc7a8f7a68e80 Mon Sep 17 00:00:00 2001
From: Ihsan Ullah <ihsanullah@Pixel-io.local>
Date: Sun, 28 May 2023 15:14:36 +0500
Subject: [PATCH 2/5] Add Dataset changed to Add Dataset/Program

---
 src/static/riot/datasets/management.tag | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/static/riot/datasets/management.tag b/src/static/riot/datasets/management.tag
index b25bf6032..7daac8cf6 100644
--- a/src/static/riot/datasets/management.tag
+++ b/src/static/riot/datasets/management.tag
@@ -16,7 +16,7 @@
     </div>
     <button class="ui green right floated labeled icon button" onclick="{show_creation_modal}">
         <i selenium="add-dataset" class="plus icon"></i>
-        Add Dataset
+        Add Dataset/Program
     </button>
     <button class="ui red right floated labeled icon button {disabled: marked_datasets.length === 0}" onclick="{delete_datasets}">
         <i class="icon delete"></i>

From 4d48e498e6637e8fd1c2413b0e0432597ed1b8bb Mon Sep 17 00:00:00 2001
From: Ihsan Ullah <ihsanullah@Pixel-io.local>
Date: Sun, 28 May 2023 15:37:30 +0500
Subject: [PATCH 3/5] Add submission modal added

---
 src/static/riot/datasets/management.tag       |   6 +-
 .../riot/submissions/resource_submissions.tag | 109 +++++++++++++++++-
 2 files changed, 109 insertions(+), 6 deletions(-)

diff --git a/src/static/riot/datasets/management.tag b/src/static/riot/datasets/management.tag
index 7daac8cf6..60ea5095d 100644
--- a/src/static/riot/datasets/management.tag
+++ b/src/static/riot/datasets/management.tag
@@ -91,6 +91,7 @@
         </tfoot>
     </table>
 
+    <!--  Dataset Detail Model  -->
     <div ref="info_modal" class="ui modal">
         <div class="header">
             {selected_row.name}
@@ -144,9 +145,9 @@
         </div>
     </div>
 
-
+    <!--  Add Dataset Model  -->
     <div ref="dataset_creation_modal" class="ui modal">
-        <div class="header">Form</div>
+        <div class="header">Add Dataset/Program Form</div>
 
         <div class="content">
             <div class="ui message error" show="{ Object.keys(errors).length > 0 }">
@@ -192,6 +193,7 @@
             <button class="ui basic red cancel button">Cancel</button>
         </div>
     </div>
+
     <script>
         var self = this
         self.mixin(ProgressBarMixin)
diff --git a/src/static/riot/submissions/resource_submissions.tag b/src/static/riot/submissions/resource_submissions.tag
index f1b082add..209567575 100644
--- a/src/static/riot/submissions/resource_submissions.tag
+++ b/src/static/riot/submissions/resource_submissions.tag
@@ -5,6 +5,10 @@
         <input type="text" placeholder="Search..." ref="search" onkeyup="{ filter.bind(this, undefined) }">
         <i class="search icon"></i>
     </div>
+    <button class="ui green right floated labeled icon button" onclick="{show_creation_modal}">
+        <i class="plus icon"></i>
+        Add Submission
+    </button>
     <button class="ui red right floated labeled icon button {disabled: marked_submissions.length === 0}" onclick="{delete_submissions}">
         <i class="icon delete"></i>
         Delete Selected Submissions
@@ -78,6 +82,7 @@
         </tfoot>
     </table>
 
+    <!--  Submission Detail Model  -->
     <div ref="info_modal" class="ui modal">
         <div class="header">
             {selected_row.file_name || selected_row.name}
@@ -129,6 +134,49 @@
         </div>
     </div>
 
+    <!--  Add Submission Model  -->
+    <div ref="submission_creation_modal" class="ui modal">
+        <div class="header">Add Submission Form</div>
+
+        <div class="content">
+            <div class="ui message error" show="{ Object.keys(errors).length > 0 }">
+                <div class="header">
+                    Error(s) creating submission
+                </div>
+                <ul class="list">
+                    <li each="{ error, field in errors }">
+                        <strong>{field}:</strong> {error}
+                    </li>
+                </ul>
+            </div>
+
+            <form class="ui form coda-animated {error: errors}" ref="form">
+                <input-text name="name" ref="name" error="{errors.name}" placeholder="Name"></input-text>
+                <input-text name="description" ref="description" error="{errors.description}"
+                            placeholder="Description"></input-text>
+
+                <input type=hidden name="type" ref="type" value="submission">
+                
+                <input-file name="data_file" ref="data_file" error="{errors.data_file}"
+                            accept=".zip"></input-file>
+            </form>
+
+            <div class="ui indicating progress" ref="progress">
+                <div class="bar">
+                    <div class="progress">{ upload_progress }%</div>
+                </div>
+            </div>
+
+        </div>
+        <div class="actions">
+            <button class="ui blue icon button" onclick="{check_form}">
+                <i class="upload icon"></i>
+                Upload
+            </button>
+            <button class="ui basic red cancel button">Cancel</button>
+        </div>
+    </div>
+
     <script>
         var self = this
         self.mixin(ProgressBarMixin)
@@ -141,6 +189,7 @@
         self.selected_row = {}
         self.marked_submissions = []
 
+        self.upload_progress = undefined
 
         self.page = 1
 
@@ -160,6 +209,10 @@
             $(self.refs.info_modal).modal('show')
         }
 
+        self.show_creation_modal = function () {
+            $(self.refs.submission_creation_modal).modal('show')
+        }
+
 
         /*---------------------------------------------------------------------
          Methods
@@ -253,8 +306,7 @@
                 .removeAttr('checked')
                 .removeAttr('selected');
 
-            $('.dropdown', self.refs.form).dropdown('restore defaults')
-
+            
             self.errors = {}
             self.update()
         }
@@ -264,7 +316,9 @@
                 event.preventDefault()
             }
 
-       
+            // Reset upload progress, in case we're trying to re-upload or had errors -- this is the
+            // best place to do it -- also resets animations
+            self.file_upload_progress_handler(undefined)
 
             // Let's do some quick validation
             self.errors = {}
@@ -283,7 +337,54 @@
                 return
             }
 
-            
+            // Call the progress bar wrapper and do the upload -- we want to check and display errors
+            // first before doing the actual upload
+            self.prepare_upload(self.upload)()
+
+        }
+
+        self.upload = function () {
+            // Have to get the "FormData" to get the file in a special way
+            // jquery likes to work with
+            var metadata = get_form_data(self.refs.form)
+            delete metadata.data_file  // dont send this with metadata
+
+            if (metadata.is_public === 'on') {
+                var public_confirm = confirm("Creating a public submission means this will be sent to Chahub and publicly available on the internet. Are you sure you wish to continue?")
+                if (!public_confirm) {
+                    return
+                }
+            }
+
+            var data_file = self.refs.data_file.refs.file_input.files[0]
+
+            CODALAB.api.create_dataset(metadata, data_file, self.file_upload_progress_handler)
+                .done(function (data) {
+                    toastr.success("Submission successfully uploaded!")
+                    self.update_submissions()
+                    self.clear_form()
+                    $(self.refs.submission_creation_modal).modal('hide')
+                })
+                .fail(function (response) {
+                    if (response) {
+                        try {
+                            var errors = JSON.parse(response.responseText)
+
+                            // Clean up errors to not be arrays but plain text
+                            Object.keys(errors).map(function (key, index) {
+                                errors[key] = errors[key].join('; ')
+                            })
+
+                            self.update({errors: errors})
+                        } catch (e) {
+
+                        }
+                    }
+                    toastr.error("Creation failed, error occurred")
+                })
+                .always(function () {
+                    self.hide_progress_bar()
+                })
         }
 
         self.toggle_is_public = () => {

From 3955566a18ff9dc915accbadf7af8ae37f32c6f6 Mon Sep 17 00:00:00 2001
From: Ihsan Ullah <ihsanullah@Pixel-io.local>
Date: Tue, 30 May 2023 17:06:23 +0500
Subject: [PATCH 4/5] benchmark title instead of id in datasets detail

---
 src/apps/datasets/models.py             | 2 +-
 src/static/riot/datasets/management.tag | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/apps/datasets/models.py b/src/apps/datasets/models.py
index ae96b76ef..3d97e8b45 100644
--- a/src/apps/datasets/models.py
+++ b/src/apps/datasets/models.py
@@ -88,7 +88,7 @@ def in_use(self):
             Q(phases__tasks__input_data=self) |
             Q(phases__tasks__reference_data=self) |
             Q(phases__tasks__scoring_program=self)
-        ).values_list('pk', flat=True).distinct()
+        ).values('pk', 'title').distinct()
         return competitions_in_use
 
     def __str__(self):
diff --git a/src/static/riot/datasets/management.tag b/src/static/riot/datasets/management.tag
index 60ea5095d..73fd11f4b 100644
--- a/src/static/riot/datasets/management.tag
+++ b/src/static/riot/datasets/management.tag
@@ -127,8 +127,8 @@
             </virtual>
             <div show="{!!_.get(selected_row.in_use, 'length')}"><strong>Used by:</strong>
                 <div class="ui bulleted list">
-                    <div class="item" each="{id in selected_row.in_use}">
-                        <a href="{URLS.COMPETITION_DETAIL(id)}" target="_blank">Benchmark id: {id}</a>
+                    <div class="item" each="{comp in selected_row.in_use}">
+                        <a href="{URLS.COMPETITION_DETAIL(comp.pk)}" target="_blank">{comp.title}</a>
                     </div>
                 </div>
             </div>
@@ -231,6 +231,7 @@
                 return
             }
             self.selected_row = row
+            console.log(row)
             self.update()
             $(self.refs.info_modal).modal('show')
         }

From ac7801a4f118e38794a3f9d7d5ed806297193bdc Mon Sep 17 00:00:00 2001
From: Ihsan Ullah <ihsanullah@Pixel-io.local>
Date: Tue, 30 May 2023 17:49:49 +0500
Subject: [PATCH 5/5] Tasks tab: benchmark is now clickable link

---
 src/apps/api/serializers/tasks.py       |  8 +++++++-
 src/static/riot/datasets/management.tag |  1 -
 src/static/riot/tasks/management.tag    | 10 +++++++++-
 3 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/src/apps/api/serializers/tasks.py b/src/apps/api/serializers/tasks.py
index 521c8f64c..deac682cc 100644
--- a/src/apps/api/serializers/tasks.py
+++ b/src/apps/api/serializers/tasks.py
@@ -7,6 +7,7 @@
 from competitions.models import PhaseTaskInstance, Phase
 from datasets.models import Data
 from tasks.models import Task, Solution
+from competitions.models import Competition
 
 
 class SolutionSerializer(WritableNestedModelSerializer):
@@ -138,7 +139,12 @@ class Meta:
         )
 
     def get_competitions(self, instance):
-        return self.context['task_titles'][instance.pk]
+
+        # Fech competitions which hase phases with this task
+        # competitions = Phase.objects.filter(tasks__in=[instance.pk]).values('competition')
+        competitions = Competition.objects.filter(phases__tasks__in=[instance.pk]).values("id", "title").distinct()
+
+        return competitions
 
     def get_shared_with(self, instance):
         return self.context['shared_with'][instance.pk]
diff --git a/src/static/riot/datasets/management.tag b/src/static/riot/datasets/management.tag
index 73fd11f4b..ad33b4901 100644
--- a/src/static/riot/datasets/management.tag
+++ b/src/static/riot/datasets/management.tag
@@ -231,7 +231,6 @@
                 return
             }
             self.selected_row = row
-            console.log(row)
             self.update()
             $(self.refs.info_modal).modal('show')
         }
diff --git a/src/static/riot/tasks/management.tag b/src/static/riot/tasks/management.tag
index bc62ca492..b262d5fd7 100644
--- a/src/static/riot/tasks/management.tag
+++ b/src/static/riot/tasks/management.tag
@@ -30,7 +30,15 @@
         <tbody>
         <tr each="{ task in tasks }" onclick="{show_detail_modal.bind(this, task)}" class="task-row">
             <td>{ task.name }</td>
-            <td class="benchmark-row">{ task.competitions.join(', ') }</td>
+            <td class="benchmark-row">
+                <div show="{task.competitions.length > 0}" class="ui list">
+                    <div class="item" each="{comp in task.competitions}">
+                        <a href="{URLS.COMPETITION_DETAIL(comp.id)}" target="_blank">{comp.title}</a>
+                    </div>
+                </div>
+            
+            
+            </td>
             <td>{ task.shared_with.join(', ') }</td>
             <td>{ timeSince(Date.parse(task.created_when)) } ago</td>
             <td class="center aligned">