Add analytics tracking for added/removed TaskSkill

Author: joshsmith

lib/code_corps/analytics/segment_traits_builder.ex

@@ -64,6 +64,15 @@ defmodule CodeCorps.Analytics.SegmentTraitsBuilder do
     }
   end
 
+  defp traits(task_skill = %CodeCorps.TaskSkill{}) do
+    task_skill = task_skill |> CodeCorps.Repo.preload([:skill, :task])
+    %{
+      skill: task_skill.skill.title,
+      skill_id: task_skill.skill.id,
+      task: task_skill.task.title
+    }
+  end
+
   defp traits(user_category = %CodeCorps.UserCategory{}) do
     user_category = user_category |> CodeCorps.Repo.preload(:category)
     %{

lib/code_corps_web/controllers/task_skill_controller.ex

@@ -2,7 +2,12 @@ defmodule CodeCorpsWeb.TaskSkillController do
   @moduledoc false
   use CodeCorpsWeb, :controller
 
-  alias CodeCorps.{TaskSkill, User, Helpers.Query}
+  alias CodeCorps.{
+    Analytics.SegmentTracker,
+    Helpers.Query,
+    TaskSkill,
+    User
+  }
 
   action_fallback CodeCorpsWeb.FallbackController
   plug CodeCorpsWeb.Plug.DataToAttributes
@@ -26,7 +31,9 @@ defmodule CodeCorpsWeb.TaskSkillController do
   def create(%Conn{} = conn, %{} = params) do
     with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
          {:ok, :authorized} <- current_user |> Policy.authorize(:create, %TaskSkill{}, params),
-         {:ok, %TaskSkill{} = task_skill} <- %TaskSkill{} |> TaskSkill.create_changeset(params) |> Repo.insert do
+         {:ok, %TaskSkill{} = task_skill} <- %TaskSkill{} |> TaskSkill.create_changeset(params) |> Repo.insert
+    do
+      SegmentTracker.track(current_user.id, "Added Task Skill", task_skill)
       conn |> put_status(:created) |> render("show.json-api", data: task_skill)
     end
   end
@@ -38,6 +45,7 @@ defmodule CodeCorpsWeb.TaskSkillController do
       {:ok, :authorized} <- current_user |> Policy.authorize(:delete, task_skill),
       {:ok, %TaskSkill{} = _task_skill} <- task_skill |> Repo.delete
     do
+      SegmentTracker.track(current_user.id, "Removed Task Skill", task_skill)
       conn |> Conn.assign(:task_skill, task_skill) |> send_resp(:no_content, "")
     end
   end

lib/code_corps_web/controllers/user_controller.ex

@@ -1,76 +1,5 @@
 defmodule CodeCorpsWeb.UserController do
   @moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
-@moduledoc false
   use CodeCorpsWeb, :controller
 
   alias CodeCorps.{

test/lib/code_corps_web/controllers/task_skill_controller_test.exs

@@ -3,6 +3,8 @@ defmodule CodeCorpsWeb.TaskSkillControllerTest do
 
   use CodeCorpsWeb.ApiCase, resource_name: :task_skill
 
+  alias CodeCorps.{Repo, TaskSkill}
+
   describe "index" do
     test "lists all entries on index", %{conn: conn} do
       [task_skill_1, task_skill_2] = insert_pair(:task_skill)
@@ -52,6 +54,24 @@ defmodule CodeCorpsWeb.TaskSkillControllerTest do
       assert conn |> request_create(attrs) |> json_response(201)
     end
 
+    @tag :authenticated
+    test "tracks event when data is valid", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user)
+      skill = insert(:skill)
+      user_id = current_user.id
+
+      attrs = %{task: task, skill: skill}
+      json = conn |> request_create(attrs) |> json_response(201)
+      assert json
+
+      expected_data =
+        TaskSkill
+        |> Repo.get(json["data"]["id"])
+        |> CodeCorps.Analytics.SegmentTraitsBuilder.build
+
+      assert_received {:track, ^user_id, "Added Task Skill", ^expected_data}
+    end
+
     @tag :authenticated
     test "renders 422 error when data is invalid", %{conn: conn, current_user: current_user} do
       task = insert(:task, user: current_user)
@@ -83,6 +103,21 @@ defmodule CodeCorpsWeb.TaskSkillControllerTest do
       assert conn |> request_delete(task_skill) |> response(204)
     end
 
+    @tag :authenticated
+    test "tracks event", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user)
+      task_skill = insert(:task_skill, task: task)
+      user_id = current_user.id
+      expected_data =
+        TaskSkill
+        |> Repo.get(task_skill.id)
+        |> CodeCorps.Analytics.SegmentTraitsBuilder.build
+
+      assert conn |> request_delete(task_skill) |> response(204)
+
+      assert_received {:track, ^user_id, "Removed Task Skill", ^expected_data}
+    end
+
     test "renders 401 when unauthenticated", %{conn: conn} do
       assert conn |> request_delete |> json_response(401)
     end

test/lib/code_corps_web/controllers/user_controller_test.exs

@@ -27,7 +27,6 @@ defmodule CodeCorpsWeb.UserControllerTest do
   @relationships %{}
 
   describe "index" do
-
     test "lists all entries on index", %{conn: conn} do
       [user_1, user_2] = insert_pair(:user)