From 2ddbfb214cc4a3e04efdc35e301ad04312c855cc Mon Sep 17 00:00:00 2001 From: tim Date: Tue, 9 Sep 2025 15:05:32 +0300 Subject: [PATCH 1/2] aws_profile_for_asg_management --- roles/asg_management/defaults/main.yml | 2 +- roles/deploy_code/tasks/cleanup.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roles/asg_management/defaults/main.yml b/roles/asg_management/defaults/main.yml index 0c5dbd46..2b3b3f59 100644 --- a/roles/asg_management/defaults/main.yml +++ b/roles/asg_management/defaults/main.yml @@ -4,7 +4,7 @@ asg_management: name: "" # if the deploy is on an ASG put the name here #target_group_name: "example" # matches the ASG name by default, specify if your TargetGroup name is different (for example due to the 32-char name length limit in AWS) refresh_asg_instances: true # runs only if squashFS image unmount failed and this set to true. - #profile: "example" # optional, the boto profile name to use if not the system default + profile: "{{ lookup('env','AWS_PROFILE') | default(omit) }}" # the boto profile name to use if not the system default region: "eu-west-1" suspend_processes: "Launch Terminate HealthCheck" # space separated string, see https://docs.aws.amazon.com/autoscaling/ec2/userguide/as-suspend-resume-processes.html pause: 10 # localhost ping count, to wait before polling the AWS API again for instance statuses (instead of ansible 'pause' module which seems to be buggy and hangs sometimes) diff --git a/roles/deploy_code/tasks/cleanup.yml b/roles/deploy_code/tasks/cleanup.yml index df3d1e31..c4e918c0 100644 --- a/roles/deploy_code/tasks/cleanup.yml +++ b/roles/deploy_code/tasks/cleanup.yml @@ -255,7 +255,7 @@ amazon.aws.autoscaling_group: name: "{{ asg_management.name }}" region: "{{ asg_management.region }}" - profile: "{{ asg_management.profile | default(aws_profile | default(omit)) }}" + profile: "{{ asg_management.profile | default(omit) }}" suspend_processes: [] delegate_to: localhost run_once: true @@ -267,7 +267,7 @@ amazon.aws.autoscaling_instance_refresh: name: "{{ asg_management.name }}" region: "{{ asg_management.region }}" - profile: "{{ asg_management.profile | default(aws_profile | default(omit)) }}" + profile: "{{ asg_management.profile | default(omit) }}" strategy: Rolling preferences: min_healthy_percentage: 51 From 370138d146fefa4819d75a8b602141d35dfbfb2a Mon Sep 17 00:00:00 2001 From: tim Date: Tue, 9 Sep 2025 16:14:21 +0300 Subject: [PATCH 2/2] aws_profile_for_asg_management_case_with_default_profile_absent --- roles/asg_management/defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/asg_management/defaults/main.yml b/roles/asg_management/defaults/main.yml index 2b3b3f59..09857191 100644 --- a/roles/asg_management/defaults/main.yml +++ b/roles/asg_management/defaults/main.yml @@ -4,7 +4,7 @@ asg_management: name: "" # if the deploy is on an ASG put the name here #target_group_name: "example" # matches the ASG name by default, specify if your TargetGroup name is different (for example due to the 32-char name length limit in AWS) refresh_asg_instances: true # runs only if squashFS image unmount failed and this set to true. - profile: "{{ lookup('env','AWS_PROFILE') | default(omit) }}" # the boto profile name to use if not the system default + profile: "{{ lookup('env','AWS_PROFILE') | trim | default(omit) }}" # the boto profile name to use if not the system default (if doesn't exist, then EC2 instance IAM profile will be used) region: "eu-west-1" suspend_processes: "Launch Terminate HealthCheck" # space separated string, see https://docs.aws.amazon.com/autoscaling/ec2/userguide/as-suspend-resume-processes.html pause: 10 # localhost ping count, to wait before polling the AWS API again for instance statuses (instead of ansible 'pause' module which seems to be buggy and hangs sometimes)