fixup! move isAddressInfo, add .address check

Author: jsjoeio

src/node/util.ts

@@ -485,15 +485,6 @@ export function isNodeJSErrnoException(error: unknown): error is NodeJS.ErrnoExc
   return error !== undefined && (error as NodeJS.ErrnoException).code !== undefined
 }
 
-/**
- * A helper function which returns a boolean indicating whether
- * the given address is AddressInfo and has .address
- * and a .port property.
- */
-export function isAddressInfo(address: unknown): address is net.AddressInfo {
-  return address !== null && typeof address !== "string" && (address as net.AddressInfo).port !== undefined
-}
-
 // TODO: Replace with proper templating system.
 export const escapeJSON = (value: cp.Serializable) => JSON.stringify(value).replace(/"/g, """)
 

test/unit/node/update.test.ts

@@ -4,8 +4,7 @@ import { AddressInfo } from "net"
 import * as path from "path"
 import { SettingsProvider, UpdateSettings } from "../../../src/node/settings"
 import { LatestResponse, UpdateProvider } from "../../../src/node/update"
-import { isAddressInfo } from "../../../src/node/util"
-import { clean, mockLogger, tmpdir } from "../../utils/helpers"
+import { clean, isAddressInfo, mockLogger, tmpdir } from "../../utils/helpers"
 
 describe("update", () => {
   let version = "1.0.0"

test/utils/helpers.ts

@@ -105,3 +105,17 @@ export function idleTimer(message: string, reject: (error: Error) => void, delay
     },
   }
 }
+
+/**
+ * A helper function which returns a boolean indicating whether
+ * the given address is AddressInfo and has .address
+ * and a .port property.
+ */
+export function isAddressInfo(address: unknown): address is net.AddressInfo {
+  return (
+    address !== null &&
+    typeof address !== "string" &&
+    (address as net.AddressInfo).port !== undefined &&
+    (address as net.AddressInfo).address !== undefined
+  )
+}