Review changes

Author: cmoog

ci/dev-image/exec.sh

@@ -17,34 +17,30 @@ run() {
   echo "--- Spawning $container_name"
   container_id=$(docker run \
     -it \
-    --privileged \
     --name $container_name \
     "-v=$PWD:/code-server" \
     "-w=/code-server" \
-    "-p=8080:8080" \
+    "-p=127.0.0.1:8080:8080" \
     $([[ -t 0 ]] && echo -it || true) \
-    -d \
     $container_name)
 }
 
 build() {
   echo "--- Building $container_name"
-  cd ../../ && docker build -t $container_name -f ./ci/dev-image/Dockerfile . > /dev/null
+  cd ../../ && \
+    docker build -t $container_name -f ./ci/dev-image/Dockerfile . > /dev/null
 }
 
-set +e
-container_id=$(docker container inspect --format="{{.Id}}" $container_name 2> /dev/null)
+container_id=$(docker container inspect --format="{{.Id}}" $container_name 2> /dev/null) || true
 
-if [ $? -eq "0" ]; then
-  set -e
+if [ "$container_id" != "" ]; then
   echo "-- Starting container"
   docker start $container_id > /dev/null
 
   enter
   exit 0
 fi
 
-set -e
 build
 run
 enter

doc/CONTRIBUTING.md

@@ -17,7 +17,7 @@ To develop inside of an isolated docker container:
 
 root@12345:/code-server# yarn
 root@12345:/code-server# yarn vscode
-root@12345:/code-server# yarn watch --host=0.0.0.0
+root@12345:/code-server# yarn watch
 ```
 
 Any changes made to the source will be live reloaded.