Move ClientConfiguration to common

Common code must not import Node code as it is imported by the browser.

Author: code-asher

src/common/http.ts

@@ -18,3 +18,12 @@ export class HttpError extends Error {
     this.name = this.constructor.name
   }
 }
+
+/**
+ * Base options included on every page.
+ */
+export interface ClientConfiguration {
+  codeServerVersion: string
+  base: string
+  csStaticBase: string
+}

src/common/util.ts

@@ -1,4 +1,4 @@
-import { ClientConfiguration } from "../node/http"
+import { ClientConfiguration } from "./http"
 
 /**
  * Split a string up to the delimiter. If the delimiter doesn't exist the first

src/node/http.ts

@@ -3,22 +3,13 @@ import * as express from "express"
 import * as expressCore from "express-serve-static-core"
 import path from "path"
 import qs from "qs"
-import { HttpCode, HttpError } from "../common/http"
+import { ClientConfiguration, HttpCode, HttpError } from "../common/http"
 import { normalize } from "../common/util"
 import { AuthType, DefaultedArgs } from "./cli"
 import { version as codeServerVersion } from "./constants"
 import { Heart } from "./heart"
 import { getPasswordMethod, IsCookieValidArgs, isCookieValid, sanitizeString, escapeHtml, escapeJSON } from "./util"
 
-/**
- * Base options included on every page.
- */
-export interface ClientConfiguration {
-  codeServerVersion: string
-  base: string
-  csStaticBase: string
-}
-
 declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
   namespace Express {