helpers

Author: mafredri

go.mod

@@ -25,6 +25,7 @@ require (
 	github.com/gliderlabs/ssh v0.3.7
 	github.com/go-git/go-billy/v5 v5.5.0
 	github.com/go-git/go-git/v5 v5.12.0
+	github.com/google/go-cmp v0.6.0
 	github.com/google/go-containerregistry v0.20.1
 	github.com/google/uuid v1.6.0
 	github.com/hashicorp/go-multierror v1.1.1
@@ -149,7 +150,6 @@ require (
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/google/btree v1.1.2 // indirect
-	github.com/google/go-cmp v0.6.0 // indirect
 	github.com/google/nftables v0.2.0 // indirect
 	github.com/google/pprof v0.0.0-20230817174616-7a8ec2ada47b // indirect
 	github.com/gorilla/handlers v1.5.1 // indirect

log/coder_internal_test.go

@@ -309,6 +309,7 @@ func TestCoderRPCTimeout500MS(t *testing.T) {
 }
 
 func decodeV1Logs(t *testing.T, w http.ResponseWriter, r *http.Request) (agentsdk.PatchLogs, bool) {
+	t.Helper()
 	var req agentsdk.PatchLogs
 	err := json.NewDecoder(r.Body).Decode(&req)
 	if !assert.NoError(t, err) {
@@ -319,6 +320,7 @@ func decodeV1Logs(t *testing.T, w http.ResponseWriter, r *http.Request) (agentsd
 }
 
 func newCoderLogger(ctx context.Context, t *testing.T, us string, token string) (Func, func()) {
+	t.Helper()
 	u, err := url.Parse(us)
 	require.NoError(t, err)
 	logger, closer, err := Coder(ctx, u, token)
@@ -339,6 +341,7 @@ func (d *fakeLogDest) BatchCreateLogs(ctx context.Context, request *proto.BatchC
 }
 
 func testReplaceTimeout(t *testing.T, v *time.Duration, d time.Duration) {
+	t.Helper()
 	if isParallel(t) {
 		t.Fatal("cannot replace timeout in parallel test")
 	}
@@ -348,6 +351,7 @@ func testReplaceTimeout(t *testing.T, v *time.Duration, d time.Duration) {
 }
 
 func isParallel(t *testing.T) (ret bool) {
+	t.Helper()
 	// This is a hack to determine if the test is running in parallel
 	// via property of t.Setenv.
 	defer func() {