Skip to content

Build baru for wasm32-unknown-unknown#33

Closed
luckysori wants to merge 2 commits into
comit-network:masterfrom
luckysori:master
Closed

Build baru for wasm32-unknown-unknown#33
luckysori wants to merge 2 commits into
comit-network:masterfrom
luckysori:master

Conversation

@luckysori
Copy link
Copy Markdown
Collaborator

Fixes #26.

Copy link
Copy Markdown
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are only running on ubuntu at the moment (line 58). That is because we cannot run testcontainer based tests on MacOS.

Hence, this entire script might be cleaner if you change the build_test_workspace to be just build but extend the matrix to build on wasm as well.

Then you can add one more job that just runs on ubuntu and runs the tests. That should get the number of conditionals in your job definition down.

@luckysori
Copy link
Copy Markdown
Collaborator Author

Tests are only running on ubuntu at the moment (line 58). That is because we cannot run testcontainer based tests on MacOS.

Maybe we can run tests on MacOS after/if we merge #34. Let's put this on hold since it didn't make it to the 0.2.0 release anyway.

@luckysori luckysori marked this pull request as draft July 30, 2021 13:43
@luckysori
Copy link
Copy Markdown
Collaborator Author

Closing so that I don't run CI both on my fork and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure it works in WASM on all platforms

3 participants