Skip to content

[Breaking] FEC-185 - Move to a single standalone package#801

Merged
emmenko merged 8 commits into
mainfrom
nm-bundle-single-pkg
May 12, 2025
Merged

[Breaking] FEC-185 - Move to a single standalone package#801
emmenko merged 8 commits into
mainfrom
nm-bundle-single-pkg

Conversation

@emmenko
Copy link
Copy Markdown
Member

@emmenko emmenko commented May 7, 2025

Migrates all individual packages @commercetools-test-data/* to a single standalone package @commercetools/composable-commerce-test-data.

All models are now part of ./standalone/src.

The new package then exposes entrypoints, one for each model.

With this new structure, when checking out the code it might be that old artifacts folders are still present in your machine. Make sure to delete them!

  • Remove the <root>/core folder
  • Remove the <root>/models folder
  • Remove the <root>/graphql-types folder
  • Remove the <root>/presets folder
  • Remove the <root>/utils folder

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2025

🦋 Changeset detected

Latest commit: ce54ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/composable-commerce-test-data Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmenko emmenko force-pushed the nm-bundle-single-pkg branch from 96dcb3a to b58d51e Compare May 8, 2025 06:35
Comment thread codegen.core.yml
Comment thread generators/src/new-test-model/new-test-model.generator.ts Outdated
Comment thread generators/src/new-test-model/new-test-model.generator.ts
Comment thread generators/src/new-test-model/new-test-model.generator.ts
Comment thread generators/src/new-test-model/new-test-model.generator.ts
Comment thread generators/src/new-test-model/new-test-model.generator.ts Outdated
Comment thread models/channel/src/channel-draft/builder.spec.ts Outdated
Comment thread package/package.json Outdated
Comment thread package/package.json Outdated
Comment thread package/package.json
Comment thread scripts/copy-sources.mjs Outdated
@CarlosCortizasCT CarlosCortizasCT added the fe-chapter-rotation Tasks coming from frontend chapter work label May 8, 2025
@emmenko emmenko mentioned this pull request May 8, 2025
@emmenko emmenko force-pushed the nm-bundle-single-pkg branch from 3385871 to 31ea63f Compare May 8, 2025 19:03
@emmenko emmenko changed the title FEC-236 - Bundle single package correctly FEC-185 - Move to a single standalone package May 8, 2025
@emmenko emmenko changed the title FEC-185 - Move to a single standalone package [Breaking] FEC-185 - Move to a single standalone package May 8, 2025
@CarlosCortizasCT
Copy link
Copy Markdown
Contributor

I think after checking out this change developers will need to remove some folders from their repository, mainly the built bundles from the previous directories.

Can we at least leave some instructions in the description of this PR so developers know what they need to after after they check out the new version of the repo?

Copy link
Copy Markdown
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a changeset? 🙏

Comment thread .eslintrc.js
@emmenko emmenko marked this pull request as ready for review May 9, 2025 10:48
@emmenko emmenko requested review from a team as code owners May 9, 2025 10:48
@emmenko emmenko requested review from a team and removed request for a team May 9, 2025 10:50
@CarlosCortizasCT
Copy link
Copy Markdown
Contributor

I think after checking out this change developers will need to remove some folders from their repository, mainly the built bundles from the previous directories.

Can we at least leave some instructions in the description of this PR so developers know what they need to after after they check out the new version of the repo?

@emmenko can you please take a look at this?

Copy link
Copy Markdown
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work 🙇

Copy link
Copy Markdown
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My light bulks flickered when opening some diffs. Otherwise looks good.

@emmenko emmenko merged commit 9d32daa into main May 12, 2025
8 checks passed
@emmenko emmenko deleted the nm-bundle-single-pkg branch May 12, 2025 07:50
@ct-changesets ct-changesets Bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fe-chapter-rotation Tasks coming from frontend chapter work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants