FEC-237: to migrate product selection to new model and add product of selection submodel#809
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5fc0861 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CarlosCortizasCT
added
the
fe-chapter-rotation
Rombelirk
force-pushed
the
FEC-237-migrate-product-selection-model
branch
from
751042c to
524a8d6
Compare
Rombelirk
commented
May 13, 2025
Rombelirk
commented
May 13, 2025
Rombelirk
commented
May 13, 2025
Rombelirk
commented
May 13, 2025
Rombelirk
force-pushed
the
FEC-237-migrate-product-selection-model
branch
from
691dfdb to
800d2b0
Compare
Rombelirk
force-pushed
the
FEC-237-migrate-product-selection-model
branch
from
c0e075e to
1673925
Compare
Rombelirk
force-pushed
the
FEC-237-migrate-product-selection-model
branch
from
d458aae to
b66650e
Compare
Rombelirk
commented
May 15, 2025
Rombelirk
commented
May 15, 2025
Rombelirk
changed the title
rajrdk
reviewed
May 16, 2025
|
|
||
| describe('ProductSelection model compatibility builders', () => { | ||
| it('builds a default (REST) model', () => { | ||
| const restModel = ProductSelection.random().build(); |
Contributor
There was a problem hiding this comment.
Not in this case.
In the tests we first validates the REST and GraphQL models but then we need to also validate the compatibility one, which is what's done here.
rajrdk
reviewed
May 16, 2025
leventekobor
approved these changes
May 16, 2025
Co-authored-by: Carlos Cortizas <97907068+CarlosCortizasCT@users.noreply.github.com>
CarlosCortizasCT
approved these changes
May 16, 2025
Contributor
CarlosCortizasCT
left a comment
CarlosCortizasCT
left a comment
There was a problem hiding this comment.
Thanks for working on this, Roman 🙇
rajrdk
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates Product Selection to the new model,
also it adds Product Of Selection submodel to it.