refactor(cart): group cart-discount into cart

[emmenko]

https://commercetools.atlassian.net/browse/FEC-187

Group cart related models into ./cart:

/cart
  /cart
  /cart-discounts

[changeset-bot]

🦋 Changeset detected

Latest commit: e2d8194

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@commercetools/composable-commerce-test-data	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[emmenko]

@CarlosCortizasCT Are there any other models that need to be moved into ./cart?

[CarlosCortizasCT]

@CarlosCortizasCT Are there any other models that need to be moved into ./cart?

You can find the whole new structure in the RFC.

I don't think we planned for any other model to go to this folder.

[emmenko]

Yes I'm following the RFC. The ./cart folder already contains lots of other models (which weren't listed in the RFC). That's why I'm asking 😊

[CarlosCortizasCT]

Yes I'm following the RFC. The ./cart folder already contains lots of other models (which weren't listed in the RFC). That's why I'm asking 😊

If you take a look at the RFC you can see how the current cart folder was supposed to be a subfolder of the new parent cart folder which would also contain the cart-discount folder.

Let's agree on what to do here and the remaining work in our daily tomorrow.

[CarlosCortizasCT]

@emmenko would you be able to take a look at the typescript validation errors?

[emmenko]

I looked into it but I don't know what the issue is to be honest. It only happens with the production build.

I'll continue to investigate later.

[CarlosCortizasCT]

Thanks a lot 👍

[rajrdk]

@CarlosCortizasCT, should we replace paths with alias? I noticed they're used in many files.

[CarlosCortizasCT]

@CarlosCortizasCT, should we replace paths with alias? I noticed they're used in many files.

That would be great but it's not strictly necessary.
Most of them are in sample data presets which will be moved out of this repository anyway (reference) so I wouldn't spend the time now.