From 67d90ecc9828af24b745f1ff000e0a04970e903f Mon Sep 17 00:00:00 2001 From: jneira Date: Tue, 20 Aug 2019 23:25:27 +0200 Subject: [PATCH 1/4] Change log level to show it running scripts --- src/Stack/Config.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Stack/Config.hs b/src/Stack/Config.hs index ecf669cf51..9f9462cb16 100644 --- a/src/Stack/Config.hs +++ b/src/Stack/Config.hs @@ -281,7 +281,7 @@ configFromConfigMonoid shortLocalProgramsFilePath <- liftIO $ getShortPathName localProgramsFilePath when (' ' `elem` shortLocalProgramsFilePath) $ do - logWarn $ "Stack's 'programs' path contains a space character and " <> + logError $ "Stack's 'programs' path contains a space character and " <> "has no alternative short ('8 dot 3') name. This will cause " <> "problems with packages that use the GNU project's 'configure' " <> "shell script. Use the 'local-programs-path' configuation option " <> From d99c477bec544692fd76ed5fe108e4508a592f4c Mon Sep 17 00:00:00 2001 From: jneira Date: Tue, 20 Aug 2019 23:47:27 +0200 Subject: [PATCH 2/4] Update Changelog --- ChangeLog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ChangeLog.md b/ChangeLog.md index 6e9fe15352..1f478e06f9 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -13,6 +13,10 @@ Behavior changes: Other enhancements: +* Show warning about `local-programs-path` with spaces on windows + when running scripts. See + [#5013](https://github.com/commercialhaskell/stack/pull/5013) + * Add `ls dependencies json` which will print dependencies as JSON. `ls dependencies --tree` is now `ls dependencies tree`. See [#4424](https://github.com/commercialhaskell/stack/pull/4424) From 0934be978bdb4009e23a29889542e3f798092fcc Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Wed, 21 Aug 2019 22:18:14 +0200 Subject: [PATCH 3/4] Fix typo as suggested by @dbaynard Co-Authored-By: David Baynard --- src/Stack/Config.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Stack/Config.hs b/src/Stack/Config.hs index 9f9462cb16..1e165c88d4 100644 --- a/src/Stack/Config.hs +++ b/src/Stack/Config.hs @@ -284,7 +284,7 @@ configFromConfigMonoid logError $ "Stack's 'programs' path contains a space character and " <> "has no alternative short ('8 dot 3') name. This will cause " <> "problems with packages that use the GNU project's 'configure' " <> - "shell script. Use the 'local-programs-path' configuation option " <> + "shell script. Use the 'local-programs-path' configuration option " <> "to specify an alternative path. The current 'shortest' path is: " <> display (T.pack shortLocalProgramsFilePath) platformOnlyDir <- runReaderT platformOnlyRelDir (configPlatform, configPlatformVariant) From 0937c8e5f6bea6af7fecf048032f5cd9bd708f16 Mon Sep 17 00:00:00 2001 From: jneira Date: Thu, 22 Aug 2019 01:19:48 +0200 Subject: [PATCH 4/4] Show original local-programs-path --- src/Stack/Config.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Stack/Config.hs b/src/Stack/Config.hs index 1e165c88d4..cb241f11f2 100644 --- a/src/Stack/Config.hs +++ b/src/Stack/Config.hs @@ -285,8 +285,8 @@ configFromConfigMonoid "has no alternative short ('8 dot 3') name. This will cause " <> "problems with packages that use the GNU project's 'configure' " <> "shell script. Use the 'local-programs-path' configuration option " <> - "to specify an alternative path. The current 'shortest' path is: " <> - display (T.pack shortLocalProgramsFilePath) + "to specify an alternative path. The current path is: " <> + display (T.pack localProgramsFilePath) platformOnlyDir <- runReaderT platformOnlyRelDir (configPlatform, configPlatformVariant) let configLocalPrograms = configLocalProgramsBase platformOnlyDir