fix: Domain sandbox check was applied to CC and BCC even if list of domains was not supplied

bmonkman · bmonkman · commit 418896a641f8 · 2021-03-26T09:43:03.000-07:00
diff --git a/internal/service/api_email_service.go b/internal/service/api_email_service.go
@@ -70,9 +70,10 @@ func (s *EmailApiService) SendBulk(ctx context.Context, sendBulkMailRequest serv
 			zap.S().Infow("No valid Recipients for bulk send", zap.Any("original_addresses", originalAddresses))
 			return server.Response(http.StatusOK, server.SendMailResponse{TrackingId: "No valid recipients"}), nil
 		}
+
+		sendBulkMailRequest.CcAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.CcAddresses, s.config.AllowEmailToDomains)
+		sendBulkMailRequest.BccAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.BccAddresses, s.config.AllowEmailToDomains)
 	}
-	sendBulkMailRequest.CcAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.CcAddresses, s.config.AllowEmailToDomains)
-	sendBulkMailRequest.BccAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.BccAddresses, s.config.AllowEmailToDomains)
 
 	client := sendgrid.NewSendClient(s.config.SendgridAPIKey)
 

Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,10 @@ func (s *EmailApiService) SendBulk(ctx context.Context, sendBulkMailRequest serv`
`70`	`70`	`zap.S().Infow("No valid Recipients for bulk send", zap.Any("original_addresses", originalAddresses))`
`71`	`71`	`return server.Response(http.StatusOK, server.SendMailResponse{TrackingId: "No valid recipients"}), nil`
`72`	`72`	`}`
	`73`	`+`
	`74`	`+ sendBulkMailRequest.CcAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.CcAddresses, s.config.AllowEmailToDomains)`
	`75`	`+ sendBulkMailRequest.BccAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.BccAddresses, s.config.AllowEmailToDomains)`
`73`	`76`	`}`
`74`		`- sendBulkMailRequest.CcAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.CcAddresses, s.config.AllowEmailToDomains)`
`75`		`- sendBulkMailRequest.BccAddresses = mail.RemoveInvalidRecipients(sendBulkMailRequest.BccAddresses, s.config.AllowEmailToDomains)`
`76`	`77`
`77`	`78`	`client := sendgrid.NewSendClient(s.config.SendgridAPIKey)`
`78`	`79`