fix: ready check path in helm chart, switched to alpine base image because of liveness check issue

Author: bmonkman

Dockerfile

@@ -26,7 +26,7 @@ ENV CGO_ENABLED=0
 RUN make build
 
 
-FROM scratch AS runtime
+FROM alpine:3.13 AS runtime
 COPY --from=build /go/src/zero-notification-service ./
 EXPOSE 80/tcp
 ENTRYPOINT ["./zero-notification-service"]

charts/zero-notifcation-service/Chart.yaml

@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.0.3
+version: 0.0.4
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

charts/zero-notifcation-service/templates/deployment.yaml

@@ -46,7 +46,7 @@ spec:
             periodSeconds: 5
           readinessProbe:
             httpGet:
-              path: /status/ready
+              path: /v1/status/ready
               port: http
             initialDelaySeconds: 5
             periodSeconds: 10

cmd/server/main.go

@@ -64,7 +64,7 @@ func main() {
 		zap.S().Infof("Serving at http://%s/", serverAddress)
 		err := server.ListenAndServe()
 		if err != http.ErrServerClosed {
-			zap.S().Fatalf("Fatal error while serving HTTP: %v\n", err)
+			zap.S().Fatalf("Fatal error while serving HTTP: %v", err)
 			close(stop)
 		}
 	}()
@@ -78,7 +78,7 @@ func main() {
 	defer cancel()
 	err := server.Shutdown(ctx)
 	if err != nil {
-		zap.S().Fatalf("Error during shutdown, client requests have been terminated: %v\n", err)
+		zap.S().Fatalf("Error during shutdown, client requests have been terminated: %v", err)
 	} else {
 		zap.S().Infof("Graceful shutdown complete")
 	}
@@ -88,7 +88,7 @@ func heartbeat() {
 	for range time.Tick(4 * time.Second) {
 		fh, err := os.Create("/tmp/service-alive")
 		if err != nil {
-			zap.S().Warnf("Unable to write file for liveness check!")
+			zap.S().Errorf("Unable to write file for liveness check: $v", err)
 		} else {
 			fh.Close()
 		}