fixup! fixup! fixup! fixup! fixup! map instead of looping n^2 for env-var translation

Author: davidcheung

internal/init/prompts_test.go

@@ -93,14 +93,12 @@ func TestGetParam(t *testing.T) {
 				EnvVarName: "envvar1",
 			},
 			{
-				Field: "param2",
-				// references param1 using env-var
+				Field:      "param2",
 				Execute:    "echo $envvar1 bar",
 				EnvVarName: "envvar2",
 			},
 			{
-				Field: "param3",
-				// references param2 using env-var
+				Field:   "param3",
 				Execute: "echo $envvar2 baz",
 			},
 		}
@@ -109,8 +107,8 @@ func TestGetParam(t *testing.T) {
 		projectParams, _ = initPrompts.PromptModuleParams(module, projectParams)
 
 		assert.Equal(t, "foo", projectParams["param1"])
-		assert.Equal(t, "foo bar", projectParams["param2"])
-		assert.Equal(t, "foo bar baz", projectParams["param3"])
+		assert.Equal(t, "foo bar", projectParams["param2"], "should reference param1 via env-var")
+		assert.Equal(t, "foo bar baz", projectParams["param3"], "should reference param2 via env-var")
 	})
 
 	t.Run("Prompt conditions", func(t *testing.T) {
@@ -163,9 +161,9 @@ func TestGetParam(t *testing.T) {
 		module := moduleconfig.ModuleConfig{Parameters: params}
 		projectParams, _ = initPrompts.PromptModuleParams(module, projectParams)
 
-		assert.Equal(t, "pass", projectParams["param1"])
-		assert.Equal(t, "pass", projectParams["passing_condition"])
-		assert.NotContains(t, projectParams, "failing_condition")
-		assert.Equal(t, "pass", projectParams["multiple_condition"])
+		assert.Equal(t, "pass", projectParams["param1"], "Value just hardcoded")
+		assert.Equal(t, "pass", projectParams["passing_condition"], "Expected to pass condition and set value")
+		assert.NotContains(t, projectParams, "failing_condition", "Expected to fail condition and not set value")
+		assert.Equal(t, "pass", projectParams["multiple_condition"], "Expected to pass multiple condition and set value")
 	})
 }