fix: crash when changing showHidden when TracksFragment hasn't been initialized yet

Author: vinz243

app/src/main/java/io/compactd/player/ui/activities/LibraryActivity.java

@@ -156,9 +156,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
                 return true;
             case R.id.action_showhidden:
                 item.setChecked(!item.isChecked());
-                TracksFragment fragment = (TracksFragment)
-                        mSectionsPagerAdapter.getRegisteredFragment(2);
-                fragment.setShowHidden(item.isChecked());
+                mSectionsPagerAdapter.setShowHidden(item.isChecked());
 
                 return true;
 
@@ -187,6 +185,7 @@ protected void onDestroy() {
     public class SectionsPagerAdapter extends FragmentPagerAdapter {
 
         private SparseArray<Fragment> mRegisteredFragments = new SparseArray<>();
+        private boolean mShowHidden = false;
 
         SectionsPagerAdapter(FragmentManager fm) {
             super(fm);
@@ -200,7 +199,9 @@ public Fragment getItem(int position) {
                 case 1:
                     return AlbumsFragment.newInstance(ModelFragment.GRID_LAYOUT, null);
                 case 2:
-                    return TracksFragment.newInstance(ModelFragment.VERTICAL_LAYOUT, null);
+                    TracksFragment tracksFragment = TracksFragment.newInstance(ModelFragment.VERTICAL_LAYOUT, null);
+                    tracksFragment.setShowHidden(mShowHidden);
+                    return tracksFragment;
                 default:
                     return ArtistsFragment.newInstance(ModelFragment.GRID_LAYOUT, null);
             }
@@ -212,6 +213,7 @@ public int getCount() {
             return 3;
         }
 
+        @NonNull
         @Override
         public Object instantiateItem(ViewGroup container, int position) {
 
@@ -229,5 +231,13 @@ public void destroyItem(ViewGroup container, int position, Object object) {
         public Fragment getRegisteredFragment (int pos) {
             return mRegisteredFragments.get(pos);
         }
+
+        public void setShowHidden(boolean showHidden) {
+            TracksFragment fragment = (TracksFragment) getRegisteredFragment(2);
+            if (fragment != null)  {
+                fragment.setShowHidden(showHidden);
+            }
+            mShowHidden = showHidden;
+        }
     }
 }

app/src/main/java/io/compactd/player/ui/fragments/TracksFragment.java

@@ -24,6 +24,8 @@
  */
 
 public class TracksFragment extends ModelFragment<CompactdTrack> {
+    private boolean mShowHidden = false;
+
     public static TracksFragment newInstance (@LayoutMode int layout, String startKye) {
         return ModelFragment.newInstance(TracksFragment.class,  layout, startKye);
     }
@@ -45,12 +47,16 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         bindModel(TracksAdapter.class, items);
         adapter.setTintBackground(false);
 
+        ((TracksAdapter) adapter).setShowHidden(mShowHidden);
 
         return root;
     }
 
     public void setShowHidden (boolean flag) {
-        TracksAdapter adapter = (TracksAdapter) this.adapter;
-        adapter.setShowHidden(flag);
+        if (this.adapter != null) {
+            TracksAdapter adapter = (TracksAdapter) this.adapter;
+            adapter.setShowHidden(flag);
+        }
+        mShowHidden = flag;
     }
 }