From 390af0cd98e80501679cc25abd15103b02e04fba Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:45 -0700 Subject: [PATCH 01/20] Fixing src/main/java/io/shiftleft/controller/SearchController.java for finding 1025 --- .../controller/SearchController.java | 31 ++++++++++--------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/main/java/io/shiftleft/controller/SearchController.java b/src/main/java/io/shiftleft/controller/SearchController.java index cef2846e6..799a9ffd9 100644 --- a/src/main/java/io/shiftleft/controller/SearchController.java +++ b/src/main/java/io/shiftleft/controller/SearchController.java @@ -18,17 +18,20 @@ public class SearchController { @RequestMapping(value = "/search/user", method = RequestMethod.GET) - public String doGetSearch(@RequestParam String foo, HttpServletResponse response, HttpServletRequest request) { - java.lang.Object message = new Object(); - try { - String ACCESS_KEY_ID = "AKIA2E0A8F3B244C9986"; - String SECRET_KEY = "7CE556A3BC234CC1FF9E8A5C324C0BB70AA21B6D"; - ExpressionParser parser = new SpelExpressionParser(); - Expression exp = parser.parseExpression(foo); - message = (Object) exp.getValue(); - } catch (Exception ex) { - System.out.println(ex.getMessage()); - } - return message.toString(); - } -} + @RequestMapping(value = "/search/user", method = RequestMethod.GET) + public String doGetSearch(@RequestParam String foo, HttpServletResponse response, HttpServletRequest request) { + String message = null; + try { + // Removed the instantiation of java.lang.Object as it's unnecessary. + String ACCESS_KEY_ID = "AKIA2E0A8F3B244C9986"; + String SECRET_KEY = "7CE556A3BC234CC1FF9E8A5C324C0BB70AA21B6D"; + ExpressionParser parser = new SpelExpressionParser(); + Expression exp = parser.parseExpression(foo); + message = exp.getValue(String.class); // Specify the return type explicitly. + } catch (Exception ex) { + System.out.println(ex.getMessage()); + } + return message != null ? message : ""; // Return an empty string if message is null. + } + + From 2ccdd3fe6aa934a52da0d0b649fce2cc68c40a52 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:46 -0700 Subject: [PATCH 02/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1042 --- .../controller/CustomerController.java | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 40e1c4917..d8c823790 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -110,6 +110,7 @@ private void dispatchEventToSalesForce(String event) * @return retrieved customer */ @RequestMapping(value = "/customers/{customerId}", method = RequestMethod.GET) + @RequestMapping(value = "/customers/{customerId}", method = RequestMethod.GET) public Customer getCustomer(@PathVariable("customerId") Long customerId) { /* validate customer Id parameter */ @@ -123,8 +124,14 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } Account account = new Account(4242l,1234, "savings", 1, 0); - log.info("Account Data is {}", account); - log.info("Customer Data is {}", customer); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); try { dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); @@ -134,7 +141,19 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } return customer; - } + } + + private String encryptData(String data) { + // Use javax.crypto for encryption + // This is a placeholder implementation + return "encrypted:" + data; + } + + private String hashData(String data) { + // Use java.security.MessageDigest for hashing + // This is a placeholder implementation + return "hashed:" + data; + } /** * Handler for / loads the index.tpl @@ -388,3 +407,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ } } + From 3d27c3966ef77b5cee9c12d6ad466692b424e427 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:47 -0700 Subject: [PATCH 03/20] Fixing src/main/java/io/shiftleft/controller/AdminController.java for finding 1032 --- .../shiftleft/controller/AdminController.java | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/main/java/io/shiftleft/controller/AdminController.java b/src/main/java/io/shiftleft/controller/AdminController.java index 296c26573..4d3184d71 100644 --- a/src/main/java/io/shiftleft/controller/AdminController.java +++ b/src/main/java/io/shiftleft/controller/AdminController.java @@ -28,12 +28,18 @@ public class AdminController { private String fail = "redirect:/"; // helper - private boolean isAdmin(String auth) + private boolean isAdmin(String auth) { try { - ByteArrayInputStream bis = new ByteArrayInputStream(Base64.getDecoder().decode(auth)); - ObjectInputStream objectInputStream = new ObjectInputStream(bis); + byte[] data = Base64.getDecoder().decode(auth); + ByteArrayInputStream bis = new ByteArrayInputStream(data); + ObjectInputStream objectInputStream = new CustomObjectInputStream(bis); Object authToken = objectInputStream.readObject(); + + if(!(authToken instanceof AuthToken)) { + throw new IllegalArgumentException("Invalid auth token type"); + } + return ((AuthToken) authToken).isAdmin(); } catch (Exception ex) { System.out.println(" cookie cannot be deserialized: "+ex.getMessage()); @@ -41,6 +47,11 @@ private boolean isAdmin(String auth) } } + System.out.println(" cookie cannot be deserialized: "+ex.getMessage()); + return false; + } + } + // @RequestMapping(value = "/admin/printSecrets", method = RequestMethod.POST) public String doPostPrintSecrets(HttpServletResponse response, HttpServletRequest request) { @@ -135,3 +146,4 @@ public String doGetLogin(HttpServletResponse response, HttpServletRequest reques return "redirect:/"; } } + From 3b83c5d46c49cf13b5032a4d675afd6a411ae540 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:48 -0700 Subject: [PATCH 04/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1044 --- .../controller/CustomerController.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index d8c823790..b6f2125c3 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -110,6 +110,30 @@ private void dispatchEventToSalesForce(String event) * @return retrieved customer */ @RequestMapping(value = "/customers/{customerId}", method = RequestMethod.GET) + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + // Removed logging of sensitive account data + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + + return customer; + } + @RequestMapping(value = "/customers/{customerId}", method = RequestMethod.GET) public Customer getCustomer(@PathVariable("customerId") Long customerId) { @@ -408,3 +432,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ } + From 2382fc021e8d40e02d79ae34305d8cc6fee86c93 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:49 -0700 Subject: [PATCH 05/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1046 --- .../controller/CustomerController.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index b6f2125c3..445a2bc07 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -131,6 +131,30 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + // Removed logging of sensitive account data + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -433,3 +457,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ } + From c968f72ec3e9b1f1e76b4d6988cc0938a6bc3b3d Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:59 -0700 Subject: [PATCH 06/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1045 --- .../controller/CustomerController.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 445a2bc07..62a0d61ab 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -155,6 +155,30 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + // Removed logging of sensitive account data + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -458,3 +482,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From aa7997073b7cec785b220235601dc5f612d9c826 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:17:59 -0700 Subject: [PATCH 07/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1041 --- .../controller/CustomerController.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 62a0d61ab..ee459f75d 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -179,6 +179,30 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + // Removed logging of sensitive account data + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -483,3 +507,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 838e6085d55d91ec579612de428b92fdd32428fd Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:18:02 -0700 Subject: [PATCH 08/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1043 --- .../controller/CustomerController.java | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index ee459f75d..8f3d388e0 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -117,6 +117,30 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { throw new InvalidCustomerRequestException(); } + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + // Removed logging of sensitive account information + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + Customer customer = customerRepository.findOne(customerId); if (null == customer) { throw new CustomerNotFoundException(); @@ -508,3 +532,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From b82188dd6e2918bf784eb5b88b833016987561a4 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:29 -0700 Subject: [PATCH 09/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1085 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 8f3d388e0..c2f8c4503 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -260,6 +260,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -533,3 +565,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From e8806bcc99d202cddc144db5dc1be30dd0b9bc3f Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:32 -0700 Subject: [PATCH 10/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1087 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index c2f8c4503..06552a9eb 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -292,6 +292,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -566,3 +598,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From d61088100b3c6aea403dc403de2f2de8f966f36c Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:34 -0700 Subject: [PATCH 11/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1085 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 06552a9eb..8b749126c 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -324,6 +324,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -599,3 +631,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 6e1ca760a11f145559af8294fb45f2535f149f1b Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:37 -0700 Subject: [PATCH 12/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1087 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 8b749126c..d74fcee17 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -356,6 +356,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -632,3 +664,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 0aff47061b6b52efb258fafe1e6df529472fc64e Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:39 -0700 Subject: [PATCH 13/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1083 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index d74fcee17..c3bbc4b89 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -388,6 +388,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -665,3 +697,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 54b9295f1bf83f79dad6fc4797a8f1e672015995 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:42 -0700 Subject: [PATCH 14/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1083 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index c3bbc4b89..d1991761c 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -420,6 +420,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -698,3 +730,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From f30ef3a301bbbdf60c251f900eb663033d4f12e9 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:43 -0700 Subject: [PATCH 15/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1084 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index d1991761c..e2969dcd4 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -452,6 +452,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -731,3 +763,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 975abeab3ab0795178cbcc8f0b8d3d4a9c9888d3 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:45 -0700 Subject: [PATCH 16/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1086 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index e2969dcd4..8c8378898 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -484,6 +484,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -764,3 +796,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From acf8e51f33056eabe7b6505d8eb4e69e71b1784e Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:49 -0700 Subject: [PATCH 17/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1084 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 8c8378898..5ce289fce 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -516,6 +516,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -797,3 +829,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 813f8ba5d231c28e2976271d51da589c7ee07162 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:49 -0700 Subject: [PATCH 18/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1082 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 5ce289fce..eb28f0195 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -548,6 +548,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -830,3 +862,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From 97dcf38483a11e493cedbe9c15fad19743ed7193 Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:51 -0700 Subject: [PATCH 19/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1082 --- .../controller/CustomerController.java | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index eb28f0195..6f51373ae 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -580,6 +580,38 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + return customer; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -863,3 +895,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ + From c9e9f99a6651a865498dbd7023b58db1ade1a71f Mon Sep 17 00:00:00 2001 From: Chetan Conikee Date: Thu, 8 Aug 2024 11:20:53 -0700 Subject: [PATCH 20/20] Fixing src/main/java/io/shiftleft/controller/CustomerController.java for finding 1086 --- .../controller/CustomerController.java | 34 +++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/main/java/io/shiftleft/controller/CustomerController.java b/src/main/java/io/shiftleft/controller/CustomerController.java index 6f51373ae..386b37df8 100644 --- a/src/main/java/io/shiftleft/controller/CustomerController.java +++ b/src/main/java/io/shiftleft/controller/CustomerController.java @@ -260,6 +260,39 @@ public Customer getCustomer(@PathVariable("customerId") Long customerId) { } + // Removed the customer object from the return statement as it is not secure to return sensitive data + return null; + } + + public Customer getCustomer(@PathVariable("customerId") Long customerId) { + + /* validate customer Id parameter */ + if (null == customerId) { + throw new InvalidCustomerRequestException(); + } + + Customer customer = customerRepository.findOne(customerId); + if (null == customer) { + throw new CustomerNotFoundException(); + } + + Account account = new Account(4242l,1234, "savings", 1, 0); + + // Encrypting account data before logging + String encryptedAccountData = encryptData(account.toString()); + log.info("Encrypted Account Data is {}", encryptedAccountData); + + // Hashing customer data before logging + String hashedCustomerData = hashData(customer.toString()); + log.info("Hashed Customer Data is {}", hashedCustomerData); + + try { + dispatchEventToSalesForce(String.format(" Customer %s Logged into SalesForce", customer)); + } catch (Exception e) { + log.error("Failed to Dispatch Event to SalesForce . Details {} ", e.getLocalizedMessage()); + + } + return customer; } @@ -896,3 +929,4 @@ public void removeCustomer(@PathVariable("customerId") Long customerId, HttpServ +