From 12b3998bdd04e4c8b36d69faf5e65d8157be94c8 Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Tue, 15 Jul 2025 14:48:53 +0900 Subject: [PATCH 1/3] =?UTF-8?q?Fix=20`error:=20implicit=20declaration=20of?= =?UTF-8?q?=20function=20=E2=80=98memcpy=E2=80=99`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix containerd/containerd issue 12094 ``` btrfs.c: In function ‘unpack_root_item’: btrfs.c:25:9: error: implicit declaration of function ‘memcpy’ [-Wimplicit-function-declaration] 25 | memcpy(dst->uuid, src->uuid, BTRFS_UUID_SIZE); | ^~~~~~ btrfs.c:23:1: note: include ‘’ or provide a declaration of ‘memcpy’ 22 | #include "btrfs.h" +++ |+#include 23 | btrfs.c:25:9: warning: incompatible implicit declaration of built-in function ‘memcpy’ [-Wbuiltin-declaration-mismatch] 25 | memcpy(dst->uuid, src->uuid, BTRFS_UUID_SIZE); | ^~~~~~ btrfs.c:25:9: note: include ‘’ or provide a declaration of ‘memcpy’ ``` Signed-off-by: Akihiro Suda --- btrfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/btrfs.c b/btrfs.c index f0da012..7fad5a5 100644 --- a/btrfs.c +++ b/btrfs.c @@ -15,6 +15,7 @@ */ #include +#include #include #include #include From cab79ec9ea7e1b910e9aef01afbf87efb57ee674 Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Tue, 15 Jul 2025 14:52:49 +0900 Subject: [PATCH 2/3] CI: enable jobs for release/1.0 Signed-off-by: Akihiro Suda --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 23dae51..7fbe591 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,9 @@ name: CI on: push: - branches: [ main ] + branches: [ main, release/1.0 ] pull_request: - branches: [ main ] + branches: [ main, release/1.0 ] jobs: From 3fb5c91f016ebdfc72a0c64e81889defdb1dd51d Mon Sep 17 00:00:00 2001 From: Akihiro Suda Date: Tue, 15 Jul 2025 14:57:26 +0900 Subject: [PATCH 3/3] CI: update (Go 1.23, etc.) project-checks no longer works with an old Go ``` get "golang.org/x/sys/unix": found meta tag vcs.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at //golang.org/x/sys/unix?go-get=1 get "golang.org/x/sys/unix": verifying non-authoritative meta tag golang.org/x/sys (download) package slices: unrecognized import path "slices": import path does not begin with hostname ``` Signed-off-by: Akihiro Suda --- .github/workflows/ci.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7fbe591..76fdad9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,9 +15,10 @@ jobs: steps: - name: Set up Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: - go-version: 1.19.x + # Needed by project-checks + go-version: 1.23.x id: go - name: Setup environment @@ -27,13 +28,13 @@ jobs: echo "${{ github.workspace }}/bin" >> $GITHUB_PATH - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: src/github.com/containerd/btrfs fetch-depth: 25 - name: Project checks - uses: containerd/project-checks@v1 + uses: containerd/project-checks@v1.2.1 with: working-directory: src/github.com/containerd/btrfs