From b5390c1d77adee79c725c9edd48b2c036336b679 Mon Sep 17 00:00:00 2001 From: Nadeem Patwekar Date: Thu, 7 Nov 2024 11:43:40 +0530 Subject: [PATCH 1/2] fix: :bug: add data type attr for inline code --- __test__/default-node-options.test.ts | 8 ++++---- __test__/mock/json-element-mock-result.ts | 4 ++-- __test__/reference-to-html.test.ts | 7 +++---- __test__/text-node-to-html.test.ts | 4 ++-- src/options/default-node-options.ts | 2 +- 5 files changed, 12 insertions(+), 13 deletions(-) diff --git a/__test__/default-node-options.test.ts b/__test__/default-node-options.test.ts index 986c1d2..4a6ccce 100644 --- a/__test__/default-node-options.test.ts +++ b/__test__/default-node-options.test.ts @@ -218,17 +218,17 @@ describe('Default node render options', () => { expect(renderString).toEqual('text') done() }) - it('Should return bold string', done => { + it('Should return inline code string', done => { const renderString = (defaultNodeOption[MarkType.INLINE_CODE] as RenderMark)(text) - expect(renderString).toEqual('text') + expect(renderString).toEqual(`text`) done() }) - it('Should return bold string', done => { + it('Should return subscript string', done => { const renderString = (defaultNodeOption[MarkType.SUBSCRIPT] as RenderMark)(text) expect(renderString).toEqual('text') done() }) - it('Should return bold string', done => { + it('Should return superscript string', done => { const renderString = (defaultNodeOption[MarkType.SUPERSCRIPT] as RenderMark)(text) expect(renderString).toEqual('text') done() diff --git a/__test__/mock/json-element-mock-result.ts b/__test__/mock/json-element-mock-result.ts index 8d96b49..0951311 100644 --- a/__test__/mock/json-element-mock-result.ts +++ b/__test__/mock/json-element-mock-result.ts @@ -1,4 +1,4 @@ -const plainTextHtml = "Aliquam sit amet libero dapibus, eleifend ligula at, varius justoLorem ipsumdolor sit amet
consectetur adipiscing elit.Sed condimentum iaculis magna in vehicula. Vestibulum vitae convallis lacus. " +const plainTextHtml = "Aliquam sit amet libero dapibus, eleifend ligula at, varius justoLorem ipsumdolor sit amet
consectetur adipiscing elit.Sed condimentum iaculis magna in vehicula. Vestibulum vitae convallis lacus. " const paragraphHtml = "

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed condimentum iaculis magna in vehicula. Vestibulum vitae convallis lacus. Praesent a diam iaculis turpis rhoncus faucibus. Aliquam sed pulvinar sem.

" const h1Html = "

Lorem ipsum dolor sit amet.

" const h2Html = "

Vestibulum a ligula eget massa sagittis aliquam sit amet quis tortor.

" @@ -14,7 +14,7 @@ const blockquoteHtml = "
Praesent eu ex sed nibh venenatis pretium.Code template." const linkInPHtml = "LINK" const linkInPURLHtml = "LINK" -const styleinPHtml = "

This is second JSON entry

Example

" +const styleinPHtml = "

This is second JSON entry

Example

" const plainTextHtmlWithClass = "

abcghiBasic

abc

" const plainTextHtmlWithId = "

data

" const htmlTextIdInAttrs = "

data

" diff --git a/__test__/reference-to-html.test.ts b/__test__/reference-to-html.test.ts index 7fc0293..06b43d2 100644 --- a/__test__/reference-to-html.test.ts +++ b/__test__/reference-to-html.test.ts @@ -10,9 +10,8 @@ import { defaultOptions } from '../src/options/default-options' import { assetReferenceJson, embeddedAssetJsonEntry, embeddedEntryJsonEntry, entryReferenceBlockJson, entryReferenceInlineJson, entryReferenceLinkJson } from './mock/json-element-mock' import { embeddedAssetWithRenderOption, embeddedObjectDefaultRender, embeddedObjectWithRenderOption } from './mock/render-options' describe('Reference Node To HTML', () => { - it.skip('Should return blank for undefined entry', done => { + it('Should return blank for undefined entry', done => { const node = assetReferenceJson.children[0] as unknown as Node - console.log('Node attributes:', node.attrs); const renderOption = {} const resultHTML = referenceToHTML(node, renderOption) @@ -49,7 +48,7 @@ describe('Reference Node To HTML', () => { done() }) - it.skip('Should return HTML for embedded asset', done => { + it('Should return HTML for embedded asset', done => { const node = assetReferenceJson.children[0] as unknown as Node const renderOption = {} @@ -95,7 +94,7 @@ describe('Reference Node To HTML', () => { }) // Custom render option - it.skip('Should return custom HTML for embedded asset', done => { + it('Should return custom HTML for embedded asset', done => { const node = assetReferenceJson.children[0] as unknown as Node const renderOption = embeddedAssetWithRenderOption.renderOption as RenderOption diff --git a/__test__/text-node-to-html.test.ts b/__test__/text-node-to-html.test.ts index 01904d4..e7ac35d 100644 --- a/__test__/text-node-to-html.test.ts +++ b/__test__/text-node-to-html.test.ts @@ -73,7 +73,7 @@ describe('Text Node To HTML', () => { ...defaultNodeOption }) - expect(resultHtml).toEqual(`${textNode.text}`) + expect(resultHtml).toEqual(`${textNode.text}`) done() }) it('Should return Subscript string text', done => { @@ -119,7 +119,7 @@ describe('Text Node To HTML', () => { ...defaultNodeOption }) - expect(resultHtml).toEqual(`${textNode.text}`) + expect(resultHtml).toEqual(`${textNode.text}`) done() }) }) \ No newline at end of file diff --git a/src/options/default-node-options.ts b/src/options/default-node-options.ts index 24b228d..ca516d1 100644 --- a/src/options/default-node-options.ts +++ b/src/options/default-node-options.ts @@ -141,7 +141,7 @@ export const defaultNodeOption: RenderOption = { return `${sanitizeHTML(text)}` }, [MarkType.INLINE_CODE]:(text: string) => { - return `${sanitizeHTML(text)}` + return `${sanitizeHTML(text)}` }, [MarkType.SUBSCRIPT]:(text: string) => { return `${sanitizeHTML(text)}` From 91b8d88575c08d9df35ee06366affa147d936594 Mon Sep 17 00:00:00 2001 From: Nadeem Patwekar Date: Thu, 7 Nov 2024 11:52:44 +0530 Subject: [PATCH 2/2] chore: version bump --- CHANGELOG.md | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e78677..bdd3675 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## [1.3.14](https://github.com/contentstack/contentstack-utils-javascript/tree/v1.3.14) (2024-11-12) + - Fix: Add data-type attr to inlineCode + ## [1.3.13](https://github.com/contentstack/contentstack-utils-javascript/tree/v1.3.13) (2024-10-22) - Enh: Node version bump diff --git a/package.json b/package.json index 4c25fb7..6e6b2ad 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@contentstack/utils", - "version": "1.3.13", + "version": "1.3.14", "description": "Contentstack utilities for Javascript", "main": "dist/index.es.js", "types": "dist/types/index.d.ts",