From 553d650d68664e65230d323af6bee54b1ddaa350 Mon Sep 17 00:00:00 2001 From: Sonu Lohani Date: Sun, 9 May 2021 14:13:30 +0530 Subject: [PATCH 1/2] feat: Press Escape key to cancel select --- src/internal/QCodeEditor.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/internal/QCodeEditor.cpp b/src/internal/QCodeEditor.cpp index 04875ec..6cf3a41 100644 --- a/src/internal/QCodeEditor.cpp +++ b/src/internal/QCodeEditor.cpp @@ -843,6 +843,13 @@ void QCodeEditor::keyPressEvent(QKeyEvent *e) return; } + if (e->key() == Qt::Key_Escape) + { + auto cursor = textCursor(); + cursor.clearSelection(); + setTextCursor(cursor); + } + QTextEdit::keyPressEvent(e); } From 400bb01cf5e0b062453a1dde3f763178fa9bf846 Mon Sep 17 00:00:00 2001 From: Sonu Lohani Date: Sun, 16 May 2021 19:59:43 +0530 Subject: [PATCH 2/2] Address review comments --- src/internal/QCodeEditor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/internal/QCodeEditor.cpp b/src/internal/QCodeEditor.cpp index 6cf3a41..a551eda 100644 --- a/src/internal/QCodeEditor.cpp +++ b/src/internal/QCodeEditor.cpp @@ -843,7 +843,7 @@ void QCodeEditor::keyPressEvent(QKeyEvent *e) return; } - if (e->key() == Qt::Key_Escape) + if (e->key() == Qt::Key_Escape && textCursor().hasSelection()) { auto cursor = textCursor(); cursor.clearSelection();