Skip to content

Fix #12662 FP unreadVariable with QMap iterator #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 3 commits into from
Apr 28, 2024
Merged

Fix #12662 FP unreadVariable with QMap iterator #6354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c388953
Fix #12662 FP unreadVariable with QMap iterator
chrchr-github Apr 27, 2024
5420aff
Update qt.cpp
chrchr-github Apr 27, 2024
a9fb465
Suppress checkLibraryFunction
chrchr-github Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/fwdanalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,8 @@ bool FwdAnalysis::possiblyAliased(const Token *expr, const Token *startToken) co
return true;
if (Token::simpleMatch(expr, ". *"))
return true;
if (expr->str() == "(" && Token::simpleMatch(expr->astOperand1(), "."))
return true;

const bool macro = false;
const bool pure = false;
Expand Down
10 changes: 10 additions & 0 deletions test/cfg/qt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,3 +775,13 @@ void unusedVariable_qtContainers() // #10689
QLatin1String ql1s;
}

void unreadVariable_QMapIterator(QMap<QString, QObject*>& m)
{
auto it = m.find("abc"); // #12662
if (it != m.end()) {
// cppcheck-suppress checkLibraryFunction // TODO
Comment thread
chrchr-github marked this conversation as resolved.
delete it.value();
// cppcheck-suppress checkLibraryFunction
it.value() = new QObject();
}
}