From e7fd497e69f060ab13e3a18f7a5c8c86f4a0a27c Mon Sep 17 00:00:00 2001 From: Shahar Yair Date: Wed, 9 Oct 2024 10:09:51 +0300 Subject: [PATCH 1/3] improved logger --- src/crewai/crew.py | 4 ++-- src/crewai/utilities/file_handler.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/crewai/crew.py b/src/crewai/crew.py index 91b75c6cef..1b77c5e418 100644 --- a/src/crewai/crew.py +++ b/src/crewai/crew.py @@ -771,7 +771,7 @@ def _add_delegation_tools(self, task: Task): def _log_task_start(self, task: Task, role: str = "None"): if self.output_log_file: - self._file_handler.log(agent=role, task=task.description, status="started") + self._file_handler.log(task_name=task.name, task=task.description, agent=role, status="started") def _update_manager_tools(self, task: Task): if self.manager_agent: @@ -793,7 +793,7 @@ def _get_context(self, task: Task, task_outputs: List[TaskOutput]): def _process_task_result(self, task: Task, output: TaskOutput) -> None: role = task.agent.role if task.agent is not None else "None" if self.output_log_file: - self._file_handler.log(agent=role, task=output, status="completed") + self._file_handler.log(agent=role, task_name=task.name, task=task.description, output=output.raw, status="completed") def _create_crew_output(self, task_outputs: List[TaskOutput]) -> CrewOutput: if len(task_outputs) != 1: diff --git a/src/crewai/utilities/file_handler.py b/src/crewai/utilities/file_handler.py index 1125cae4e1..8c1119d2a4 100644 --- a/src/crewai/utilities/file_handler.py +++ b/src/crewai/utilities/file_handler.py @@ -16,7 +16,7 @@ def __init__(self, file_path): def log(self, **kwargs): now = datetime.now().strftime("%Y-%m-%d %H:%M:%S") - message = f"{now}: ".join([f"{key}={value}" for key, value in kwargs.items()]) + message = f"{now}: ".join([f"{key}={value}\n" for key, value in kwargs.items()]) with open(self._path, "a", encoding="utf-8") as file: file.write(message + "\n") From 2470d9afbf6cfa65ddb6c4c3be52f8200a655885 Mon Sep 17 00:00:00 2001 From: Shahar Yair Date: Wed, 9 Oct 2024 12:09:58 +0300 Subject: [PATCH 2/3] log file looks better --- src/crewai/crew.py | 2 +- src/crewai/utilities/file_handler.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crewai/crew.py b/src/crewai/crew.py index 1b77c5e418..9030842c20 100644 --- a/src/crewai/crew.py +++ b/src/crewai/crew.py @@ -793,7 +793,7 @@ def _get_context(self, task: Task, task_outputs: List[TaskOutput]): def _process_task_result(self, task: Task, output: TaskOutput) -> None: role = task.agent.role if task.agent is not None else "None" if self.output_log_file: - self._file_handler.log(agent=role, task_name=task.name, task=task.description, output=output.raw, status="completed") + self._file_handler.log(task_name=task.name, task=task.description, agent=role, status="completed", output=output.raw) def _create_crew_output(self, task_outputs: List[TaskOutput]) -> CrewOutput: if len(task_outputs) != 1: diff --git a/src/crewai/utilities/file_handler.py b/src/crewai/utilities/file_handler.py index 8c1119d2a4..b5af699e6a 100644 --- a/src/crewai/utilities/file_handler.py +++ b/src/crewai/utilities/file_handler.py @@ -16,7 +16,7 @@ def __init__(self, file_path): def log(self, **kwargs): now = datetime.now().strftime("%Y-%m-%d %H:%M:%S") - message = f"{now}: ".join([f"{key}={value}\n" for key, value in kwargs.items()]) + message = f"{now}: " + " ".join([f"{key}={value}" for key, value in kwargs.items()]) + "\n" with open(self._path, "a", encoding="utf-8") as file: file.write(message + "\n") From f0856003a77f07bce2ec100e8060248bc636ba28 Mon Sep 17 00:00:00 2001 From: Shahar Yair Date: Wed, 9 Oct 2024 12:17:36 +0300 Subject: [PATCH 3/3] better lines written to log file --- src/crewai/utilities/file_handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crewai/utilities/file_handler.py b/src/crewai/utilities/file_handler.py index b5af699e6a..091bd930a8 100644 --- a/src/crewai/utilities/file_handler.py +++ b/src/crewai/utilities/file_handler.py @@ -16,7 +16,7 @@ def __init__(self, file_path): def log(self, **kwargs): now = datetime.now().strftime("%Y-%m-%d %H:%M:%S") - message = f"{now}: " + " ".join([f"{key}={value}" for key, value in kwargs.items()]) + "\n" + message = f"{now}: " + ", ".join([f"{key}=\"{value}\"" for key, value in kwargs.items()]) + "\n" with open(self._path, "a", encoding="utf-8") as file: file.write(message + "\n")