Fix: Setup import dialog styling issues#2597
Merged
SReject merged 1 commit intocrowbartools:v5from Jul 11, 2024
Merged
Conversation
The import .firebotsetup dialogs had some style issues, notably evident in the application light theme, and the popout description dialog has white text on a white background regardless of theme. This should address both issues.
SReject
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adjusts the styling of the firebotsetup import dialogs. The use of the
effect-listclass is not ideal here, but seems a better solution than a hard-coded color, or the addition of new .scss definitions, which is at the edge of my comfort zone.Applicable Issues
None found
Testing
Ran through with a few meaningless examples, and validated all application themes and Windows coloring schemes. Ideally, this still needs to be tested on BSD/OS-X/*nix to validate the L143 change, but I can't imagine that I made it any worse.
Screenshots
Before:
note that the text in the Popout Description dialog is in-fact there and selectable, but it is rendered with white text on a white background in Windows.
After:
