feat: enable propertyPath and defaultData for effectOutput#2709
Merged
ebiggz merged 2 commits intocrowbartools:v5from Aug 18, 2024
Merged
feat: enable propertyPath and defaultData for effectOutput#2709ebiggz merged 2 commits intocrowbartools:v5from
ebiggz merged 2 commits intocrowbartools:v5from
Conversation
ebiggz
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add property path and default data to effectOutput, similar to customVariable
Applicable Issues
#2091
Testing
Ensured providing no property path still returns the full value
Ensured providing a property path to an object or array output results in the proper path or defaultData being returned
Ensured providing a null property path to use defaultData returns defaultData when there is no data
Ensured using a JSON stringified effect output (eg. Obs Raw Request) returns the proper data at the property path