Skip to content

Comments

feat: add more verbose error to http request log#2935

Merged
zunderscore merged 3 commits intocrowbartools:v5from
CKY-:v5-error-messages-in-http-request
Dec 21, 2024
Merged

feat: add more verbose error to http request log#2935
zunderscore merged 3 commits intocrowbartools:v5from
CKY-:v5-error-messages-in-http-request

Conversation

@CKY-
Copy link
Collaborator

@CKY- CKY- commented Dec 20, 2024

Description of the Change

add more verbose error to http request log
ran linting on the file.

before change

[2024-12-20 05:53:56.0984] - error: Error running http request 'Request failed with status code 400'

after change

[2024-12-20 05:53:56.0984] - error: Error running http request 
{
  errorMessage: 'Request failed with status code 400',
  responseData: { message: 'Cannot send an empty message', code: 50006 }
}

Applicable Issues

Testing

ran an empty request against an endpoint that has 200 400 errors

Screenshots

@CKY- CKY- requested a review from ebiggz as a code owner December 20, 2024 06:07
@zunderscore zunderscore merged commit 3267f18 into crowbartools:v5 Dec 21, 2024
1 check passed
Alastor-git pushed a commit to Alastor-git/Firebot that referenced this pull request Dec 27, 2024
@CKY- CKY- deleted the v5-error-messages-in-http-request branch January 1, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants