From 0f03258f33d80adfeba43203e068edc4b0a23c16 Mon Sep 17 00:00:00 2001
From: CKY- <xx_cky_xx@hotmail.com>
Date: Thu, 19 Dec 2024 23:03:28 -0700
Subject: [PATCH 1/2] feat: add more verbose error to http request log

---
 src/backend/effects/builtin/http-request.js | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/backend/effects/builtin/http-request.js b/src/backend/effects/builtin/http-request.js
index ea53ddc7c..da4d89491 100644
--- a/src/backend/effects/builtin/http-request.js
+++ b/src/backend/effects/builtin/http-request.js
@@ -9,12 +9,12 @@ const axios = axiosDefault.create({
     }
 });
 
-axios.interceptors.request.use(request => {
+axios.interceptors.request.use((request) => {
     //logger.debug('HTTP Request Effect [Request]: ', JSON.parse(JSON.stringify(request)));
     return request;
 });
 
-axios.interceptors.response.use(response => {
+axios.interceptors.response.use((response) => {
     //logger.debug('HTTP Request Effect [Response]: ', JSON.parse(JSON.stringify(response)));
     return response;
 });
@@ -159,7 +159,7 @@ const effect = {
                 resolveObj: {
                     header: () => header
                 },
-                closeCallback: newHeader => {
+                closeCallback: (newHeader) => {
                     console.log(newHeader);
                     $scope.effect.headers = $scope.effect.headers.filter(h => h.key !== newHeader.key);
                     $scope.effect.headers.push(newHeader);
@@ -222,7 +222,7 @@ const effect = {
         }
         return errors;
     },
-    onTriggerEvent: async event => {
+    onTriggerEvent: async (event) => {
 
         const logger = require("../../logwrapper");
         const twitchAuth = require("../../auth/twitch-auth");
@@ -284,7 +284,12 @@ const effect = {
                 );
             }
         } catch (error) {
-            logger.error("Error running http request", error.message);
+            const message = {
+                errorMessage: error.message,
+                responseData: error.response.data
+            };
+
+            logger.error("Error running http request", message);
 
             if (effect.options.runEffectsOnError && !abortSignal?.aborted) {
                 const processEffectsRequest = {

From 8a212ea831b8464fa53c0b70614c3dd6ea2db35d Mon Sep 17 00:00:00 2001
From: Zack Williamson <zwilliamson@outlook.com>
Date: Fri, 20 Dec 2024 21:01:03 -0500
Subject: [PATCH 2/2] fix: null check responseData just in case

---
 src/backend/effects/builtin/http-request.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/effects/builtin/http-request.js b/src/backend/effects/builtin/http-request.js
index da4d89491..3fefa3814 100644
--- a/src/backend/effects/builtin/http-request.js
+++ b/src/backend/effects/builtin/http-request.js
@@ -286,7 +286,7 @@ const effect = {
         } catch (error) {
             const message = {
                 errorMessage: error.message,
-                responseData: error.response.data
+                responseData: error.response?.data
             };
 
             logger.error("Error running http request", message);