Skip to content

Comments

fix(ranks): rankLadder variable register#2996

Merged
CaveMobster merged 1 commit intocrowbartools:v5from
CKY-:v5-ladder-name-variable
Feb 14, 2025
Merged

fix(ranks): rankLadder variable register#2996
CaveMobster merged 1 commit intocrowbartools:v5from
CKY-:v5-ladder-name-variable

Conversation

@CKY-
Copy link
Collaborator

@CKY- CKY- commented Feb 14, 2025

Description of the Change

register rankLadder variable

Applicable Issues

#2995

Testing

sent chat message on rank ladder update event
@$userDisplayName[$user] has achieved the rank of $newRank $rankValueDescription[$rankLadder, $newRank]!
@phroggie has achieved the rank of regular 3000 test1!

Screenshots

@CKY- CKY- requested a review from ebiggz as a code owner February 14, 2025 04:29
@phroggster
Copy link
Collaborator

phroggster commented Feb 14, 2025

Once this is merged, a Chat Message effect can use @$userDisplayName has achieved the rank of $newRank ($rankValueDescription[$rankLadder, $newRank])! to get a similar message to the default message template in a Viewer Rank Updated event. Until merging, the closest we can get in the nightlies is @$userDisplayName has achieved the rank of $newRank! (or @$userDisplayName[$user] has achieved the rank of $newRank! in the v5.63.2 release).

@CaveMobster CaveMobster enabled auto-merge (squash) February 14, 2025 10:58
@CaveMobster CaveMobster disabled auto-merge February 14, 2025 10:58
@CaveMobster CaveMobster merged commit e9d974c into crowbartools:v5 Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants