[warning: "
+ this->str << " [warning: "
<< this->newDefMsg << "]";
}
diff --git a/tests/cshtml/0001-smoke/scan-results.html b/tests/cshtml/0001-smoke/scan-results.html
index d0870c18..29033a2d 100644
--- a/tests/cshtml/0001-smoke/scan-results.html
+++ b/tests/cshtml/0001-smoke/scan-results.html
@@ -10,7 +10,7 @@
.infoEvent { color:#808080; }
.infoEventComment { color:#00C0C0; }
.traceEvent { color: #C0C0C0; }
- .newDefect { color: #00FF00; }
+ .newFinding { color: #00FF00; }
.parseWarning { color: #FF0000; }
.impFlag { color: #FF0000; font-weight: bold; }
#scanProps { font-family: monospace; }
@@ -21,7 +21,7 @@
curl-7.60.0-1.el8+7
[Show plain-text results]
-List of Defects
+List of Findings
Error: SHELLCHECK_WARNING: [#def1]
/usr/bin/curl-config:25:1: warning[SC2034]: exec_prefix appears unused. Verify it or export it.
@@ -79,7 +79,7 @@ List of Defects
-Error: CPPCHECK_WARNING (CWE-456): [#def7] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CPPCHECK_WARNING (CWE-456): [#def7] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/curl_ntlm_core.c:414: error[uninitvar]: Uninitialized variable: ks
@@ -98,7 +98,7 @@ List of Defects
-Error: CPPCHECK_WARNING (CWE-456): [#def9] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CPPCHECK_WARNING (CWE-456): [#def9] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/curl_ntlm_core.c:489: error[uninitvar]: Uninitialized variable: ks
@@ -106,7 +106,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def10] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def10] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/curl_ntlm_core.c:571: assignment: Assigning: "result" = "((void)data) , CURLE_OK".
curl-7.60.0/lib/curl_ntlm_core.c:572: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/curl_ntlm_core.c:572: dead_error_condition: The condition "result" cannot be true.
@@ -117,7 +117,7 @@ List of Defects
-Error: TAINTED_STRING (CWE-20): [#def11] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: TAINTED_STRING (CWE-20): [#def11] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/curl_ntlm_wb.c:129: cond_false: Condition "conn->ntlm_auth_hlpr_socket != -1", taking false branch.
curl-7.60.0/lib/curl_ntlm_wb.c:129: cond_false: Condition "conn->ntlm_auth_hlpr_pid", taking false branch.
curl-7.60.0/lib/curl_ntlm_wb.c:131: if_end: End of if statement.
@@ -156,7 +156,7 @@ List of Defects
-Error: TAINTED_STRING (CWE-20): [#def12] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: TAINTED_STRING (CWE-20): [#def12] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/curl_ntlm_wb.c:129: cond_false: Condition "conn->ntlm_auth_hlpr_socket != -1", taking false branch.
curl-7.60.0/lib/curl_ntlm_wb.c:129: cond_false: Condition "conn->ntlm_auth_hlpr_pid", taking false branch.
curl-7.60.0/lib/curl_ntlm_wb.c:131: if_end: End of if statement.
@@ -258,16 +258,16 @@ List of Defects
-Error: CLANG_WARNING: [#def15] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def15] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/formdata.c: internal warning: child 19175 timed out after 30s
-Error: CLANG_WARNING: [#def16] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def16] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/formdata.c: internal warning: child 31044 timed out after 30s
-Error: CLANG_WARNING: [#def17] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def17] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/ftp.c: internal warning: child 31022 timed out after 30s
-Error: DEADCODE (CWE-561): [#def18] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def18] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/ftp.c:3975: assignment: Assigning: "result" = "((void)conn->data) , CURLE_OK".
curl-7.60.0/lib/ftp.c:3977: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/ftp.c:3977: dead_error_condition: The condition "result" cannot be true.
@@ -278,7 +278,7 @@ List of Defects
-Error: CONSTANT_EXPRESSION_RESULT (CWE-398): [#def19] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CONSTANT_EXPRESSION_RESULT (CWE-398): [#def19] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/getinfo.c:159: result_independent_of_operands: "data->info.filetime > 9223372036854775807L" is always false regardless of the values of its operands. This occurs as the logical operand of "if".
@@ -286,7 +286,7 @@ List of Defects
-Error: CONSTANT_EXPRESSION_RESULT (CWE-398): [#def20] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CONSTANT_EXPRESSION_RESULT (CWE-398): [#def20] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/getinfo.c:161: result_independent_of_operands: "data->info.filetime < -9223372036854775808L /* -9223372036854775807L - 1L */" is always false regardless of the values of its operands. This occurs as the logical operand of "if".
@@ -294,7 +294,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def21] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def21] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/http.c:1086: assignment: Assigning: "result" = "((void)conn->data) , CURLE_OK".
curl-7.60.0/lib/http.c:1088: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/http.c:1088: dead_error_condition: The condition "result" cannot be true.
@@ -316,7 +316,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def23] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def23] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/http_chunks.c:157: assignment: Assigning: "result" = "((void)conn->data) , CURLE_OK".
curl-7.60.0/lib/http_chunks.c:159: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/http_chunks.c:159: dead_error_condition: The condition "result" cannot be true.
@@ -338,7 +338,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def25] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def25] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/http_proxy.c:413: assignment: Assigning: "result" = "((void)data) , CURLE_OK".
curl-7.60.0/lib/http_proxy.c:416: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/http_proxy.c:416: dead_error_condition: The condition "result" cannot be true.
@@ -349,7 +349,7 @@ List of Defects
-Error: CLANG_WARNING: [#def26] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def26] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/multi.c: internal warning: child 32119 timed out after 30s
Error: FORWARD_NULL (CWE-476): [#def27]
@@ -698,7 +698,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def30] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def30] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/sendf.c:441: assignment: Assigning: "nread" = "0L".
curl-7.60.0/lib/sendf.c:442: const: At condition "nread > 0L", the value of "nread" must be equal to 0.
curl-7.60.0/lib/sendf.c:442: dead_error_condition: The condition "nread > 0L" cannot be true.
@@ -709,7 +709,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def31] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def31] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/sendf.c:657: assignment: Assigning: "result" = "((void)data) , CURLE_OK".
curl-7.60.0/lib/sendf.c:659: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/sendf.c:659: dead_error_condition: The condition "result" cannot be true.
@@ -720,7 +720,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def32] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def32] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/smb.c:734: assignment: Assigning: "next_state" = "SMB_DONE".
curl-7.60.0/lib/smb.c:773: assignment: Assigning: "next_state" = "SMB_OPEN".
curl-7.60.0/lib/smb.c:779: assignment: Assigning: "next_state" = "SMB_TREE_DISCONNECT".
@@ -768,7 +768,7 @@ List of Defects
-Error: CLANG_WARNING: [#def35] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def35] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/ssh-libssh.c:1116:15: warning: Null pointer passed as an argument to a 'nonnull' parameter
@@ -918,7 +918,7 @@ List of Defects
-Error: CLANG_WARNING: [#def36] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def36] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/ssh-libssh.c:1208:10: warning: Null pointer passed as an argument to a 'nonnull' parameter
@@ -1037,7 +1037,7 @@ List of Defects
-Error: FORWARD_NULL (CWE-476): [#def37] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: FORWARD_NULL (CWE-476): [#def37] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/src/tool_getparam.c:2140: cond_true: Condition "i < argc", taking true branch.
curl-7.60.0/src/tool_getparam.c:2140: cond_true: Condition "!result", taking true branch.
curl-7.60.0/src/tool_getparam.c:2143: cond_true: Condition "stillflags", taking true branch.
@@ -1188,7 +1188,7 @@ List of Defects
-Error: NEGATIVE_RETURNS (CWE-394): [#def39] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: NEGATIVE_RETURNS (CWE-394): [#def39] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/transfer.c:131: cond_true: Condition "data->req.upload_chunky", taking true branch.
curl-7.60.0/lib/transfer.c:144: cond_false: Condition "nread == 268435456", taking false branch.
curl-7.60.0/lib/transfer.c:148: if_end: End of if statement.
@@ -1217,13 +1217,13 @@ List of Defects
-Error: CLANG_WARNING: [#def40] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def40] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/url.c: internal warning: child 19172 timed out after 30s
-Error: CLANG_WARNING: [#def41] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: CLANG_WARNING: [#def41] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/url.c: internal warning: child 31100 timed out after 30s
-Error: NEGATIVE_RETURNS (CWE-394): [#def42] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: NEGATIVE_RETURNS (CWE-394): [#def42] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vauth/ntlm.c:541: cond_true: Condition "!user", taking true branch.
curl-7.60.0/lib/vauth/ntlm.c:544: cond_false: Condition "user", taking false branch.
curl-7.60.0/lib/vauth/ntlm.c:550: else_branch: Reached else branch.
@@ -1266,7 +1266,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def43] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def43] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vauth/ntlm.c:833: assignment: Assigning: "result" = "((void)data) , CURLE_OK".
curl-7.60.0/lib/vauth/ntlm.c:835: const: At condition "result", the value of "result" must be equal to 0.
curl-7.60.0/lib/vauth/ntlm.c:835: dead_error_condition: The condition "result" cannot be true.
@@ -1277,7 +1277,7 @@ List of Defects
-Error: COMPILER_WARNING: [#def44] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: COMPILER_WARNING: [#def44] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vtls/openssl.c: scope_hint: In function 'ossl_connect_step1'
curl-7.60.0/lib/vtls/openssl.c:2217:5: warning[-Wdeprecated-declarations]: 'SSLv3_client_method' is deprecated
@@ -1295,7 +1295,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def45] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def45] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vtls/openssl.c:2214: cond_cannot_single: Condition "ssl_authtype == CURL_TLSAUTH_SRP", taking false branch. Now the value of "ssl_authtype" cannot be equal to 1.
curl-7.60.0/lib/vtls/openssl.c:2309: cannot_single: At condition "ssl_authtype == CURL_TLSAUTH_SRP", the value of "ssl_authtype" cannot be equal to 1.
curl-7.60.0/lib/vtls/openssl.c:2309: dead_error_condition: The condition "ssl_authtype == CURL_TLSAUTH_SRP" cannot be true.
@@ -1306,7 +1306,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def46] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def46] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vtls/openssl.c:2181: equality_cond: Jumping to case "CURL_SSLVERSION_DEFAULT".
curl-7.60.0/lib/vtls/openssl.c:2182: equality_cond: Jumping to case "CURL_SSLVERSION_TLSv1".
curl-7.60.0/lib/vtls/openssl.c:2183: equality_cond: Jumping to case "CURL_SSLVERSION_TLSv1_0".
@@ -1323,7 +1323,7 @@ List of Defects
-Error: DEADCODE (CWE-561): [#def47] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: DEADCODE (CWE-561): [#def47] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/lib/vtls/openssl.c:2181: equality_cond: Jumping to case "CURL_SSLVERSION_DEFAULT".
curl-7.60.0/lib/vtls/openssl.c:2182: equality_cond: Jumping to case "CURL_SSLVERSION_TLSv1".
curl-7.60.0/lib/vtls/openssl.c:2183: equality_cond: Jumping to case "CURL_SSLVERSION_TLSv1_0".
@@ -1359,7 +1359,7 @@ List of Defects
-Error: COPY_PASTE_ERROR (CWE-398): [#def49] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: COPY_PASTE_ERROR (CWE-398): [#def49] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/tests/python_dependencies/impacket/ntlm.py:595: original: "user.decode" looks like the original copy.
curl-7.60.0/tests/python_dependencies/impacket/ntlm.py:603: copy_paste_error: "user" in "user.decode" looks like a copy-paste error.
curl-7.60.0/tests/python_dependencies/impacket/ntlm.py:603: remediation: Should it say "domain" instead?
@@ -1369,7 +1369,7 @@ List of Defects
-Error: FORWARD_NULL (CWE-476): [#def50] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: FORWARD_NULL (CWE-476): [#def50] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/tests/python_dependencies/impacket/smb.py:3504: assign_undefined: Assigning: "readAndX" = "undefined".
curl-7.60.0/tests/python_dependencies/impacket/smb.py:3504: cond_true: Condition "!max_size", taking true branch.
curl-7.60.0/tests/python_dependencies/impacket/smb.py:3505: cond_true: Condition "self._dialects_parameters["Capabilities"] & SMB.CAP_LARGE_READX", taking true branch.
@@ -1391,7 +1391,7 @@ List of Defects
-Error: IDENTICAL_BRANCHES: [#def51] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: IDENTICAL_BRANCHES: [#def51] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/tests/python_dependencies/impacket/smb.py:3775: identical_branches: Ternary expression on condition "self.__flags2 & SMB.FLAGS2_UNICODE" has identical then and else expressions: """". Should one of the expressions be modified, or the entire ternary expression replaced?
@@ -1399,7 +1399,7 @@ List of Defects
-Error: IDENTICAL_BRANCHES: [#def52] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: IDENTICAL_BRANCHES: [#def52] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/tests/python_dependencies/impacket/smb.py:3818: identical_branches: Ternary expression on condition "self.__flags2 & SMB.FLAGS2_UNICODE" has identical then and else expressions: """". Should one of the expressions be modified, or the entire ternary expression replaced?
@@ -1407,7 +1407,7 @@ List of Defects
-Error: FORWARD_NULL (CWE-476): [#def53] [warning: defect not occurring in curl-7.29.0-46.el7]
+Error: FORWARD_NULL (CWE-476): [#def53] [warning: finding not occurring in curl-7.29.0-46.el7]
curl-7.60.0/tests/python_dependencies/impacket/smbserver.py:2066: assign_undefined: Assigning: "mode" = "undefined".
curl-7.60.0/tests/python_dependencies/impacket/smbserver.py:2077: cond_false: Condition "connData["ConnectedShares"].has_key(recvPacket["Tid"])", taking false branch.
curl-7.60.0/tests/python_dependencies/impacket/smbserver.py:2085: else_branch: Reached else branch.
diff --git a/tests/cshtml/0002-cwe-names/scan-results.html b/tests/cshtml/0002-cwe-names/scan-results.html
index ce33e69a..33936cf1 100644
--- a/tests/cshtml/0002-cwe-names/scan-results.html
+++ b/tests/cshtml/0002-cwe-names/scan-results.html
@@ -10,7 +10,7 @@
.infoEvent { color:#808080; }
.infoEventComment { color:#00C0C0; }
.traceEvent { color: #C0C0C0; }
- .newDefect { color: #00FF00; }
+ .newFinding { color: #00FF00; }
.parseWarning { color: #FF0000; }
.impFlag { color: #FF0000; font-weight: bold; }
#scanProps { font-family: monospace; }
@@ -20,7 +20,7 @@
curl-7.60.0-1.el8+7
-List of Defects
+List of Findings
Error: SHELLCHECK_WARNING: [#def1]
/usr/bin/curl-config:25:1: warning[SC2034]: exec_prefix appears unused. Verify it or export it.