Allow get_loaded_model to succeed when $LOAD_PATH contains non-string values#848
Merged
ctran merged 1 commit intoctran:developfrom May 10, 2021
Merged
Allow get_loaded_model to succeed when $LOAD_PATH contains non-string values#848ctran merged 1 commit intoctran:developfrom
get_loaded_model to succeed when $LOAD_PATH contains non-string values#848ctran merged 1 commit intoctran:developfrom
Conversation
…ring values
As currently implemented, `get_loaded_model` inspects the `$LOAD_PATH` global for path values when trying to find the path for a model file. This would be fine, except that variable is affected by userspace, which means that it will sometimes contain non-string values, often Pathnames. To avoid responding with the error `Unable to annotate #{model_path}: no implicit conversion of Pathname into String` in this situation, we simply add an explicit `to_s` call before performing string-specific operations.
Fixes ctran#758
Merged
8 tasks
|
@ctran any news on this one? |
Owner
|
Thanks! |
ocarta-l
pushed a commit
to ocarta-l/annotate_models
that referenced
this pull request
Jun 18, 2021
…ring values (ctran#848) As currently implemented, `get_loaded_model` inspects the `$LOAD_PATH` global for path values when trying to find the path for a model file. This would be fine, except that variable is affected by userspace, which means that it will sometimes contain non-string values, often Pathnames. To avoid responding with the error `Unable to annotate #{model_path}: no implicit conversion of Pathname into String` in this situation, we simply add an explicit `to_s` call before performing string-specific operations. Fixes ctran#758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As currently implemented,
get_loaded_modelinspects the$LOAD_PATHglobal for path values when trying to find the path for a model file. This would be fine, except that variable is affected by userspace, which means that it will sometimes contain non-string values, often Pathnames. To avoid responding with the errorUnable to annotate #{model_path}: no implicit conversion of Pathname into Stringin this situation, we simply add an explicitto_scall before performing string-specific operations.Thanks to @a0s for doing the investigation here, and identifying exactly what needed to be changed in order to resolve this issue!
Fixes #758