From ab1324bd38c27fcb1bbd3ce25a33adf4f248ae43 Mon Sep 17 00:00:00 2001 From: birkholz-cubert Date: Wed, 13 Aug 2025 10:18:52 +0200 Subject: [PATCH 1/3] pass by const ref instead of pointer --- interface/cuvis.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interface/cuvis.hpp b/interface/cuvis.hpp index ea44a99..7599ada 100644 --- a/interface/cuvis.hpp +++ b/interface/cuvis.hpp @@ -1490,7 +1490,7 @@ namespace cuvis void set_exporter(Exporter const* exporter); void set_viewer(Viewer const* viewer); - void ingest_measurement(Measurement const* measurement); + void ingest_measurement(Measurement const& measurement); void ingest_session_file(SessionFile const* session, std::string frame_selection); double query_session_progress(); @@ -2168,7 +2168,7 @@ namespace cuvis return {std::move(mesu), view, except}; } - inline void Worker::ingest_measurement(Measurement const* measurement) { chk(cuvis_worker_ingest_mesu(*_worker, *measurement->_mesu)); } + inline void Worker::ingest_measurement(Measurement const& measurement) { chk(cuvis_worker_ingest_mesu(*_worker, *measurement._mesu)); } inline void Worker::start_processing() { chk(cuvis_worker_start(*_worker)); } From 05971b5fc09333141c077966c46ae845c5a144ac Mon Sep 17 00:00:00 2001 From: birkholz-cubert Date: Wed, 13 Aug 2025 10:29:49 +0200 Subject: [PATCH 2/3] changed ingest_session_file to const ref --- interface/cuvis.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/interface/cuvis.hpp b/interface/cuvis.hpp index 7599ada..4aac9c5 100644 --- a/interface/cuvis.hpp +++ b/interface/cuvis.hpp @@ -1491,7 +1491,7 @@ namespace cuvis void set_viewer(Viewer const* viewer); void ingest_measurement(Measurement const& measurement); - void ingest_session_file(SessionFile const* session, std::string frame_selection); + void ingest_session_file(SessionFile const& session, std::string frame_selection); double query_session_progress(); bool get_can_drop_results(); @@ -2024,11 +2024,11 @@ namespace cuvis } } - inline void Worker::ingest_session_file(SessionFile const* session, std::string frame_selection) + inline void Worker::ingest_session_file(SessionFile const& session, std::string frame_selection) { if (session != nullptr) { - chk(cuvis_worker_ingest_session_file(*_worker, *session->_session, frame_selection.c_str())); + chk(cuvis_worker_ingest_session_file(*_worker, *session._session, frame_selection.c_str())); } } From e6d4df76093c2d801e24fbe3ac50ea1f87365520 Mon Sep 17 00:00:00 2001 From: birkholz-cubert Date: Wed, 13 Aug 2025 10:31:36 +0200 Subject: [PATCH 3/3] removed nullptr check --- interface/cuvis.hpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/interface/cuvis.hpp b/interface/cuvis.hpp index 4aac9c5..89ba8ea 100644 --- a/interface/cuvis.hpp +++ b/interface/cuvis.hpp @@ -2026,10 +2026,7 @@ namespace cuvis inline void Worker::ingest_session_file(SessionFile const& session, std::string frame_selection) { - if (session != nullptr) - { - chk(cuvis_worker_ingest_session_file(*_worker, *session._session, frame_selection.c_str())); - } + chk(cuvis_worker_ingest_session_file(*_worker, *session._session, frame_selection.c_str())); } inline double Worker::query_session_progress()