From 39ab87d5b88090a9f5a3c3918eb5f51cc43f8d06 Mon Sep 17 00:00:00 2001 From: Michael Sherron Date: Wed, 12 Aug 2015 16:35:23 -0700 Subject: [PATCH 1/3] added administer advanced addthis settings permission and updated addthis router file to use new permissions --- addthis.permissions.yml | 5 ++++- addthis.routing.yml | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/addthis.permissions.yml b/addthis.permissions.yml index 71b5863..dbd85af 100644 --- a/addthis.permissions.yml +++ b/addthis.permissions.yml @@ -1,3 +1,6 @@ -administer advanced addthis: +administer addthis settings: + title: 'Administer AddThis Settings' + description: 'Perform configuration tasks for AddThis.' +administer advanced addthis settings: title: 'Administer Advanced AddThis Settings' description: 'Perform advanced configuration tasks for AddThis.' \ No newline at end of file diff --git a/addthis.routing.yml b/addthis.routing.yml index 3c87c80..825b5db 100644 --- a/addthis.routing.yml +++ b/addthis.routing.yml @@ -4,11 +4,11 @@ addthis.settings: _form: '\Drupal\addthis\Form\AddThisSettingsForm' _title: 'AddThis' requirements: - _permission: 'administer site configuration' + _permission: 'administer addthis settings' addthis.settings.advanced: path: '/admin/config/user-interface/addthis/advanced' defaults: _form: '\Drupal\addthis\Form\AddThisSettingsAdvancedForm' _title: 'AddThis Advanced Settings' requirements: - _permission: 'administer site configuration' \ No newline at end of file + _permission: 'administer advanced addthis settings' \ No newline at end of file From 17fae772f784ac054735461dff0baec2ba824f37 Mon Sep 17 00:00:00 2001 From: Michael Sherron Date: Wed, 12 Aug 2015 17:09:35 -0700 Subject: [PATCH 2/3] Creating local task file for tabbed navigation of config menus, also fixing broken advanced menu link and enforcing weight --- addthis.links.menu.yml | 12 +++++++----- addthis.links.task.yml | 8 ++++++++ 2 files changed, 15 insertions(+), 5 deletions(-) create mode 100644 addthis.links.task.yml diff --git a/addthis.links.menu.yml b/addthis.links.menu.yml index af1781e..86a6d3a 100644 --- a/addthis.links.menu.yml +++ b/addthis.links.menu.yml @@ -1,10 +1,12 @@ addthis.settings: - title: AddThis + title: AddThis - Basic Settings description: 'Manage your site''s AddThis settings.' parent: system.admin_config_ui route_name: addthis.settings + weight: 1 addthis.settings.advanced: - title: AddThis - description: 'Manage your site''s Advanced AddThis settings.' - parent: addthis.settings - route_name: addthis.settings.advanced \ No newline at end of file + title: AddThis - Advanced Settings + description: 'Manage your site''s advanced AddThis settings.' + parent: system.admin_config_ui + route_name: addthis.settings.advanced + weight: 2 \ No newline at end of file diff --git a/addthis.links.task.yml b/addthis.links.task.yml new file mode 100644 index 0000000..bd96cb5 --- /dev/null +++ b/addthis.links.task.yml @@ -0,0 +1,8 @@ +addthis.settings: + title: 'Basic' + route_name: addthis.settings + base_route: addthis.settings +addthis.settings.advanced: + title: 'Advanced' + route_name: addthis.settings.advanced + base_route: addthis.settings \ No newline at end of file From 0418a67f9c0188ba52cac7929b4aba9d6c38d4c0 Mon Sep 17 00:00:00 2001 From: Michael Sherron Date: Wed, 12 Aug 2015 17:16:20 -0700 Subject: [PATCH 3/3] Revert "Creating local task file for tabbed navigation of config menus, also fixing broken advanced menu link and enforcing weight" This reverts commit 17fae772f784ac054735461dff0baec2ba824f37. --- addthis.links.menu.yml | 12 +++++------- addthis.links.task.yml | 8 -------- 2 files changed, 5 insertions(+), 15 deletions(-) delete mode 100644 addthis.links.task.yml diff --git a/addthis.links.menu.yml b/addthis.links.menu.yml index 86a6d3a..af1781e 100644 --- a/addthis.links.menu.yml +++ b/addthis.links.menu.yml @@ -1,12 +1,10 @@ addthis.settings: - title: AddThis - Basic Settings + title: AddThis description: 'Manage your site''s AddThis settings.' parent: system.admin_config_ui route_name: addthis.settings - weight: 1 addthis.settings.advanced: - title: AddThis - Advanced Settings - description: 'Manage your site''s advanced AddThis settings.' - parent: system.admin_config_ui - route_name: addthis.settings.advanced - weight: 2 \ No newline at end of file + title: AddThis + description: 'Manage your site''s Advanced AddThis settings.' + parent: addthis.settings + route_name: addthis.settings.advanced \ No newline at end of file diff --git a/addthis.links.task.yml b/addthis.links.task.yml deleted file mode 100644 index bd96cb5..0000000 --- a/addthis.links.task.yml +++ /dev/null @@ -1,8 +0,0 @@ -addthis.settings: - title: 'Basic' - route_name: addthis.settings - base_route: addthis.settings -addthis.settings.advanced: - title: 'Advanced' - route_name: addthis.settings.advanced - base_route: addthis.settings \ No newline at end of file