Skip to content

Commit 44f3d55

Browse files
Vladimir Zapolskiydavem330
authored andcommitted
ravb: remove custom .set_link_ksettings from ethtool ops
The generic phy_ethtool_set_link_ksettings() function from phylib can be used instead of in-house ravb_set_link_ksettings(). Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 468e40b commit 44f3d55

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,15 +1106,6 @@ static int ravb_phy_start(struct net_device *ndev)
11061106
return 0;
11071107
}
11081108

1109-
static int ravb_set_link_ksettings(struct net_device *ndev,
1110-
const struct ethtool_link_ksettings *cmd)
1111-
{
1112-
if (!ndev->phydev)
1113-
return -ENODEV;
1114-
1115-
return phy_ethtool_ksettings_set(ndev->phydev, cmd);
1116-
}
1117-
11181109
static u32 ravb_get_msglevel(struct net_device *ndev)
11191110
{
11201111
struct ravb_private *priv = netdev_priv(ndev);
@@ -1338,7 +1329,7 @@ static const struct ethtool_ops ravb_ethtool_ops = {
13381329
.set_ringparam = ravb_set_ringparam,
13391330
.get_ts_info = ravb_get_ts_info,
13401331
.get_link_ksettings = phy_ethtool_get_link_ksettings,
1341-
.set_link_ksettings = ravb_set_link_ksettings,
1332+
.set_link_ksettings = phy_ethtool_set_link_ksettings,
13421333
.get_wol = ravb_get_wol,
13431334
.set_wol = ravb_set_wol,
13441335
};

0 commit comments

Comments
 (0)