From 951a294518d9ecc89dd1c35fca9bdf2642d79026 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Wed, 24 Jun 2020 02:47:29 +0200 Subject: [PATCH 1/7] qt: Add more placeholder in ReceiveCoinsDialog --- src/qt/receivecoinsdialog.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qt/receivecoinsdialog.cpp b/src/qt/receivecoinsdialog.cpp index 083ae3c1075d..2ec482a90bb4 100644 --- a/src/qt/receivecoinsdialog.cpp +++ b/src/qt/receivecoinsdialog.cpp @@ -32,6 +32,9 @@ ReceiveCoinsDialog::ReceiveCoinsDialog(QWidget* parent) : ui->label_2, ui->label_3}, GUIUtil::FontWeight::Normal, 15); + ui->reqLabel->setPlaceholderText(tr("Enter a label for this request to add its address to your address book")); + ui->reqMessage->setPlaceholderText(tr("Enter a message which gets added to this request.")); + // context menu actions QAction *copyURIAction = new QAction(tr("Copy URI"), this); QAction *copyLabelAction = new QAction(tr("Copy label"), this); From b46e6df4ecface493a8566935b375d5ca4698b80 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Wed, 24 Jun 2020 02:54:37 +0200 Subject: [PATCH 2/7] qt: Add placeholder for filter line edit in MasternodeList --- src/qt/masternodelist.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qt/masternodelist.cpp b/src/qt/masternodelist.cpp index 7ccbaa0721d6..592c4abc2591 100644 --- a/src/qt/masternodelist.cpp +++ b/src/qt/masternodelist.cpp @@ -77,6 +77,8 @@ MasternodeList::MasternodeList(QWidget* parent) : ui->tableWidgetMasternodesDIP3->setContextMenuPolicy(Qt::CustomContextMenu); + ui->filterLineEditDIP3->setPlaceholderText(tr("Filter by any property (e.g. address or protx hash)")); + QAction* copyProTxHashAction = new QAction(tr("Copy ProTx Hash"), this); QAction* copyCollateralOutpointAction = new QAction(tr("Copy Collateral Outpoint"), this); contextMenuDIP3 = new QMenu(this); From a0075524abe9f399e158f231f938553b7bee2b50 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Wed, 24 Jun 2020 03:12:25 +0200 Subject: [PATCH 3/7] qt: Add more placerholder in SignVerifyMessageDialog --- src/qt/signverifymessagedialog.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qt/signverifymessagedialog.cpp b/src/qt/signverifymessagedialog.cpp index 5b784a40e4e1..32f09f5769a6 100644 --- a/src/qt/signverifymessagedialog.cpp +++ b/src/qt/signverifymessagedialog.cpp @@ -31,8 +31,13 @@ SignVerifyMessageDialog::SignVerifyMessageDialog(QWidget* parent) : pageButtons.addButton(ui->btnVerifyMessage, pageButtons.buttons().size()); connect(&pageButtons, SIGNAL(buttonClicked(int)), this, SLOT(showPage(int))); + ui->messageIn_SM->setPlaceholderText(tr("Enter a message to be signed")); ui->signatureOut_SM->setPlaceholderText(tr("Click \"Sign Message\" to generate signature")); + ui->messageIn_VM->setPlaceholderText(tr("Enter a message to be verified")); + ui->signatureIn_VM->setPlaceholderText(tr("Enter a signature to be verified")); + + // These icons are needed on Mac also ui->addressBookButton_SM->setIcon(QIcon(":/icons/address-book")); ui->pasteButton_SM->setIcon(QIcon(":/icons/editpaste")); ui->copySignatureButton_SM->setIcon(QIcon(":/icons/editcopy")); From 2e1d2ddb387eaf60e32dbdb554eca27a447201fa Mon Sep 17 00:00:00 2001 From: xdustinface Date: Wed, 22 Jul 2020 04:00:36 +0200 Subject: [PATCH 4/7] qt: Removes a dot --- src/qt/receivecoinsdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qt/receivecoinsdialog.cpp b/src/qt/receivecoinsdialog.cpp index 2ec482a90bb4..ca0748e70fac 100644 --- a/src/qt/receivecoinsdialog.cpp +++ b/src/qt/receivecoinsdialog.cpp @@ -33,7 +33,7 @@ ReceiveCoinsDialog::ReceiveCoinsDialog(QWidget* parent) : ui->label_3}, GUIUtil::FontWeight::Normal, 15); ui->reqLabel->setPlaceholderText(tr("Enter a label for this request to add its address to your address book")); - ui->reqMessage->setPlaceholderText(tr("Enter a message which gets added to this request.")); + ui->reqMessage->setPlaceholderText(tr("Enter a message which gets added to this request")); // context menu actions QAction *copyURIAction = new QAction(tr("Copy URI"), this); From d7f947b6f78a0700fdb6411a3e0b349e5f5df457 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Wed, 22 Jul 2020 15:38:20 +0200 Subject: [PATCH 5/7] qt: Adjust placeholder phrasing in ReceiveCoinsDialog --- src/qt/receivecoinsdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qt/receivecoinsdialog.cpp b/src/qt/receivecoinsdialog.cpp index ca0748e70fac..6e0ca0710ffe 100644 --- a/src/qt/receivecoinsdialog.cpp +++ b/src/qt/receivecoinsdialog.cpp @@ -32,7 +32,7 @@ ReceiveCoinsDialog::ReceiveCoinsDialog(QWidget* parent) : ui->label_2, ui->label_3}, GUIUtil::FontWeight::Normal, 15); - ui->reqLabel->setPlaceholderText(tr("Enter a label for this request to add its address to your address book")); + ui->reqLabel->setPlaceholderText(tr("Enter a label which gets assigned to the generated address in your address book")); ui->reqMessage->setPlaceholderText(tr("Enter a message which gets added to this request")); // context menu actions From 17c951dfa525144771aee851980f29510e45acb8 Mon Sep 17 00:00:00 2001 From: dustinface <35775977+xdustinface@users.noreply.github.com> Date: Wed, 22 Jul 2020 15:39:25 +0200 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: UdjinM6 --- src/qt/signverifymessagedialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qt/signverifymessagedialog.cpp b/src/qt/signverifymessagedialog.cpp index 32f09f5769a6..f94c91e89575 100644 --- a/src/qt/signverifymessagedialog.cpp +++ b/src/qt/signverifymessagedialog.cpp @@ -35,7 +35,7 @@ SignVerifyMessageDialog::SignVerifyMessageDialog(QWidget* parent) : ui->signatureOut_SM->setPlaceholderText(tr("Click \"Sign Message\" to generate signature")); ui->messageIn_VM->setPlaceholderText(tr("Enter a message to be verified")); - ui->signatureIn_VM->setPlaceholderText(tr("Enter a signature to be verified")); + ui->signatureIn_VM->setPlaceholderText(tr("Enter a signature for the message to be verified")); // These icons are needed on Mac also ui->addressBookButton_SM->setIcon(QIcon(":/icons/address-book")); From 742f94df7ed876b1189c856f973f7657567e2175 Mon Sep 17 00:00:00 2001 From: xdustinface Date: Thu, 23 Jul 2020 15:35:16 +0200 Subject: [PATCH 7/7] qt: Align wording of placeholders with the corresponding tooltip --- src/qt/receivecoinsdialog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qt/receivecoinsdialog.cpp b/src/qt/receivecoinsdialog.cpp index 6e0ca0710ffe..c635a6a6708f 100644 --- a/src/qt/receivecoinsdialog.cpp +++ b/src/qt/receivecoinsdialog.cpp @@ -32,8 +32,8 @@ ReceiveCoinsDialog::ReceiveCoinsDialog(QWidget* parent) : ui->label_2, ui->label_3}, GUIUtil::FontWeight::Normal, 15); - ui->reqLabel->setPlaceholderText(tr("Enter a label which gets assigned to the generated address in your address book")); - ui->reqMessage->setPlaceholderText(tr("Enter a message which gets added to this request")); + ui->reqLabel->setPlaceholderText(tr("Enter a label to associate with the new receiving address")); + ui->reqMessage->setPlaceholderText(tr("Enter a message to attach to the payment request")); // context menu actions QAction *copyURIAction = new QAction(tr("Copy URI"), this);