From b389d0bba3cf0c3f1766def00818011c84df88a7 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Thu, 3 Jul 2025 01:57:21 +0700 Subject: [PATCH 1/2] refactor: drop several circular dependencies by removing unused headers These unused headers has been found by running iwyu linter --- src/logging.cpp | 1 - src/qt/guiutil.cpp | 1 - src/wallet/wallet.cpp | 1 - test/lint/lint-circular-dependencies.py | 9 --------- 4 files changed, 12 deletions(-) diff --git a/src/logging.cpp b/src/logging.cpp index da099cc1cebb..2d98525a3a2a 100644 --- a/src/logging.cpp +++ b/src/logging.cpp @@ -6,7 +6,6 @@ #include #include #include -#include #include #include diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp index a462726a5f33..1fcc3ca040d0 100644 --- a/src/qt/guiutil.cpp +++ b/src/qt/guiutil.cpp @@ -9,7 +9,6 @@ #include #include #include -#include #include #include diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index eafb8a6cdd3e..6979c5d49fae 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -42,7 +42,6 @@ #include #include #include -#include #include #include diff --git a/test/lint/lint-circular-dependencies.py b/test/lint/lint-circular-dependencies.py index 723aaf239545..aa60522a8c69 100755 --- a/test/lint/lint-circular-dependencies.py +++ b/test/lint/lint-circular-dependencies.py @@ -19,7 +19,6 @@ "qt/addresstablemodel -> qt/walletmodel -> qt/addresstablemodel", "qt/recentrequeststablemodel -> qt/walletmodel -> qt/recentrequeststablemodel", "qt/transactiontablemodel -> qt/walletmodel -> qt/transactiontablemodel", - "wallet/fees -> wallet/wallet -> wallet/fees", "wallet/wallet -> wallet/walletdb -> wallet/wallet", "node/coinstats -> validation -> node/coinstats", # Dash @@ -59,21 +58,13 @@ "llmq/signing -> llmq/signing_shares -> llmq/signing", "llmq/signing -> net_processing -> llmq/signing", "llmq/signing_shares -> net_processing -> llmq/signing_shares", - "logging -> util/system -> logging", - "logging -> util/system -> stacktraces -> logging", - "logging -> util/system -> sync -> logging", - "logging -> util/system -> sync -> logging/timer -> logging", - "logging -> util/system -> util/getuniquepath -> random -> logging", "masternode/payments -> validation -> masternode/payments", "net -> netmessagemaker -> net", "net_processing -> spork -> net_processing", "netaddress -> netbase -> netaddress", "qt/appearancewidget -> qt/guiutil -> qt/appearancewidget", - "qt/appearancewidget -> qt/guiutil -> qt/optionsdialog -> qt/appearancewidget", "qt/bitcoinaddressvalidator -> qt/guiutil -> qt/bitcoinaddressvalidator", "qt/bitcoingui -> qt/guiutil -> qt/bitcoingui", - "qt/guiutil -> qt/optionsdialog -> qt/guiutil", - "qt/guiutil -> qt/optionsdialog -> qt/optionsmodel -> qt/guiutil", "qt/guiutil -> qt/qvalidatedlineedit -> qt/guiutil", "wallet/coinjoin -> wallet/receive -> wallet/coinjoin", ) From 9aa039c3ca3dc1fc7ce4732b2ea7d1c2f5569926 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Thu, 3 Jul 2025 02:35:56 +0700 Subject: [PATCH 2/2] refactor: removed multiple unused includes; added some must-have headers It improves compilation time insignificantly (1minute out of 98minutes, assuming 1 core compilation, 1% improvement) --- src/bls/bls_worker.cpp | 1 - src/coinjoin/client.cpp | 4 +--- src/coinjoin/coinjoin.cpp | 4 ---- src/coinjoin/interfaces.cpp | 3 --- src/coinjoin/server.cpp | 2 -- src/coinjoin/util.cpp | 2 -- src/dsnotificationinterface.cpp | 2 -- src/evo/chainhelper.cpp | 2 +- src/evo/deterministicmns.cpp | 1 - src/evo/dmnstate.cpp | 4 ---- src/evo/mnauth.cpp | 3 --- src/evo/mnauth.h | 3 +++ src/evo/simplifiedmns.cpp | 1 - src/evo/specialtxman.cpp | 2 -- src/governance/classes.cpp | 5 ----- src/governance/classes.h | 4 ++++ src/governance/common.cpp | 1 - src/governance/exceptions.cpp | 1 - src/governance/governance.cpp | 1 - src/governance/object.cpp | 1 - src/governance/vote.cpp | 7 ++----- src/llmq/chainlocks.cpp | 6 ++---- src/llmq/commitment.h | 1 + src/llmq/context.cpp | 6 ++---- src/llmq/dkgsession.cpp | 7 ++----- src/llmq/dkgsessionmgr.cpp | 1 - src/llmq/ehf_signals.cpp | 5 +---- src/llmq/quorums.cpp | 10 ++++------ src/llmq/signing.cpp | 4 ---- src/llmq/snapshot.cpp | 7 +------ src/llmq/utils.cpp | 2 +- src/masternode/meta.cpp | 2 -- src/masternode/node.cpp | 2 -- src/masternode/payments.cpp | 1 - src/masternode/sync.cpp | 2 -- src/masternode/utils.cpp | 1 - src/netfulfilledman.cpp | 1 - src/qt/governancelist.cpp | 3 --- src/qt/masternodelist.cpp | 2 -- src/rpc/coinjoin.cpp | 3 --- src/rpc/evo.cpp | 6 ------ src/rpc/governance.cpp | 4 ---- src/rpc/masternode.cpp | 5 ----- src/rpc/quorums.cpp | 1 - src/saltedhasher.cpp | 2 -- src/spork.cpp | 2 -- src/stats/client.cpp | 2 +- src/test/block_reward_reallocation_tests.cpp | 3 --- src/test/dynamic_activation_thresholds_tests.cpp | 3 --- src/test/evo_deterministicmns_tests.cpp | 3 --- src/test/evo_mnhf_tests.cpp | 1 - src/test/evo_utils_tests.cpp | 5 +---- src/wallet/hdchain.cpp | 1 - 53 files changed, 27 insertions(+), 131 deletions(-) diff --git a/src/bls/bls_worker.cpp b/src/bls/bls_worker.cpp index 31f657320569..8041d14fc511 100644 --- a/src/bls/bls_worker.cpp +++ b/src/bls/bls_worker.cpp @@ -4,7 +4,6 @@ #include #include -#include #include #include diff --git a/src/coinjoin/client.cpp b/src/coinjoin/client.cpp index 9eab45fb862f..35593152c8b2 100644 --- a/src/coinjoin/client.cpp +++ b/src/coinjoin/client.cpp @@ -7,7 +7,6 @@ #include #include #include -#include #include #include #include @@ -25,10 +24,9 @@ #include #include #include -#include +#include #include #include -#include #include #include diff --git a/src/coinjoin/coinjoin.cpp b/src/coinjoin/coinjoin.cpp index 698d53e71859..641a1e7c02d3 100644 --- a/src/coinjoin/coinjoin.cpp +++ b/src/coinjoin/coinjoin.cpp @@ -7,14 +7,10 @@ #include #include #include -#include -#include #include #include #include #include -#include -#include #include #include #include diff --git a/src/coinjoin/interfaces.cpp b/src/coinjoin/interfaces.cpp index a434d023a801..98091b694c12 100644 --- a/src/coinjoin/interfaces.cpp +++ b/src/coinjoin/interfaces.cpp @@ -9,11 +9,8 @@ #include #include #include -#include #include -#include - #include #include diff --git a/src/coinjoin/server.cpp b/src/coinjoin/server.cpp index 01a8266916ee..a90df185ef1a 100644 --- a/src/coinjoin/server.cpp +++ b/src/coinjoin/server.cpp @@ -4,7 +4,6 @@ #include -#include #include #include #include @@ -21,7 +20,6 @@ #include #include #include -#include #include diff --git a/src/coinjoin/util.cpp b/src/coinjoin/util.cpp index 647793c87fac..7b777c0311b8 100644 --- a/src/coinjoin/util.cpp +++ b/src/coinjoin/util.cpp @@ -3,10 +3,8 @@ // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include -#include #include #include -#include