From 75d54fc0501c0051b0df4d464af58405b8613e43 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 25 Jul 2023 16:15:34 +0700 Subject: [PATCH 1/3] docs(dip0023): renamed version to versionBit in MnEhf Signal to avoid confusion --- dip-0023.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dip-0023.md b/dip-0023.md index 31a87baa..1719875f 100644 --- a/dip-0023.md +++ b/dip-0023.md @@ -64,7 +64,7 @@ The `mnhfsignal` message should look like: | Field | Type | Size | Description | |-|-|-|-| -| version | uint8_t | 1 | The version bits associated with the hard fork | +| versionBit | uint8_t | 1 | The version bits associated with the hard fork | | quorumHash | uint256 | 32 | Hash of the quorum signing this message | | sig | CBLSSig | 96 | BLS signature on `version` by a public key associated with the quorum referenced by `quorumHash` | From e3d3ba10600736272a9118f023411426abaa9ea0 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 25 Jul 2023 16:17:37 +0700 Subject: [PATCH 2/3] docs(dip0023): explicitely specify size of MnEHF Signal - it's not variable lenght --- dip-0023.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dip-0023.md b/dip-0023.md index 1719875f..d58ba909 100644 --- a/dip-0023.md +++ b/dip-0023.md @@ -73,7 +73,7 @@ The payload of the Masternode Hard Fork Signalling Transaction (the new special | Field | Type | Size | Description | |-|-|-|-| | version | uint_16 | 2 | Commitment special transaction version number. Currently set to 1. Please note that this is not the same as the version field of the `mnhfsignal` message | -| commitment | mnhfsignal | Variable | This equals the payload of the `mnhfsignal` P2P message +| commitment | mnhfsignal | 129 | This equals the payload of the `mnhfsignal` P2P message **Stage 2:** Once this `mnhfsignal` message has been mined, two parameters are set: `masternode_activation_height` and `min_activation_height`. The cycle beginning at From eb282b4bf128b18f235ecdca3fa82387d04f7afa Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 25 Jul 2023 16:20:32 +0700 Subject: [PATCH 3/3] docs(dip-0023): update version size from 2 bytes to only 1 - it seems enough --- dip-0023.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dip-0023.md b/dip-0023.md index d58ba909..c2a6919c 100644 --- a/dip-0023.md +++ b/dip-0023.md @@ -72,7 +72,7 @@ The payload of the Masternode Hard Fork Signalling Transaction (the new special | Field | Type | Size | Description | |-|-|-|-| -| version | uint_16 | 2 | Commitment special transaction version number. Currently set to 1. Please note that this is not the same as the version field of the `mnhfsignal` message | +| version | uint_8 | 1 | Commitment special transaction version number. Currently set to 1. Please note that this is not the same as the version field of the `mnhfsignal` message | | commitment | mnhfsignal | 129 | This equals the payload of the `mnhfsignal` P2P message **Stage 2:** Once this `mnhfsignal` message has been mined, two parameters are set: