web: setEpoch should keep orders with no epoch property#571
Merged
Conversation
Orders loaded on startup do not have an epoch property set. This changes OrderBook's setEpoch method to keep orders where the epoch property is undefined in addition to 0 or the new epochIndex.
buck54321
requested changes
Jul 28, 2020
Member
buck54321
left a comment
buck54321
left a comment
There was a problem hiding this comment.
I should have noticed back here. Really, I'd like to just make the field a uint64 again. It's not clear to me anymore why it needed to be a pointer. @JoeGruffins?
buck54321
approved these changes
Jul 28, 2020
Member
buck54321
left a comment
buck54321
left a comment
There was a problem hiding this comment.
Even if we go back to uint64, the omitempty on the field means epoch will be undefined, so this solution is still required.
Member
Author
I think the idea was to allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orders loaded on startup do not have an epoch property set. This changes
OrderBook's setEpoch method to keep orders where the epoch property is
undefined in addition to 0 or the new epochIndex.
Resolves #568 and probably #553 too