multi: handle unmatched cancel orders#600
Merged
Merged
Conversation
JoeGruffins
approved these changes
Aug 13, 2020
Member
JoeGruffins
left a comment
JoeGruffins
left a comment
There was a problem hiding this comment.
My first time noticing, so could be in master, but during the epoch of canceling, the cancel order shows up in the books, without indication of what it is. I don't think it should show up.
chappjc
reviewed
Aug 14, 2020
Member
chappjc
left a comment
chappjc
left a comment
There was a problem hiding this comment.
Code reads well, although not tested yet.
chappjc
requested changes
Aug 14, 2020
Member
chappjc
left a comment
chappjc
left a comment
There was a problem hiding this comment.
Works pretty well for the most part.
buck54321
force-pushed
the
missed-cancel
branch
from
9e0b7a7 to
f949b6d
Compare
chappjc
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nomatches.