dex/testing/dcr: update the addresses for simnet auto cointype upgrade#607
Merged
Conversation
Update the mining and transfer addresses to account for the change to dcrwallet master which always upgrades the cointype on simnet. This also makes a valid seed for the "beta" wallet.
Member
Author
Member
Author
|
Also note that your dcrdex.conf and/or dcrdex command lines should be updated to use the new reg fees xpub: https://github.com/decred/dcrdex/wiki/Simnet-Testing/_compare/596429a9567c71b5c8ab42931b2cb206d655df9c...caca653d3d1f5259e0e4481260158c42cbde2e4e |
buck54321
requested changes
Aug 17, 2020
Member
buck54321
left a comment
buck54321
left a comment
There was a problem hiding this comment.
Decred simnet test is failing with
--- FAIL: TestWallet (1.72s)
simnet_test.go:310: redemption error: -4: wallet.DumpWIFPrivateKey: item does not exist: no address with id d5303c8a454b03f2c0d7833bf09f3b14cc76cec2
Probably because the addresses here are no longer correct.
Member
Author
|
Dang, I didn't grep for everything apparently. Fixing. |
chappjc
commented
Aug 17, 2020
Comment on lines
+36
to
+37
| alphaAddress = "SsWKp7wtdTZYabYFYSc9cnxhwFEjA5g4pFc" | ||
| betaAddress = "Ssge52jCzbixgFC736RSTrwAnvH3a4hcPRX" |
Member
Author
There was a problem hiding this comment.
client/asset/dcr/simnet_test.go passing now too. Sorry I missed that one.
buck54321
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the mining and transfer addresses to account for the change to
dcrwallet master which always upgrades the cointype on simnet.
This also makes a valid seed for the "beta" wallet.
This also updates the dcrdex harness with a bew xpub from alpha's "server_fees" account.