From 9e39e847f50a74c36adb29d83084171d0c8e27bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Wolak?= Date: Fri, 4 Mar 2022 21:17:52 +0100 Subject: [PATCH 1/3] fix(angular-jss): dependencies --- README.md | 4 ++++ libs/angular-jss/package.json | 8 +++----- libs/angular-jss/src/lib/jss/utils/sheets.ts | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 0f6279f..ade23fb 100644 --- a/README.md +++ b/README.md @@ -13,6 +13,10 @@ ## Features +- [x] Component decorator `Styled` +- [x] Theming with `Theme` +- [x] Server Side Rendering with Angular Universal + ## Table of Contents - [Installation](#installation) diff --git a/libs/angular-jss/package.json b/libs/angular-jss/package.json index ee6c9ad..c7c219c 100644 --- a/libs/angular-jss/package.json +++ b/libs/angular-jss/package.json @@ -1,7 +1,7 @@ { "name": "@design4pro/angular-jss", "version": "0.0.1", - "description": "Angular for JSS", + "description": "JSS integration with Angular", "license": "MIT", "keywords": [ "angular", @@ -22,15 +22,13 @@ "url": "https://github.com/design4pro/angular-jss/issues/" }, "homepage": "https://github.com/design4pro/angular-jss#readme", - "peerDependencies": { + "dependencies": { "@angular/common": "^13.2.0", "@angular/core": "^13.2.0", "jss": "^10.9.0", "jss-plugin-camel-case": "^10.9.0", "jss-plugin-global": "^10.9.0", - "jss-plugin-rule-value-function": "^10.9.0" - }, - "dependencies": { + "jss-plugin-rule-value-function": "^10.9.0", "tslib": "^2.3.0" }, "publishConfig": { diff --git a/libs/angular-jss/src/lib/jss/utils/sheets.ts b/libs/angular-jss/src/lib/jss/utils/sheets.ts index aabadf1..d9119e2 100644 --- a/libs/angular-jss/src/lib/jss/utils/sheets.ts +++ b/libs/angular-jss/src/lib/jss/utils/sheets.ts @@ -34,7 +34,7 @@ export const getStyles = (options: Options) => { return styles; } - if (styles.length !== 0) { + if (styles.length === 0) { console.warn( `[JSS] <${ options.name || 'Hook' From f43a226e25b88652183eba115497e3f4d2681494 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Wolak?= Date: Fri, 4 Mar 2022 21:30:43 +0100 Subject: [PATCH 2/3] fix(angular-jss): dependencies --- libs/angular-jss/package.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libs/angular-jss/package.json b/libs/angular-jss/package.json index c7c219c..14a80c9 100644 --- a/libs/angular-jss/package.json +++ b/libs/angular-jss/package.json @@ -22,9 +22,11 @@ "url": "https://github.com/design4pro/angular-jss/issues/" }, "homepage": "https://github.com/design4pro/angular-jss#readme", - "dependencies": { + "peerDependencies": { "@angular/common": "^13.2.0", - "@angular/core": "^13.2.0", + "@angular/core": "^13.2.0" + }, + "dependencies": { "jss": "^10.9.0", "jss-plugin-camel-case": "^10.9.0", "jss-plugin-global": "^10.9.0", From 4f1718d8b1f783bbc1e02a11e16d72e6f25c25f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Wolak?= Date: Fri, 4 Mar 2022 21:55:35 +0100 Subject: [PATCH 3/3] fix(angular-jss): allowedNonPeerDependencies --- libs/angular-jss/ng-package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/angular-jss/ng-package.json b/libs/angular-jss/ng-package.json index d1e4a25..73d6add 100644 --- a/libs/angular-jss/ng-package.json +++ b/libs/angular-jss/ng-package.json @@ -3,5 +3,6 @@ "dest": "../../dist/libs/angular-jss", "lib": { "entryFile": "src/index.ts" - } + }, + "allowedNonPeerDependencies": ["."] }