From ffedb2e35afc939ffea9e7bd5ac1d2334984fb73 Mon Sep 17 00:00:00 2001 From: Elise Chant Date: Mon, 13 Dec 2021 16:40:43 +1100 Subject: [PATCH 1/3] Add Proposal for "Distribute CSS unminified and unprefixed" --- .../distribute-css-as-unprefixed.md | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 RFC-by-stage/1-approved/distribute-css-as-unprefixed.md diff --git a/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md new file mode 100644 index 0000000..7395241 --- /dev/null +++ b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md @@ -0,0 +1,32 @@ +--- +Status: `Proposal` # Please do not change this. +Implementer: # It will be changed upon merging and as it moves through the RFC stages +--- + +# Distribute CSS unminified and unprefixed + +## The issue to be solved + +CSS is currently being distributed as minified and vendor-prefixed assets. + +This is unnecessary since users also process styles for minification and vendor-prefixing, therefore css "as modules" should ship without being processed. This issue was raised by @liamfiddler [here](https://github.com/designsystemau/RFCs/pull/11#discussion_r724769922). + +Where users want to consume full CSS however, they may still expect the asset to be vendor prefixed and minified. This scenario might be handled better by delivering styles from a CDN like [UNPKG](https://unpkg.com/). + +This work should ship with pancake being removed [#1](https://github.com/designsystemau/RFCs/pull/1). + + +## A short description of the desired outcome or solution + +* Npm packages should contain unprocessed CSS assets +* New package "design-system" is created which provides minified + vendor-prefixed CSS **and** an unprocessed version, ie `gold.min.css` and `gold.css` +* Usage of the new package is documented + + +## Technical details + +Assuming that pancake has been removed. + +1. Create a new package "design-system", (gold-design-system/packages/design-system) to generate a full CSS +2. In the design-system package, minified + vendor-prefixed assets **and** an unprocessed version CSS are published +4. Remove minifier and vendor prefix from other packages From ce1bd3bd2f4ae13bffcf0f9df07f98dbdc70bb41 Mon Sep 17 00:00:00 2001 From: Elise Chant Date: Mon, 13 Dec 2021 16:47:06 +1100 Subject: [PATCH 2/3] formatted --- .../1-approved/distribute-css-as-unprefixed.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md index 7395241..7acba1a 100644 --- a/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md +++ b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md @@ -9,24 +9,22 @@ Implementer: # It will be changed upon merging and as it moves through the RFC s CSS is currently being distributed as minified and vendor-prefixed assets. -This is unnecessary since users also process styles for minification and vendor-prefixing, therefore css "as modules" should ship without being processed. This issue was raised by @liamfiddler [here](https://github.com/designsystemau/RFCs/pull/11#discussion_r724769922). +This is unnecessary since users also process styles for minification and vendor-prefixing, therefore css "as modules" should ship without being processed. This issue was raised by @liamfiddler [here](https://github.com/designsystemau/RFCs/pull/11#discussion_r724769922). Where users want to consume full CSS however, they may still expect the asset to be vendor prefixed and minified. This scenario might be handled better by delivering styles from a CDN like [UNPKG](https://unpkg.com/). This work should ship with pancake being removed [#1](https://github.com/designsystemau/RFCs/pull/1). - ## A short description of the desired outcome or solution -* Npm packages should contain unprocessed CSS assets -* New package "design-system" is created which provides minified + vendor-prefixed CSS **and** an unprocessed version, ie `gold.min.css` and `gold.css` -* Usage of the new package is documented - +- Npm packages should contain unprocessed CSS assets +- New package "design-system" is created which provides minified + vendor-prefixed CSS **and** an unprocessed version, ie `gold.min.css` and `gold.css` +- Usage of the new package is documented ## Technical details -Assuming that pancake has been removed. +Assuming that pancake has been removed. 1. Create a new package "design-system", (gold-design-system/packages/design-system) to generate a full CSS 2. In the design-system package, minified + vendor-prefixed assets **and** an unprocessed version CSS are published -4. Remove minifier and vendor prefix from other packages +3. Remove minifier and vendor prefix from other packages From 6a519e5ce0473013ca4c2d07382748e0ffab0abf Mon Sep 17 00:00:00 2001 From: Elise Chant Date: Mon, 13 Dec 2021 16:48:28 +1100 Subject: [PATCH 3/3] update --- RFC-by-stage/1-approved/distribute-css-as-unprefixed.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md index 7acba1a..37be9c7 100644 --- a/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md +++ b/RFC-by-stage/1-approved/distribute-css-as-unprefixed.md @@ -9,7 +9,7 @@ Implementer: # It will be changed upon merging and as it moves through the RFC s CSS is currently being distributed as minified and vendor-prefixed assets. -This is unnecessary since users also process styles for minification and vendor-prefixing, therefore css "as modules" should ship without being processed. This issue was raised by @liamfiddler [here](https://github.com/designsystemau/RFCs/pull/11#discussion_r724769922). +This is unnecessary since users (developing apps using npm) process styles for minification and vendor-prefixing, therefore css "as modules" should ship without being processed. This issue was raised by @liamfiddler [here](https://github.com/designsystemau/RFCs/pull/11#discussion_r724769922). Where users want to consume full CSS however, they may still expect the asset to be vendor prefixed and minified. This scenario might be handled better by delivering styles from a CDN like [UNPKG](https://unpkg.com/).