Skip to content

Turn off linting by default in VS Code for Python#449

Merged
samruddhikhandale merged 5 commits into
devcontainers:mainfrom
brettcannon:simplify-python-tools
Mar 1, 2023
Merged

Turn off linting by default in VS Code for Python#449
samruddhikhandale merged 5 commits into
devcontainers:mainfrom
brettcannon:simplify-python-tools

Conversation

@brettcannon
Copy link
Copy Markdown
Contributor

Linting is on by default if you specify the paths to any linters, so the previous settings would turn on all linters.

Also drop linters that don't see much use.

Linting is on by default if you specify the paths to any linters, so the previous settings would turn on **all** linters.

Also drop linters that don't see much use.
Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some thoughts!

Comment thread src/python/install.sh Outdated
Comment thread src/python/devcontainer-feature.json
@brettcannon
Copy link
Copy Markdown
Contributor Author

@samruddhikhandale I updated the PR to only remove settings related to the under-utilized tool support in the Python extension for VS Code and to turn linting off by default so users can choose which linter they want.

Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🚢

@samruddhikhandale samruddhikhandale merged commit 4b7efeb into devcontainers:main Mar 1, 2023
@brettcannon brettcannon deleted the simplify-python-tools branch March 2, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants