From 1ea27ba43d43f4dc32f101e20c4318d2327d8081 Mon Sep 17 00:00:00 2001 From: David Leal Date: Sun, 4 Sep 2022 23:08:41 -0500 Subject: [PATCH 1/3] Minor template/stale message improvements --- .github/ISSUE_TEMPLATE/bug_report.yml | 6 +++--- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- .github/ISSUE_TEMPLATE/icon_request.yml | 2 +- .github/ISSUE_TEMPLATE/other.yml | 4 ++-- .github/PULL_REQUEST_TEMPLATE/new_feature.md | 3 ++- .github/drafts/stale.yml | 13 ++++++++----- .github/pull_request_template.md | 14 ++++++++++---- 7 files changed, 27 insertions(+), 17 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 6d5ea7c74..2bf834b08 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,6 +1,6 @@ name: Bug Report -description: Report a bug/issue that you found in the SVGs, CSS files, etc. -title: '[BUG] ' +description: Report a bug/issue that you found in the SVGs, CSS files, or any other bug you encounter. +title: '[BUG]: ' labels: [bug] body: - type: markdown @@ -18,7 +18,7 @@ body: id: description attributes: label: Bug description - description: Short description of the bug that you found. Provide images/code if applicable. + description: Short description of the bug you found. Provide images/code if applicable. validations: required: true diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index ce99b04e5..41ca5167e 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,6 +1,6 @@ name: Feature Request description: Requesting a new feature or changes to an existing feature -title: '[FEATURE REQUEST] ' +title: '[FEATURE REQUEST]: ' labels: [enhancement] body: - type: markdown diff --git a/.github/ISSUE_TEMPLATE/icon_request.yml b/.github/ISSUE_TEMPLATE/icon_request.yml index 42b9370f1..1970517d0 100644 --- a/.github/ISSUE_TEMPLATE/icon_request.yml +++ b/.github/ISSUE_TEMPLATE/icon_request.yml @@ -1,5 +1,5 @@ name: Icon Request -description: Requesting a new icon or changes to an existing icon +description: Request a new icon or changes to an existing icon title: '[ICON REQUEST]: ' labels: ["request:icon"] body: diff --git a/.github/ISSUE_TEMPLATE/other.yml b/.github/ISSUE_TEMPLATE/other.yml index 2033b4e71..9efe45b0a 100644 --- a/.github/ISSUE_TEMPLATE/other.yml +++ b/.github/ISSUE_TEMPLATE/other.yml @@ -1,6 +1,6 @@ name: Other -description: Use this for any other issues. Do not create blank issues -title: "[OTHER] " +description: Use this for any other issues. Please do NOT create blank issues +title: "[OTHER]: " labels: ["awaiting triage"] body: - type: markdown diff --git a/.github/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/PULL_REQUEST_TEMPLATE/new_feature.md index 9df58fd52..d6b448e83 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/PULL_REQUEST_TEMPLATE/new_feature.md @@ -4,10 +4,11 @@ - [ ] PR does not match another non-stale PR currently opened ## Features - + **This PR closes NONE** + ## Notes diff --git a/.github/drafts/stale.yml b/.github/drafts/stale.yml index 859b053da..df3153c95 100644 --- a/.github/drafts/stale.yml +++ b/.github/drafts/stale.yml @@ -10,13 +10,16 @@ jobs: - uses: actions/stale@main with: repo-token: ${{ secrets.GITHUB_TOKEN }} - stale-pr-message: 'Hello there, - we noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository, - we would love to have it. It would be great if you can continue with this PR, but if you cannot, we might fork your changes and merge the changes ourselves. + stale-pr-message: "Hello there, + we have noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository, + we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge the changes ourselves. - Since GitHub tracks contributions by commits, you will still be credited. + Since GitHub tracks contributions by commits, you'll still be credited. + Let us know what do you think about this. :slight_smile: - Let us know what you think 😃' + + Feel free to join our Discord server for support, hangouts, and more: https://discord.gg/hScy8KWACQ + Thank you and have a nice day!" stale-pr-label: 'stale' days-before-pr-stale: 30 days-before-pr-close: -1 diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 99a2cb900..3a267cf7f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,11 @@ -### Adding a New Icon? -- Add `?quick_pull=1&template=new_icon.md` to the end of your current URL and press `Enter` + From 238a3f5e66ee574e943a644f9847a4e8d9426a6d Mon Sep 17 00:00:00 2001 From: David Leal Date: Sat, 24 Sep 2022 20:34:21 -0500 Subject: [PATCH 2/3] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jørgen Kalsnes Hagen < > --- .github/ISSUE_TEMPLATE/icon_request.yml | 2 +- .github/PULL_REQUEST_TEMPLATE/new_feature.md | 2 +- .github/drafts/stale.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/icon_request.yml b/.github/ISSUE_TEMPLATE/icon_request.yml index 1970517d0..effc8ebcd 100644 --- a/.github/ISSUE_TEMPLATE/icon_request.yml +++ b/.github/ISSUE_TEMPLATE/icon_request.yml @@ -1,5 +1,5 @@ name: Icon Request -description: Request a new icon or changes to an existing icon +description: Request a new icon, or changes to an existing icon title: '[ICON REQUEST]: ' labels: ["request:icon"] body: diff --git a/.github/PULL_REQUEST_TEMPLATE/new_feature.md b/.github/PULL_REQUEST_TEMPLATE/new_feature.md index d6b448e83..f9275df63 100644 --- a/.github/PULL_REQUEST_TEMPLATE/new_feature.md +++ b/.github/PULL_REQUEST_TEMPLATE/new_feature.md @@ -8,7 +8,7 @@ **This PR closes NONE** - + ## Notes diff --git a/.github/drafts/stale.yml b/.github/drafts/stale.yml index df3153c95..5d890f82d 100644 --- a/.github/drafts/stale.yml +++ b/.github/drafts/stale.yml @@ -15,10 +15,10 @@ jobs: we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge the changes ourselves. Since GitHub tracks contributions by commits, you'll still be credited. - Let us know what do you think about this. :slight_smile: + Let us know what you think about this. :slight_smile: - Feel free to join our Discord server for support, hangouts, and more: https://discord.gg/hScy8KWACQ + Feel free to [join our Discord server](https://discord.gg/hScy8KWACQ) for support, hangouts, and more Thank you and have a nice day!" stale-pr-label: 'stale' days-before-pr-stale: 30 From 1d1d415b73a2b2148721960bb0a4d63617217b0f Mon Sep 17 00:00:00 2001 From: David Leal Date: Sun, 25 Sep 2022 16:17:07 -0500 Subject: [PATCH 3/3] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jørgen Kalsnes Hagen --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/drafts/stale.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 2bf834b08..ddcfa98ae 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -18,7 +18,7 @@ body: id: description attributes: label: Bug description - description: Short description of the bug you found. Provide images/code if applicable. + description: Short description of the bug. Provide images/code if applicable. validations: required: true diff --git a/.github/drafts/stale.yml b/.github/drafts/stale.yml index 5d890f82d..41d74cf7e 100644 --- a/.github/drafts/stale.yml +++ b/.github/drafts/stale.yml @@ -12,7 +12,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-pr-message: "Hello there, we have noticed that this PR has been inactive for a while now. If there are any changes which are suitable for our repository, - we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge the changes ourselves. + we would love to have it. It would be great if you can continue with this PR, but if you can't, we might fork your changes and merge them ourselves. Since GitHub tracks contributions by commits, you'll still be credited. Let us know what you think about this. :slight_smile: