From ce6863a464ff572f584158d6b037fa16674e328a Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:20:53 +0100 Subject: [PATCH 1/8] setup npm_publish workflow and update package.json with new repo info --- .github/workflows/npm_publish.yml | 17 +++++++++++++++++ package.json | 10 +++++----- 2 files changed, 22 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/npm_publish.yml diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml new file mode 100644 index 000000000..f856c0e20 --- /dev/null +++ b/.github/workflows/npm_publish.yml @@ -0,0 +1,17 @@ +on: + release: + types: [released] +jobs: + publish: + name: 'npm publish' + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: actions/setup-node@v1 + with: + node-version: 10 + - run: npm install + - run: npm test + - uses: JS-DevTools/npm-publish@v1 + with: + token: '${{ secrets.NPM_AUTOMATION_TOKEN }}' diff --git a/package.json b/package.json index cdbe8970d..6f1111da0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.2.0", + "version": "2.9.0", "description": "Programming related icons collection", "main": "devicon.min.css", "scripts": { @@ -10,7 +10,7 @@ }, "repository": { "type": "git", - "url": "https://github.com/konpa/devicon.git" + "url": "https://github.com/devicons/devicon.git" }, "keywords": [ "programming", @@ -18,12 +18,12 @@ "svg", "font" ], - "author": "konpa", + "author": "devicons", "license": "MIT", "bugs": { - "url": "https://github.com/konpa/devicon/issues" + "url": "https://github.com/devicons/devicon/issues" }, - "homepage": "http://konpa.github.io/devicon/", + "homepage": "https://devicon.dev", "devDependencies": { "gulp": "^4.0.0", "gulp-sass": "^4.1.0", From 68b1bf94d6186bb3c982e5cd79b4c0d4b605e3d7 Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:43:48 +0100 Subject: [PATCH 2/8] refactoring npm publish workflow to reduce dependencies --- .github/workflows/npm_publish.yml | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index f856c0e20..26e8a2a28 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -3,15 +3,24 @@ on: types: [released] jobs: publish: - name: 'npm publish' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 - - uses: actions/setup-node@v1 + - uses: actions/checkout@v2 with: - node-version: 10 - - run: npm install - - run: npm test - - uses: JS-DevTools/npm-publish@v1 + # "ref" specifies the branch to check out. + # "github.event.release.target_commitish" is a global variable and specifies the branch the release targeted + ref: ${{ github.event.release.target_commitish }} + - name: Use Node.js 12 + uses: actions/setup-node@v1 with: - token: '${{ secrets.NPM_AUTOMATION_TOKEN }}' + node-version: 12 + registry-url: https://registry.npmjs.org/ # Specifies the registry, this field is required! + - run: npm ci + - run: npm version ${{ github.event.release.tag_name }} --allow-same-version -m "npm publish to %s" + - run: npm publish + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTOMATION_TOKEN }} + - run: git push + env: + github-token: ${{ secrets.GITHUB_TOKEN }} + From 10a789094beb82cb7ff642ca66c6719c0311b744 Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:43:58 +0100 Subject: [PATCH 3/8] npm publish to 2.9.0 --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index f995f26eb..4945858d5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.2.0", + "version": "2.9.0", "lockfileVersion": 1, "requires": true, "dependencies": { From 3edb5386ead03b42ded24281df48b62e9a96a300 Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:56:29 +0100 Subject: [PATCH 4/8] reduce npm publish workflow to publishing task only --- .github/workflows/npm_publish.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index 26e8a2a28..dfcadfdb6 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -16,11 +16,6 @@ jobs: node-version: 12 registry-url: https://registry.npmjs.org/ # Specifies the registry, this field is required! - run: npm ci - - run: npm version ${{ github.event.release.tag_name }} --allow-same-version -m "npm publish to %s" - run: npm publish env: NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTOMATION_TOKEN }} - - run: git push - env: - github-token: ${{ secrets.GITHUB_TOKEN }} - From 83be4703175b6982eea6c64897768e4440175048 Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:56:30 +0100 Subject: [PATCH 5/8] npm publish to 2.9.0 From 85d810c0d39600ce668cba467d309a13823f0fb3 Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 02:58:57 +0100 Subject: [PATCH 6/8] testing npm publish --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4945858d5..f995f26eb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.9.0", + "version": "2.2.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 6f1111da0..9c6ea09c9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.9.0", + "version": "2.2.0", "description": "Programming related icons collection", "main": "devicon.min.css", "scripts": { From 94252680d5f9cc81c1b5a6ee9546beec31b6178e Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 03:05:49 +0100 Subject: [PATCH 7/8] update npm version to 2.9.0 (latest release) --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index f995f26eb..4945858d5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.2.0", + "version": "2.9.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 9c6ea09c9..6f1111da0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.2.0", + "version": "2.9.0", "description": "Programming related icons collection", "main": "devicon.min.css", "scripts": { From 700ff32c6ac01c79804b6933cae04b748d1ac4bb Mon Sep 17 00:00:00 2001 From: amacado Date: Sun, 21 Feb 2021 03:18:49 +0100 Subject: [PATCH 8/8] enhance CONTRIBUTING.md with sentence about npm release workflow --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f560885d1..81d5ca3d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -259,4 +259,5 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
  • Ensure code quality is up to standard
  • Upload svgs to icomoon.io and take a screenshot to check that it looks good.
  • Comment on the PR so maintainers don't have to manually upload icon result.
    • +
  • Publishing a new release to npm; See #288